Re: [PATCH] scripts: gtags_files_generator.sh

[xujialu <xujialu@vimux.org>]

Hi, greg

I'm really sorry for the bad reply i did, i even don't know what was my email problem ..

I mean i'm very new to git-send-email related, very very confused about the email processing..

Please help me understanding where my problem is, I am very serious in organizing this

submission related email, even every sentence written in the email.

Did i filled the wrong msg-id in --in-reply-to? Or i should directly answer your question by following

format, just like your reply:

        > make defconfig
        > make
        > scripts/gtags_files_generator.sh
        > gtags [-f gtags.files]
        >
        > Enjoy with vim+gtags. :)

        What's wrong with just 'make gtags' that we currently have in the kernel
        tree?  Shouldn't that be sufficient, and if not, then you need to
        explain why it isn't in your changelog.

How do you add '>' before this lines, all by hands?

If I did something wrong, please help me to know it, (oh, my poor english ..)

Thanks! :(

This email is not send by git-send-email.


------------------ Original ------------------
From: "gregkh"<gregkh@linuxfoundation.org>;
Date: Sun, Apr 26, 2020 03:09 PM
To: "xujialu"<xujialu@vimux.org>;
Cc: "corbet"<corbet@lwn.net>;"linux-kernel"<linux-kernel@vger.kernel.org>;"masahiroy"<masahiroy@kernel.org>;"akpm"<akpm@linux-foundation.org>;"mchehab+huawei"<mchehab+huawei@kernel.org>;
Subject: Re: [PATCH] scripts: gtags_files_generator.sh



On Sun, Apr 26, 2020 at 10:44:36AM +0800, xujialu wrote:
> Add a script to generate a more precise gtags.files from *.cmd files.
> 
> For navigating linux sources, it will be more efficient if gtags/cscope
> just collects source files that needed for compilation. The kernel
> makefiles already create *.cmd files that contain the files we needed,
> then just extracts files list from them and into gtags.files cause it's
> the the default name list file for gtags.
> 
> make defconfig
> make
> scripts/gtags_files_generator.sh
> gtags [-f gtags.files]
> 
> Enjoy with vim+gtags. :)
> 
> Here is a log for comparison with 'make gtags':
> 
> $ time make ARCH=arm cscope
>   GEN     cscope
> 
> real	1m20.600s
> user	1m36.004s
> sys	0m8.192s
> $ wc -l cscope.files
> 31201 cscope.files		#collected too many files we don't care
> 
> $ time ./scripts/gtags_files_generator.sh
> 
> Succeed, 3716 gtags.files listed!
> 
> real	0m1.593s		#collected files only we care
> user	0m1.704s
> sys	0m0.256s
> 				#collected also dts and dtsi
> $ grep dts gtags.files
> arch/arm/boot/dts/xxxxxx-clocks.dtsi
> arch/arm/boot/dts/xxxxxx.dtsi
> arch/arm/boot/dts/xxxxxxxx.dts
> arch/arm/boot/dts/xxxxxxxx.dtsi
> 
> Signed-off-by: xujialu <xujialu@vimux.org>
> ---
>  scripts/gtags_files_generator.sh | 48 ++++++++++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100755 scripts/gtags_files_generator.sh

As this is a new version, you need to properly version your patch, as is
documented, please do that.

Also, you seem to be ignoring my previous questions/comments, which
makes me want to just ignore this patch :(

greg k-h