From: Masahiro Yamada <masahiroy@kernel.org>
To: Boris Kolpackov <boris@codesynthesis.com>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kconfig: change .config format to use =n instead of "is not set"
Date: Thu, 3 Mar 2022 09:01:22 +0900 [thread overview]
Message-ID: <CAK7LNAS8GO=XzzaVze8y7142Os6J_htBNVV+6kwiXjSxWfnPDw@mail.gmail.com> (raw)
In-Reply-To: <boris.20220302145825@codesynthesis.com>
On Wed, Mar 2, 2022 at 10:17 PM Boris Kolpackov <boris@codesynthesis.com> wrote:
>
> Masahiro Yamada <masahiroy@kernel.org> writes:
>
> > With this commit, Kconfig will output disable options in a more natural
> > form, "CONFIG_FOO=n".
>
> While I agree with the overall direction, I was wondering how this
> relates to string and int/hex options. It appears that they either
> have a value or are not written to the .config at all, for example,
> if the option is disabled via the `depends on` attribute. At first
> I thought this would be inconsistent (i.e., =n for bool and omitted
> for string), but it appears a disabled bool option is also omitted.
> Hopefully the fact that sometimes a false bool option is =n and
> sometimes it's omitted won't surprise anyone.
Options with unmet 'depends on' are all omitted in the .config
It is consistent for all types.
>
> Reviewed-by: Boris Kolpackov <boris@codesynthesis.com>
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2022-03-03 0:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 12:37 [PATCH] kconfig: change .config format to use =n instead of "is not set" Masahiro Yamada
2022-02-26 21:37 ` Sedat Dilek
2022-02-27 4:23 ` Masahiro Yamada
2022-02-27 7:54 ` Sedat Dilek
2022-03-05 7:18 ` Sedat Dilek
2022-03-02 13:16 ` Boris Kolpackov
2022-03-03 0:01 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNAS8GO=XzzaVze8y7142Os6J_htBNVV+6kwiXjSxWfnPDw@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=boris@codesynthesis.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).