* [PATCH] docs: kbuild: remove description of KBUILD_LDS_MODULE
[not found] <CGME20230222004609epcas1p2eb7e213b2b3503d018fcd6d58b9497b2@epcas1p2.samsung.com>
@ 2023-02-22 0:45 ` Sangmoon Kim
2023-02-22 7:33 ` Bagas Sanjaya
0 siblings, 1 reply; 5+ messages in thread
From: Sangmoon Kim @ 2023-02-22 0:45 UTC (permalink / raw)
To: Masahiro Yamada, Jonathan Corbet
Cc: Sangmoon Kim, Nathan Chancellor, Nick Desaulniers,
Nicolas Schier, linux-kbuild, linux-doc, linux-kernel
Commit 596b0474d3d9 ("kbuild: preprocess module linker script")
has removed KBUILD_LDS_MODULE variable.
The KBUILD_LDS_MODULE variable is no longer available, so this patch
removes it from the document.
Signed-off-by: Sangmoon Kim <sangmoon.kim@samsung.com>
---
Documentation/kbuild/makefiles.rst | 5 -----
1 file changed, 5 deletions(-)
diff --git a/Documentation/kbuild/makefiles.rst b/Documentation/kbuild/makefiles.rst
index 38bc74eaa547..468e7830c1c3 100644
--- a/Documentation/kbuild/makefiles.rst
+++ b/Documentation/kbuild/makefiles.rst
@@ -1250,11 +1250,6 @@ When kbuild executes, the following steps are followed (roughly):
The linker script with full path. Assigned by the top-level Makefile.
- KBUILD_LDS_MODULE
-
- The module linker script with full path. Assigned by the top-level
- Makefile and additionally by the arch Makefile.
-
KBUILD_VMLINUX_OBJS
All object files for vmlinux. They are linked to vmlinux in the same
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] docs: kbuild: remove description of KBUILD_LDS_MODULE
2023-02-22 0:45 ` [PATCH] docs: kbuild: remove description of KBUILD_LDS_MODULE Sangmoon Kim
@ 2023-02-22 7:33 ` Bagas Sanjaya
[not found] ` <CGME20230222104856epcas1p3a6ff45f90292df33ef5fd8216b812f64@epcas1p3.samsung.com>
0 siblings, 1 reply; 5+ messages in thread
From: Bagas Sanjaya @ 2023-02-22 7:33 UTC (permalink / raw)
To: Sangmoon Kim, Masahiro Yamada, Jonathan Corbet
Cc: Nathan Chancellor, Nick Desaulniers, Nicolas Schier,
linux-kbuild, linux-doc, linux-kernel
On 2/22/23 07:45, Sangmoon Kim wrote:
> Commit 596b0474d3d9 ("kbuild: preprocess module linker script")
> has removed KBUILD_LDS_MODULE variable.
>
> The KBUILD_LDS_MODULE variable is no longer available, so this patch
> removes it from the document.
>
What about "Commit <commit> removes KBUILD_LDS_MODULE, yet the variable
is still mentioned in kbuild documentation. Remove the reference to
the now-nonexistent variable."?
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] docs: kbuild: remove description of KBUILD_LDS_MODULE
[not found] ` <CGME20230222104856epcas1p3a6ff45f90292df33ef5fd8216b812f64@epcas1p3.samsung.com>
@ 2023-02-22 10:47 ` Sangmoon Kim
2023-02-22 16:21 ` Nathan Chancellor
2023-02-25 8:41 ` Masahiro Yamada
0 siblings, 2 replies; 5+ messages in thread
From: Sangmoon Kim @ 2023-02-22 10:47 UTC (permalink / raw)
To: bagasdotme
Cc: corbet, linux-doc, linux-kbuild, linux-kernel, masahiroy, nathan,
ndesaulniers, nicolas, Sangmoon Kim
Commit 596b0474d3d9 ("kbuild: preprocess module linker script")
removes KBUILD_LDS_MODULE, yet the variable is still mentioned in
kbuild documentation. Remove the reference to the now-nonexistent
variable.
Signed-off-by: Sangmoon Kim <sangmoon.kim@samsung.com>
---
Thank you for your review.
Changes in v2:
- Update the commit message.
Documentation/kbuild/makefiles.rst | 5 -----
1 file changed, 5 deletions(-)
diff --git a/Documentation/kbuild/makefiles.rst b/Documentation/kbuild/makefiles.rst
index 38bc74eaa547..468e7830c1c3 100644
--- a/Documentation/kbuild/makefiles.rst
+++ b/Documentation/kbuild/makefiles.rst
@@ -1250,11 +1250,6 @@ When kbuild executes, the following steps are followed (roughly):
The linker script with full path. Assigned by the top-level Makefile.
- KBUILD_LDS_MODULE
-
- The module linker script with full path. Assigned by the top-level
- Makefile and additionally by the arch Makefile.
-
KBUILD_VMLINUX_OBJS
All object files for vmlinux. They are linked to vmlinux in the same
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] docs: kbuild: remove description of KBUILD_LDS_MODULE
2023-02-22 10:47 ` [PATCH v2] " Sangmoon Kim
@ 2023-02-22 16:21 ` Nathan Chancellor
2023-02-25 8:41 ` Masahiro Yamada
1 sibling, 0 replies; 5+ messages in thread
From: Nathan Chancellor @ 2023-02-22 16:21 UTC (permalink / raw)
To: Sangmoon Kim
Cc: bagasdotme, corbet, linux-doc, linux-kbuild, linux-kernel,
masahiroy, ndesaulniers, nicolas
On Wed, Feb 22, 2023 at 07:47:19PM +0900, Sangmoon Kim wrote:
> Commit 596b0474d3d9 ("kbuild: preprocess module linker script")
> removes KBUILD_LDS_MODULE, yet the variable is still mentioned in
> kbuild documentation. Remove the reference to the now-nonexistent
> variable.
>
> Signed-off-by: Sangmoon Kim <sangmoon.kim@samsung.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> Thank you for your review.
>
> Changes in v2:
> - Update the commit message.
>
> Documentation/kbuild/makefiles.rst | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/Documentation/kbuild/makefiles.rst b/Documentation/kbuild/makefiles.rst
> index 38bc74eaa547..468e7830c1c3 100644
> --- a/Documentation/kbuild/makefiles.rst
> +++ b/Documentation/kbuild/makefiles.rst
> @@ -1250,11 +1250,6 @@ When kbuild executes, the following steps are followed (roughly):
>
> The linker script with full path. Assigned by the top-level Makefile.
>
> - KBUILD_LDS_MODULE
> -
> - The module linker script with full path. Assigned by the top-level
> - Makefile and additionally by the arch Makefile.
> -
> KBUILD_VMLINUX_OBJS
>
> All object files for vmlinux. They are linked to vmlinux in the same
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] docs: kbuild: remove description of KBUILD_LDS_MODULE
2023-02-22 10:47 ` [PATCH v2] " Sangmoon Kim
2023-02-22 16:21 ` Nathan Chancellor
@ 2023-02-25 8:41 ` Masahiro Yamada
1 sibling, 0 replies; 5+ messages in thread
From: Masahiro Yamada @ 2023-02-25 8:41 UTC (permalink / raw)
To: Sangmoon Kim
Cc: bagasdotme, corbet, linux-doc, linux-kbuild, linux-kernel,
nathan, ndesaulniers, nicolas
On Wed, Feb 22, 2023 at 7:49 PM Sangmoon Kim <sangmoon.kim@samsung.com> wrote:
>
> Commit 596b0474d3d9 ("kbuild: preprocess module linker script")
> removes KBUILD_LDS_MODULE, yet the variable is still mentioned in
> kbuild documentation. Remove the reference to the now-nonexistent
> variable.
>
> Signed-off-by: Sangmoon Kim <sangmoon.kim@samsung.com>
> ---
> Thank you for your review.
>
> Changes in v2:
> - Update the commit message.
>
> Documentation/kbuild/makefiles.rst | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/Documentation/kbuild/makefiles.rst b/Documentation/kbuild/makefiles.rst
> index 38bc74eaa547..468e7830c1c3 100644
> --- a/Documentation/kbuild/makefiles.rst
> +++ b/Documentation/kbuild/makefiles.rst
> @@ -1250,11 +1250,6 @@ When kbuild executes, the following steps are followed (roughly):
>
> The linker script with full path. Assigned by the top-level Makefile.
>
> - KBUILD_LDS_MODULE
> -
> - The module linker script with full path. Assigned by the top-level
> - Makefile and additionally by the arch Makefile.
> -
> KBUILD_VMLINUX_OBJS
>
> All object files for vmlinux. They are linked to vmlinux in the same
> --
> 2.17.1
>
Applied to linux-kbuild.
Thanks.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-25 8:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20230222004609epcas1p2eb7e213b2b3503d018fcd6d58b9497b2@epcas1p2.samsung.com>
2023-02-22 0:45 ` [PATCH] docs: kbuild: remove description of KBUILD_LDS_MODULE Sangmoon Kim
2023-02-22 7:33 ` Bagas Sanjaya
[not found] ` <CGME20230222104856epcas1p3a6ff45f90292df33ef5fd8216b812f64@epcas1p3.samsung.com>
2023-02-22 10:47 ` [PATCH v2] " Sangmoon Kim
2023-02-22 16:21 ` Nathan Chancellor
2023-02-25 8:41 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).