* [PATCH] gcc-plugins: remove always false $(if ...) in Makefile
@ 2020-05-10 2:00 Masahiro Yamada
2020-05-10 2:14 ` Kees Cook
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2020-05-10 2:00 UTC (permalink / raw)
To: Kees Cook, Emese Revfy, kernel-hardening; +Cc: Masahiro Yamada, linux-kernel
This is the remnant of commit c17d6179ad5a ("gcc-plugins: remove unused
GCC_PLUGIN_SUBDIR").
$(if $(findstring /,$(p)),...) is always false because none of plugins
contains '/' in the file name.
Clean up the code.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
scripts/gcc-plugins/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/gcc-plugins/Makefile b/scripts/gcc-plugins/Makefile
index 80f354289eeb..4014ba7e2fbd 100644
--- a/scripts/gcc-plugins/Makefile
+++ b/scripts/gcc-plugins/Makefile
@@ -14,7 +14,7 @@ $(objtree)/$(obj)/randomize_layout_seed.h: FORCE
$(call if_changed,create_randomize_layout_seed)
targets = randomize_layout_seed.h randomize_layout_hash.h
-hostcxxlibs-y := $(foreach p,$(GCC_PLUGIN),$(if $(findstring /,$(p)),,$(p)))
+hostcxxlibs-y := $(GCC_PLUGIN)
always-y := $(hostcxxlibs-y)
$(foreach p,$(hostcxxlibs-y:%.so=%),$(eval $(p)-objs := $(p).o))
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gcc-plugins: remove always false $(if ...) in Makefile
2020-05-10 2:00 [PATCH] gcc-plugins: remove always false $(if ...) in Makefile Masahiro Yamada
@ 2020-05-10 2:14 ` Kees Cook
2020-05-12 5:54 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Kees Cook @ 2020-05-10 2:14 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Emese Revfy, kernel-hardening, linux-kernel
On Sun, May 10, 2020 at 11:00:44AM +0900, Masahiro Yamada wrote:
> This is the remnant of commit c17d6179ad5a ("gcc-plugins: remove unused
> GCC_PLUGIN_SUBDIR").
>
> $(if $(findstring /,$(p)),...) is always false because none of plugins
> contains '/' in the file name.
>
> Clean up the code.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gcc-plugins: remove always false $(if ...) in Makefile
2020-05-10 2:14 ` Kees Cook
@ 2020-05-12 5:54 ` Masahiro Yamada
0 siblings, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2020-05-12 5:54 UTC (permalink / raw)
To: Kees Cook; +Cc: Emese Revfy, Kernel Hardening, Linux Kernel Mailing List
On Sun, May 10, 2020 at 11:14 AM Kees Cook <keescook@chromium.org> wrote:
>
> On Sun, May 10, 2020 at 11:00:44AM +0900, Masahiro Yamada wrote:
> > This is the remnant of commit c17d6179ad5a ("gcc-plugins: remove unused
> > GCC_PLUGIN_SUBDIR").
> >
> > $(if $(findstring /,$(p)),...) is always false because none of plugins
> > contains '/' in the file name.
> >
> > Clean up the code.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
Applied to linux-kbuild.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-12 5:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-10 2:00 [PATCH] gcc-plugins: remove always false $(if ...) in Makefile Masahiro Yamada
2020-05-10 2:14 ` Kees Cook
2020-05-12 5:54 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).