linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4] ARM: mmp: let clk_disable() return immediately if clk is NULL
@ 2016-09-18 17:58 Masahiro Yamada
  2016-11-05 15:42 ` Masahiro Yamada
  0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2016-09-18 17:58 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Stephen Boyd, Ralf Baechle, Michael Turquette, Masahiro Yamada,
	Haojian Zhuang, Eric Miao, Russell King, linux-kernel

In many of clk_disable() implementations, it is a no-op for a NULL
pointer input, but this is one of the exceptions.

Making it treewide consistent will allow clock consumers to call
clk_disable() without NULL pointer check.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

Changes in v4:
  - Split into per-arch patches

Changes in v3:
  - Return only when clk is NULL.  Do not take care of error pointer.

Changes in v2:
  - Rebase on Linux 4.6-rc1

 arch/arm/mach-mmp/clock.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/mach-mmp/clock.c b/arch/arm/mach-mmp/clock.c
index ac6633d..28fe64c 100644
--- a/arch/arm/mach-mmp/clock.c
+++ b/arch/arm/mach-mmp/clock.c
@@ -67,6 +67,9 @@ void clk_disable(struct clk *clk)
 {
 	unsigned long flags;
 
+	if (!clk)
+		return;
+
 	WARN_ON(clk->enabled == 0);
 
 	spin_lock_irqsave(&clocks_lock, flags);
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH v4] ARM: mmp: let clk_disable() return immediately if clk is NULL
  2016-09-18 17:58 [PATCH v4] ARM: mmp: let clk_disable() return immediately if clk is NULL Masahiro Yamada
@ 2016-11-05 15:42 ` Masahiro Yamada
  2017-01-28 13:33   ` Masahiro Yamada
  0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2016-11-05 15:42 UTC (permalink / raw)
  To: linux-arm-kernel, Eric Miao, Haojian Zhuang
  Cc: Michael Turquette, Stephen Boyd, Russell King,
	Linux Kernel Mailing List, Masahiro Yamada, Ralf Baechle

Hi Eric Miao, Haojian Zhuang,

Could you pick up this patch, please?


2016-09-19 2:58 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> In many of clk_disable() implementations, it is a no-op for a NULL
> pointer input, but this is one of the exceptions.
>
> Making it treewide consistent will allow clock consumers to call
> clk_disable() without NULL pointer check.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Changes in v4:
>   - Split into per-arch patches
>
> Changes in v3:
>   - Return only when clk is NULL.  Do not take care of error pointer.
>
> Changes in v2:
>   - Rebase on Linux 4.6-rc1
>
>  arch/arm/mach-mmp/clock.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mach-mmp/clock.c b/arch/arm/mach-mmp/clock.c
> index ac6633d..28fe64c 100644
> --- a/arch/arm/mach-mmp/clock.c
> +++ b/arch/arm/mach-mmp/clock.c
> @@ -67,6 +67,9 @@ void clk_disable(struct clk *clk)
>  {
>         unsigned long flags;
>
> +       if (!clk)
> +               return;
> +
>         WARN_ON(clk->enabled == 0);
>
>         spin_lock_irqsave(&clocks_lock, flags);
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH v4] ARM: mmp: let clk_disable() return immediately if clk is NULL
  2016-11-05 15:42 ` Masahiro Yamada
@ 2017-01-28 13:33   ` Masahiro Yamada
  0 siblings, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2017-01-28 13:33 UTC (permalink / raw)
  To: linux-arm-kernel, Eric Miao, Haojian Zhuang, Haojian Zhuang
  Cc: Michael Turquette, Stephen Boyd, Russell King,
	Linux Kernel Mailing List, Masahiro Yamada, Ralf Baechle

Hi Eric Miao, Haojian Zhuang,

Ping again.

Please apply this patch!


2016-11-06 0:42 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> Hi Eric Miao, Haojian Zhuang,
>
> Could you pick up this patch, please?
>
>
> 2016-09-19 2:58 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
>> In many of clk_disable() implementations, it is a no-op for a NULL
>> pointer input, but this is one of the exceptions.
>>
>> Making it treewide consistent will allow clock consumers to call
>> clk_disable() without NULL pointer check.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>> Changes in v4:
>>   - Split into per-arch patches
>>
>> Changes in v3:
>>   - Return only when clk is NULL.  Do not take care of error pointer.
>>
>> Changes in v2:
>>   - Rebase on Linux 4.6-rc1
>>
>>  arch/arm/mach-mmp/clock.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/mach-mmp/clock.c b/arch/arm/mach-mmp/clock.c
>> index ac6633d..28fe64c 100644
>> --- a/arch/arm/mach-mmp/clock.c
>> +++ b/arch/arm/mach-mmp/clock.c
>> @@ -67,6 +67,9 @@ void clk_disable(struct clk *clk)
>>  {
>>         unsigned long flags;
>>
>> +       if (!clk)
>> +               return;
>> +
>>         WARN_ON(clk->enabled == 0);
>>
>>         spin_lock_irqsave(&clocks_lock, flags);
>> --
>> 1.9.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
>
> --
> Best Regards
> Masahiro Yamada



-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-28 13:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-18 17:58 [PATCH v4] ARM: mmp: let clk_disable() return immediately if clk is NULL Masahiro Yamada
2016-11-05 15:42 ` Masahiro Yamada
2017-01-28 13:33   ` Masahiro Yamada

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).