From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Cc: X86 ML <x86@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Toshi Kani <toshi.kani@hpe.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Borislav Petkov <bp@suse.de>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
"H. Peter Anvin" <hpa@zytor.com>, Nathan Zimmer <nzimmer@sgi.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mike Travis <travis@sgi.com>,
Daniel J Blueman <daniel@numascale.com>,
Dimitri Sivanich <sivanich@sgi.com>,
Matt Fleming <matt@codeblueprint.co.uk>,
Hedi Berriche <hedi@sgi.com>, Steffen Persvold <sp@numascale.com>,
Alex Thorlton <athorlton@sgi.com>,
Wei Jiangang <weijg.fnst@cn.fujitsu.com>
Subject: Re: [PATCH] x86: squash lines for simple wrapper functions
Date: Sat, 10 Sep 2016 18:30:32 +0900 [thread overview]
Message-ID: <CAK7LNASxcum=9PLomcZ+=jOxhaPSzhKZuSXX7i6K21YR=qAamw@mail.gmail.com> (raw)
In-Reply-To: <20160908063359.GB24253@gmail.com>
Hi Ingo, Thomas,
Thanks for your review!
2016-09-08 15:33 GMT+09:00 Ingo Molnar <mingo@kernel.org>:
>> static unsigned int flat_get_apic_id(unsigned long x)
>> {
>> - unsigned int id;
>> -
>> - id = (((x)>>24) & 0xFFu);
>> -
>> - return id;
>> + return ((x) >> 24) & 0xFFu;
>
> So while we are removing unnecessary things, exactly why does the 'x' need
> parentheses?
I will change it to:
return (x >> 24) & 0xFF;
>> static unsigned long set_apic_id(unsigned int id)
>> {
>> - unsigned long x;
>> -
>> - x = ((id & 0xFFu)<<24);
>> - return x;
>> + return (id & 0xFFu) << 24;
>
> 'id' is already unsigned, why does the 'u' have to be stressed in the literal?
> (Ditto for other places as well)
I will change it to:
return (id & 0xFF) << 24;
>> static unsigned long numachip1_set_apic_id(unsigned int id)
>> {
>> - unsigned long x;
>> -
>> - x = ((id & 0xffU) << 24);
>> - return x;
>> + return (id & 0xffU) << 24;
>> }
>
> Why is the spelling of the literal inconsistent here with the other patterns?
I think 0xff is more consistent than 0xFF
in arch/x86/kernel/apic/apic_numachip.c
Making the constant literals consistent across files
is a too much churn, I think.
>> +++ b/arch/x86/kernel/apic/x2apic_uv_x.c
>> @@ -533,11 +533,8 @@ static unsigned int x2apic_get_apic_id(unsigned long x)
>>
>> static unsigned long set_apic_id(unsigned int id)
>> {
>> - unsigned long x;
>> -
>> /* maskout x2apic_extra_bits ? */
>> - x = id;
>> - return x;
>> + return id;
>> }
>
> This was clearly left there to document a quirk and as a placeholder for future
> changes.
>
As suggested by Thomas, I will change it to:
{
/* CHECKME: Do we need to mask out the xapic extra bits? */
return id;
}
(I am adding '?' at the comment line.)
If there is no more comment, I will send v2.
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2016-09-10 9:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 11:24 [PATCH] x86: squash lines for simple wrapper functions Masahiro Yamada
2016-09-08 6:33 ` Ingo Molnar
2016-09-09 14:40 ` Thomas Gleixner
2016-09-10 4:35 ` Ingo Molnar
2016-09-10 5:53 ` Thomas Gleixner
2016-09-10 9:09 ` Ingo Molnar
2016-09-10 9:30 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNASxcum=9PLomcZ+=jOxhaPSzhKZuSXX7i6K21YR=qAamw@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=athorlton@sgi.com \
--cc=bp@suse.de \
--cc=daniel@numascale.com \
--cc=dvlasenk@redhat.com \
--cc=hedi@sgi.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=nzimmer@sgi.com \
--cc=paul.gortmaker@windriver.com \
--cc=sivanich@sgi.com \
--cc=sp@numascale.com \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hpe.com \
--cc=travis@sgi.com \
--cc=weijg.fnst@cn.fujitsu.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).