From: Thomas Gleixner <tglx@linutronix.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
Toshi Kani <toshi.kani@hpe.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Borislav Petkov <bp@suse.de>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
"H. Peter Anvin" <hpa@zytor.com>, Nathan Zimmer <nzimmer@sgi.com>,
linux-kernel@vger.kernel.org, Mike Travis <travis@sgi.com>,
Daniel J Blueman <daniel@numascale.com>,
Dimitri Sivanich <sivanich@sgi.com>,
Matt Fleming <matt@codeblueprint.co.uk>,
Hedi Berriche <hedi@sgi.com>, Steffen Persvold <sp@numascale.com>,
Alex Thorlton <athorlton@sgi.com>,
Wei Jiangang <weijg.fnst@cn.fujitsu.com>
Subject: Re: [PATCH] x86: squash lines for simple wrapper functions
Date: Sat, 10 Sep 2016 07:53:42 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609100752450.9305@nanos> (raw)
In-Reply-To: <20160910043533.GB6061@gmail.com>
On Sat, 10 Sep 2016, Ingo Molnar wrote:
> * Thomas Gleixner <tglx@linutronix.de> wrote:
>
> > On Thu, 8 Sep 2016, Ingo Molnar wrote:
> > > * Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> > > > static unsigned long set_apic_id(unsigned int id)
> > > > {
> > > > - unsigned long x;
> > > > -
> > > > /* maskout x2apic_extra_bits ? */
> > > > - x = id;
> > > > - return x;
> > > > + return id;
> > > > }
> > >
> > > This was clearly left there to document a quirk and as a placeholder for future
> > > changes.
> >
> > Keeping the comment and rewording it to:
> >
> > /* CHECKME: Do we need to mask out the xapic extra bits */
> >
> > should be good enough. The variable dance is not really giving any value.
>
> Yeah, sure - my point was that the mindless removal is wrong.
He kept the comment. The rewording is a bonus.
next prev parent reply other threads:[~2016-09-10 5:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 11:24 [PATCH] x86: squash lines for simple wrapper functions Masahiro Yamada
2016-09-08 6:33 ` Ingo Molnar
2016-09-09 14:40 ` Thomas Gleixner
2016-09-10 4:35 ` Ingo Molnar
2016-09-10 5:53 ` Thomas Gleixner [this message]
2016-09-10 9:09 ` Ingo Molnar
2016-09-10 9:30 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609100752450.9305@nanos \
--to=tglx@linutronix.de \
--cc=athorlton@sgi.com \
--cc=bp@suse.de \
--cc=daniel@numascale.com \
--cc=dvlasenk@redhat.com \
--cc=hedi@sgi.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=nzimmer@sgi.com \
--cc=paul.gortmaker@windriver.com \
--cc=sivanich@sgi.com \
--cc=sp@numascale.com \
--cc=toshi.kani@hpe.com \
--cc=travis@sgi.com \
--cc=weijg.fnst@cn.fujitsu.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).