From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 05/11] mtd: rawnand: denali: rename irq_status to irq_stat
Date: Mon, 11 Feb 2019 10:15:07 +0900 [thread overview]
Message-ID: <CAK7LNAT0hJJ=PWJhWo5cjtboN6qW5JFtOV+WzrLyFy=zRXjwFw@mail.gmail.com> (raw)
In-Reply-To: <20190208225733.2c8779b9@xps13>
Hi Miquel,
On Sat, Feb 9, 2019 at 6:57 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hi Masahiro,
>
> Masahiro Yamada <yamada.masahiro@socionext.com> wrote on Fri, 8 Feb
> 2019 17:08:49 +0900:
>
> > I will add the third argument to denali_wait_for_irq() in the
> > following commit. Then, some lines will exceed 80 columns.
> >
> > Rename 'irq_status' to 'irq_stat'. Saving two characters will avoid
> > line-wrapping in some places, and keep the code clean.
>
> I had a look at the changes and I don't think this is worth the
> trouble. I don't find irq_stat meaningful enough compared to
> irq_status. If you want, you may break lines between arguments of a
> function instead.
OK, I will drop this patch from v2.
> >
> > I replaced uint32_t with u32 in the touched lines. This will reduce
> > the reports from 'scripts/checkpatch.pl --strict'.
>
> While you are at it, it might be interesting to convert the whole
> driver in one go to using u8, u16 and u32?
I did this in 11/11.
http://patchwork.ozlabs.org/patch/1038507/
I will move all uint32_t -> u32 conversions to the last patch
if this is worthwhile.
Thanks.
> Thanks,
> Miquèl
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2019-02-11 1:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 8:08 [PATCH 00/11] mtd: rawnand: denali: exec_op(), controller/chip separation, and cleanups Masahiro Yamada
2019-02-08 8:08 ` [PATCH 01/11] mtd: rawnand: denali: use nand_chip pointer more for internal functions Masahiro Yamada
2019-02-08 8:08 ` [PATCH 02/11] mtd: rawnand: denali: refactor syndrome layout handling for raw access Masahiro Yamada
2019-02-08 8:08 ` [PATCH 03/11] mtd: rawnand: denali: remove unneeded casts in denali_{read,write}_pio Masahiro Yamada
2019-02-08 8:08 ` [PATCH 04/11] mtd: rawnand: denali: switch over to ->exec_op() from legacy hooks Masahiro Yamada
2019-02-08 9:49 ` Masahiro Yamada
2019-02-08 8:08 ` [PATCH 05/11] mtd: rawnand: denali: rename irq_status to irq_stat Masahiro Yamada
2019-02-08 21:57 ` Miquel Raynal
2019-02-11 1:15 ` Masahiro Yamada [this message]
2019-02-08 8:08 ` [PATCH 06/11] mtd: rawnand: denali: use more precise timeout for NAND_OP_WAITRDT_INSTR Masahiro Yamada
2019-02-08 22:05 ` Miquel Raynal
2019-02-11 1:26 ` Masahiro Yamada
2019-02-08 8:08 ` [PATCH 07/11] mtd: rawnand: denali: use bool type instead of int where appropriate Masahiro Yamada
2019-02-08 9:23 ` Joe Perches
2019-02-08 9:33 ` Masahiro Yamada
2019-02-08 22:11 ` Miquel Raynal
2019-02-08 8:08 ` [PATCH 08/11] mtd: rawnand: denali_pci: rename goto labels Masahiro Yamada
2019-02-08 8:08 ` [PATCH 09/11] mtd: rawnand: denali: decouple controller and NAND chips Masahiro Yamada
2019-02-08 8:08 ` [PATCH 10/11] mtd: rawnand: denali: remove DENALI_NR_BANKS macro Masahiro Yamada
2019-02-08 8:08 ` [PATCH 11/11] mtd: rawnand: denali: clean up coding style Masahiro Yamada
2019-02-08 21:55 ` [PATCH 00/11] mtd: rawnand: denali: exec_op(), controller/chip separation, and cleanups Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNAT0hJJ=PWJhWo5cjtboN6qW5JFtOV+WzrLyFy=zRXjwFw@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).