* [PATCH] kconfig: be more helpful if pkg-config is missing
@ 2019-11-04 20:44 Alyssa Ross
2019-11-05 4:28 ` Masahiro Yamada
0 siblings, 1 reply; 5+ messages in thread
From: Alyssa Ross @ 2019-11-04 20:44 UTC (permalink / raw)
To: linux-kbuild; +Cc: Masahiro Yamada, linux-kernel, Alyssa Ross
If ncurses is installed, but at a non-default location, the previous
error message was not helpful in resolving the situation. Now, if
ncurses can't be found, and pkg-config is not installed, it will
suggest that pkg-config might need to be installed in addition to
ncurses.
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
scripts/kconfig/mconf-cfg.sh | 14 ++++++++++++--
scripts/kconfig/nconf-cfg.sh | 14 ++++++++++++--
2 files changed, 24 insertions(+), 4 deletions(-)
diff --git a/scripts/kconfig/mconf-cfg.sh b/scripts/kconfig/mconf-cfg.sh
index c812872d7f9d..f547b13f77f6 100755
--- a/scripts/kconfig/mconf-cfg.sh
+++ b/scripts/kconfig/mconf-cfg.sh
@@ -41,7 +41,17 @@ fi
echo >&2 "*"
echo >&2 "* Unable to find the ncurses package."
-echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
-echo >&2 "* depending on your distribution)."
+echo >&2 "*"
+if [ -n "$(command -v pkg-config)" ]; then
+ echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
+ echo >&2 "* depending on your distribution)."
+else
+ echo >&2 "* You may need to install ncurses"
+ echo >&2 "* (ncurses-devel or libncurses-dev"
+ echo >&2 "* depending on your distribution)."
+ echo >&2 "*"
+ echo >&2 "* If you have ncurses installed,"
+ echo >&2 "* you may also need to install pkg-config."
+fi
echo >&2 "*"
exit 1
diff --git a/scripts/kconfig/nconf-cfg.sh b/scripts/kconfig/nconf-cfg.sh
index 001559ef0a60..569226f1b497 100755
--- a/scripts/kconfig/nconf-cfg.sh
+++ b/scripts/kconfig/nconf-cfg.sh
@@ -41,7 +41,17 @@ fi
echo >&2 "*"
echo >&2 "* Unable to find the ncurses package."
-echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
-echo >&2 "* depending on your distribution)."
+echo >&2 "*"
+if [ -n "$(command -v pkg-config)" ]; then
+ echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
+ echo >&2 "* depending on your distribution)."
+else
+ echo >&2 "* You may need to install ncurses"
+ echo >&2 "* (ncurses-devel or libncurses-dev"
+ echo >&2 "* depending on your distribution)."
+ echo >&2 "*"
+ echo >&2 "* If you have ncurses installed,"
+ echo >&2 "* you may also need to install pkg-config."
+fi
echo >&2 "*"
exit 1
--
2.23.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] kconfig: be more helpful if pkg-config is missing
2019-11-04 20:44 [PATCH] kconfig: be more helpful if pkg-config is missing Alyssa Ross
@ 2019-11-05 4:28 ` Masahiro Yamada
2019-11-05 15:04 ` [PATCH v2] " Alyssa Ross
0 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2019-11-05 4:28 UTC (permalink / raw)
To: Alyssa Ross; +Cc: Linux Kbuild mailing list, Linux Kernel Mailing List
On Tue, Nov 5, 2019 at 5:47 AM Alyssa Ross <hi@alyssa.is> wrote:
>
> If ncurses is installed, but at a non-default location, the previous
> error message was not helpful in resolving the situation. Now, if
> ncurses can't be found, and pkg-config is not installed, it will
> suggest that pkg-config might need to be installed in addition to
> ncurses.
>
> Signed-off-by: Alyssa Ross <hi@alyssa.is>
> ---
I do not like to complicate the error message.
How about appending a little more info, like this?
*
* Unable to find the ncurses package.
* Install ncurses (ncurses-devel or libncurses-dev
* depending on your distribution).
*
* You may also need to install pkg-config to find the
* ncurses installed in a non-default location.
*
Thanks.
> scripts/kconfig/mconf-cfg.sh | 14 ++++++++++++--
> scripts/kconfig/nconf-cfg.sh | 14 ++++++++++++--
> 2 files changed, 24 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/kconfig/mconf-cfg.sh b/scripts/kconfig/mconf-cfg.sh
> index c812872d7f9d..f547b13f77f6 100755
> --- a/scripts/kconfig/mconf-cfg.sh
> +++ b/scripts/kconfig/mconf-cfg.sh
> @@ -41,7 +41,17 @@ fi
>
> echo >&2 "*"
> echo >&2 "* Unable to find the ncurses package."
> -echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
> -echo >&2 "* depending on your distribution)."
> +echo >&2 "*"
> +if [ -n "$(command -v pkg-config)" ]; then
> + echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
> + echo >&2 "* depending on your distribution)."
> +else
> + echo >&2 "* You may need to install ncurses"
> + echo >&2 "* (ncurses-devel or libncurses-dev"
> + echo >&2 "* depending on your distribution)."
> + echo >&2 "*"
> + echo >&2 "* If you have ncurses installed,"
> + echo >&2 "* you may also need to install pkg-config."
> +fi
> echo >&2 "*"
> exit 1
> diff --git a/scripts/kconfig/nconf-cfg.sh b/scripts/kconfig/nconf-cfg.sh
> index 001559ef0a60..569226f1b497 100755
> --- a/scripts/kconfig/nconf-cfg.sh
> +++ b/scripts/kconfig/nconf-cfg.sh
> @@ -41,7 +41,17 @@ fi
>
> echo >&2 "*"
> echo >&2 "* Unable to find the ncurses package."
> -echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
> -echo >&2 "* depending on your distribution)."
> +echo >&2 "*"
> +if [ -n "$(command -v pkg-config)" ]; then
> + echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
> + echo >&2 "* depending on your distribution)."
> +else
> + echo >&2 "* You may need to install ncurses"
> + echo >&2 "* (ncurses-devel or libncurses-dev"
> + echo >&2 "* depending on your distribution)."
> + echo >&2 "*"
> + echo >&2 "* If you have ncurses installed,"
> + echo >&2 "* you may also need to install pkg-config."
> +fi
> echo >&2 "*"
> exit 1
> --
> 2.23.0
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] kconfig: be more helpful if pkg-config is missing
2019-11-05 4:28 ` Masahiro Yamada
@ 2019-11-05 15:04 ` Alyssa Ross
2019-11-05 15:07 ` [PATCH v3] " Alyssa Ross
0 siblings, 1 reply; 5+ messages in thread
From: Alyssa Ross @ 2019-11-05 15:04 UTC (permalink / raw)
To: linux-kbuild, Masahiro Yamada; +Cc: Linux Kernel Mailing List, Alyssa Ross
If ncurses is installed, but at a non-default location, the previous
error message was not helpful in resolving the situation. Now it will
suggest that pkg-config might need to be installed in addition to
ncurses.
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
scripts/kconfig/mconf-cfg.sh | 3 +++
scripts/kconfig/nconf-cfg.sh | 14 ++++++++++++--
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/scripts/kconfig/mconf-cfg.sh b/scripts/kconfig/mconf-cfg.sh
index c812872d7f9d..aa68ec95620d 100755
--- a/scripts/kconfig/mconf-cfg.sh
+++ b/scripts/kconfig/mconf-cfg.sh
@@ -44,4 +44,7 @@ echo >&2 "* Unable to find the ncurses package."
echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
echo >&2 "* depending on your distribution)."
echo >&2 "*"
+echo >&2 "* You may also need to install pkg-config to find the"
+echo >&2 "* ncurses installed in a non-default location."
+echo >&2 "*"
exit 1
diff --git a/scripts/kconfig/nconf-cfg.sh b/scripts/kconfig/nconf-cfg.sh
index 001559ef0a60..569226f1b497 100755
--- a/scripts/kconfig/nconf-cfg.sh
+++ b/scripts/kconfig/nconf-cfg.sh
@@ -41,7 +41,17 @@ fi
echo >&2 "*"
echo >&2 "* Unable to find the ncurses package."
-echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
-echo >&2 "* depending on your distribution)."
+echo >&2 "*"
+if [ -n "$(command -v pkg-config)" ]; then
+ echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
+ echo >&2 "* depending on your distribution)."
+else
+ echo >&2 "* You may need to install ncurses"
+ echo >&2 "* (ncurses-devel or libncurses-dev"
+ echo >&2 "* depending on your distribution)."
+ echo >&2 "*"
+ echo >&2 "* If you have ncurses installed,"
+ echo >&2 "* you may also need to install pkg-config."
+fi
echo >&2 "*"
exit 1
--
2.23.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3] kconfig: be more helpful if pkg-config is missing
2019-11-05 15:04 ` [PATCH v2] " Alyssa Ross
@ 2019-11-05 15:07 ` Alyssa Ross
2019-11-06 2:17 ` Masahiro Yamada
0 siblings, 1 reply; 5+ messages in thread
From: Alyssa Ross @ 2019-11-05 15:07 UTC (permalink / raw)
To: linux-kbuild, Masahiro Yamada; +Cc: Linux Kernel Mailing List, Alyssa Ross
If ncurses is installed, but at a non-default location, the previous
error message was not helpful in resolving the situation. Now it will
suggest that pkg-config might need to be installed in addition to
ncurses.
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
Apologies -- was a little too hasty in sending v2, and it only
included the updated message in one of the two files that needed to be
changed.
scripts/kconfig/mconf-cfg.sh | 3 +++
scripts/kconfig/nconf-cfg.sh | 3 +++
2 files changed, 6 insertions(+)
diff --git a/scripts/kconfig/mconf-cfg.sh b/scripts/kconfig/mconf-cfg.sh
index c812872d7f9d..aa68ec95620d 100755
--- a/scripts/kconfig/mconf-cfg.sh
+++ b/scripts/kconfig/mconf-cfg.sh
@@ -44,4 +44,7 @@ echo >&2 "* Unable to find the ncurses package."
echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
echo >&2 "* depending on your distribution)."
echo >&2 "*"
+echo >&2 "* You may also need to install pkg-config to find the"
+echo >&2 "* ncurses installed in a non-default location."
+echo >&2 "*"
exit 1
diff --git a/scripts/kconfig/nconf-cfg.sh b/scripts/kconfig/nconf-cfg.sh
index 001559ef0a60..c212255070c0 100755
--- a/scripts/kconfig/nconf-cfg.sh
+++ b/scripts/kconfig/nconf-cfg.sh
@@ -44,4 +44,7 @@ echo >&2 "* Unable to find the ncurses package."
echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
echo >&2 "* depending on your distribution)."
echo >&2 "*"
+echo >&2 "* You may also need to install pkg-config to find the"
+echo >&2 "* ncurses installed in a non-default location."
+echo >&2 "*"
exit 1
--
2.23.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] kconfig: be more helpful if pkg-config is missing
2019-11-05 15:07 ` [PATCH v3] " Alyssa Ross
@ 2019-11-06 2:17 ` Masahiro Yamada
0 siblings, 0 replies; 5+ messages in thread
From: Masahiro Yamada @ 2019-11-06 2:17 UTC (permalink / raw)
To: Alyssa Ross; +Cc: Linux Kbuild mailing list, Linux Kernel Mailing List
On Wed, Nov 6, 2019 at 12:08 AM Alyssa Ross <hi@alyssa.is> wrote:
>
> If ncurses is installed, but at a non-default location, the previous
> error message was not helpful in resolving the situation. Now it will
> suggest that pkg-config might need to be installed in addition to
> ncurses.
>
> Signed-off-by: Alyssa Ross <hi@alyssa.is>
Applied to linux-kbuild.
Thanks.
> ---
> Apologies -- was a little too hasty in sending v2, and it only
> included the updated message in one of the two files that needed to be
> changed.
>
> scripts/kconfig/mconf-cfg.sh | 3 +++
> scripts/kconfig/nconf-cfg.sh | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/scripts/kconfig/mconf-cfg.sh b/scripts/kconfig/mconf-cfg.sh
> index c812872d7f9d..aa68ec95620d 100755
> --- a/scripts/kconfig/mconf-cfg.sh
> +++ b/scripts/kconfig/mconf-cfg.sh
> @@ -44,4 +44,7 @@ echo >&2 "* Unable to find the ncurses package."
> echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
> echo >&2 "* depending on your distribution)."
> echo >&2 "*"
> +echo >&2 "* You may also need to install pkg-config to find the"
> +echo >&2 "* ncurses installed in a non-default location."
> +echo >&2 "*"
> exit 1
> diff --git a/scripts/kconfig/nconf-cfg.sh b/scripts/kconfig/nconf-cfg.sh
> index 001559ef0a60..c212255070c0 100755
> --- a/scripts/kconfig/nconf-cfg.sh
> +++ b/scripts/kconfig/nconf-cfg.sh
> @@ -44,4 +44,7 @@ echo >&2 "* Unable to find the ncurses package."
> echo >&2 "* Install ncurses (ncurses-devel or libncurses-dev"
> echo >&2 "* depending on your distribution)."
> echo >&2 "*"
> +echo >&2 "* You may also need to install pkg-config to find the"
> +echo >&2 "* ncurses installed in a non-default location."
> +echo >&2 "*"
> exit 1
> --
> 2.23.0
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-06 2:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04 20:44 [PATCH] kconfig: be more helpful if pkg-config is missing Alyssa Ross
2019-11-05 4:28 ` Masahiro Yamada
2019-11-05 15:04 ` [PATCH v2] " Alyssa Ross
2019-11-05 15:07 ` [PATCH v3] " Alyssa Ross
2019-11-06 2:17 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).