linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] builddeb: Pass the kernel:debarch substvar to dpkg-genchanges
@ 2017-11-09 18:27 Sven Joachim
  2017-11-13 15:25 ` Masahiro Yamada
  0 siblings, 1 reply; 2+ messages in thread
From: Sven Joachim @ 2017-11-09 18:27 UTC (permalink / raw)
  To: linux-kbuild; +Cc: Masahiro Yamada, Michal Marek, linux-kernel

At the end of "make bindeb-pkg" I noticed the following warning:

dpkg-genchanges: warning: unknown substitution variable ${kernel:debarch}

It turns out that since dpkg version 1.19.0 dpkg-genchanges honors
substitution variables in the Description field, while earlier
versions silently left them alone, see https://bugs.debian.org/856547.

The result is an incomplete description of the linux-headers package
in the generated .changes file.  Fix it by passing the kernel:debarch
substitution variable to dpkg-genchanges.

Signed-off-by: Sven Joachim <svenjoac@gmx.de>
---
 scripts/package/builddeb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index 0bc87473f68f..b4f0f2b3f8d2 100755
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -408,9 +408,9 @@ EOF
 	dpkg-source -cdebian/control -ldebian/changelog --format="3.0 (custom)" --target-format="3.0 (quilt)" \
 		-b / ../${sourcename}_${version}.orig.tar.gz  ../${sourcename}_${packageversion}.debian.tar.gz
 	mv ${sourcename}_${packageversion}*dsc ..
-	dpkg-genchanges > ../${sourcename}_${packageversion}_${debarch}.changes
+	dpkg-genchanges -Vkernel:debarch="${debarch}" > ../${sourcename}_${packageversion}_${debarch}.changes
 else
-	dpkg-genchanges -b > ../${sourcename}_${packageversion}_${debarch}.changes
+	dpkg-genchanges -b -Vkernel:debarch="${debarch}" > ../${sourcename}_${packageversion}_${debarch}.changes
 fi
 
 exit 0
-- 
2.15.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] builddeb: Pass the kernel:debarch substvar to dpkg-genchanges
  2017-11-09 18:27 [PATCH] builddeb: Pass the kernel:debarch substvar to dpkg-genchanges Sven Joachim
@ 2017-11-13 15:25 ` Masahiro Yamada
  0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2017-11-13 15:25 UTC (permalink / raw)
  To: Sven Joachim
  Cc: Linux Kbuild mailing list, Michal Marek, Linux Kernel Mailing List

2017-11-10 3:27 GMT+09:00 Sven Joachim <svenjoac@gmx.de>:
> At the end of "make bindeb-pkg" I noticed the following warning:
>
> dpkg-genchanges: warning: unknown substitution variable ${kernel:debarch}
>
> It turns out that since dpkg version 1.19.0 dpkg-genchanges honors
> substitution variables in the Description field, while earlier
> versions silently left them alone, see https://bugs.debian.org/856547.
>
> The result is an incomplete description of the linux-headers package
> in the generated .changes file.  Fix it by passing the kernel:debarch
> substitution variable to dpkg-genchanges.
>
> Signed-off-by: Sven Joachim <svenjoac@gmx.de>
> ---

Applied to linux-kbuild/misc.  Thanks!




-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-11-13 15:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-09 18:27 [PATCH] builddeb: Pass the kernel:debarch substvar to dpkg-genchanges Sven Joachim
2017-11-13 15:25 ` Masahiro Yamada

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).