linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scsi: ch: add include guard to chio.h
@ 2019-07-28 16:46 Masahiro Yamada
  2019-10-03  2:30 ` Masahiro Yamada
  0 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2019-07-28 16:46 UTC (permalink / raw)
  To: James E . J . Bottomley, Martin K . Petersen, linux-scsi
  Cc: Masahiro Yamada, linux-kernel

Add a header include guard just in case.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 include/uapi/linux/chio.h | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/include/uapi/linux/chio.h b/include/uapi/linux/chio.h
index 689fc93fafda..e1cad4c319ee 100644
--- a/include/uapi/linux/chio.h
+++ b/include/uapi/linux/chio.h
@@ -3,6 +3,9 @@
  * ioctl interface for the scsi media changer driver
  */
 
+#ifndef _UAPI_LINUX_CHIO_H
+#define _UAPI_LINUX_CHIO_H
+
 /* changer element types */
 #define CHET_MT   0	/* media transport element (robot) */
 #define CHET_ST   1	/* storage element (media slots) */
@@ -160,10 +163,4 @@ struct changer_set_voltag {
 #define CHIOSVOLTAG    _IOW('c',18,struct changer_set_voltag)
 #define CHIOGVPARAMS   _IOR('c',19,struct changer_vendor_params)
 
-/* ---------------------------------------------------------------------- */
-
-/*
- * Local variables:
- * c-basic-offset: 8
- * End:
- */
+#endif /* _UAPI_LINUX_CHIO_H */
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] scsi: ch: add include guard to chio.h
  2019-07-28 16:46 [PATCH] scsi: ch: add include guard to chio.h Masahiro Yamada
@ 2019-10-03  2:30 ` Masahiro Yamada
  2019-10-04  1:59   ` Martin K. Petersen
  0 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2019-10-03  2:30 UTC (permalink / raw)
  To: James E . J . Bottomley, Martin K . Petersen, linux-scsi
  Cc: Linux Kernel Mailing List

Hi,

On Mon, Jul 29, 2019 at 1:47 AM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> Add a header include guard just in case.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---

Ping?


>  include/uapi/linux/chio.h | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/include/uapi/linux/chio.h b/include/uapi/linux/chio.h
> index 689fc93fafda..e1cad4c319ee 100644
> --- a/include/uapi/linux/chio.h
> +++ b/include/uapi/linux/chio.h
> @@ -3,6 +3,9 @@
>   * ioctl interface for the scsi media changer driver
>   */
>
> +#ifndef _UAPI_LINUX_CHIO_H
> +#define _UAPI_LINUX_CHIO_H
> +
>  /* changer element types */
>  #define CHET_MT   0    /* media transport element (robot) */
>  #define CHET_ST   1    /* storage element (media slots) */
> @@ -160,10 +163,4 @@ struct changer_set_voltag {
>  #define CHIOSVOLTAG    _IOW('c',18,struct changer_set_voltag)
>  #define CHIOGVPARAMS   _IOR('c',19,struct changer_vendor_params)
>
> -/* ---------------------------------------------------------------------- */
> -
> -/*
> - * Local variables:
> - * c-basic-offset: 8
> - * End:
> - */
> +#endif /* _UAPI_LINUX_CHIO_H */
> --
> 2.17.1
>


-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] scsi: ch: add include guard to chio.h
  2019-10-03  2:30 ` Masahiro Yamada
@ 2019-10-04  1:59   ` Martin K. Petersen
  2019-10-04  2:20     ` Masahiro Yamada
  0 siblings, 1 reply; 5+ messages in thread
From: Martin K. Petersen @ 2019-10-04  1:59 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: James E . J . Bottomley, Martin K . Petersen, linux-scsi,
	Linux Kernel Mailing List


Masahiro,

>> Add a header include guard just in case.

Fine with me. Is it going through your tree or should I pick it up?

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] scsi: ch: add include guard to chio.h
  2019-10-04  1:59   ` Martin K. Petersen
@ 2019-10-04  2:20     ` Masahiro Yamada
  2019-10-10  2:31       ` Martin K. Petersen
  0 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2019-10-04  2:20 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: James E . J . Bottomley, linux-scsi, Linux Kernel Mailing List

Hi Martin,

On Fri, Oct 4, 2019 at 10:59 AM Martin K. Petersen
<martin.petersen@oracle.com> wrote:
>
>
> Masahiro,
>
> >> Add a header include guard just in case.
>
> Fine with me. Is it going through your tree or should I pick it up?



Could you please apply it to your tree?

Thanks.

-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] scsi: ch: add include guard to chio.h
  2019-10-04  2:20     ` Masahiro Yamada
@ 2019-10-10  2:31       ` Martin K. Petersen
  0 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2019-10-10  2:31 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Martin K. Petersen, James E . J . Bottomley, linux-scsi,
	Linux Kernel Mailing List


Masahiro,

>> Fine with me. Is it going through your tree or should I pick it up?
>
> Could you please apply it to your tree?

Applied to 5.5/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-10-10  2:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-28 16:46 [PATCH] scsi: ch: add include guard to chio.h Masahiro Yamada
2019-10-03  2:30 ` Masahiro Yamada
2019-10-04  1:59   ` Martin K. Petersen
2019-10-04  2:20     ` Masahiro Yamada
2019-10-10  2:31       ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).