* [PATCH v4] blackfin: bf609: let clk_disable() return immediately if clk is NULL
@ 2016-09-18 18:03 Masahiro Yamada
2016-11-05 15:47 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2016-09-18 18:03 UTC (permalink / raw)
To: Steven Miao, adi-buildroot-devel
Cc: Stephen Boyd, Ralf Baechle, Michael Turquette, Masahiro Yamada,
linux-kernel
In many of clk_disable() implementations, it is a no-op for a NULL
pointer input, but this is one of the exceptions.
Making it treewide consistent will allow clock consumers to call
clk_disable() without NULL pointer check.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Changes in v4:
- Split into per-arch patches
Changes in v3:
- Return only when clk is NULL. Do not take care of error pointer.
Changes in v2:
- Rebase on Linux 4.6-rc1
arch/blackfin/mach-bf609/clock.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/blackfin/mach-bf609/clock.c b/arch/blackfin/mach-bf609/clock.c
index 3783058..392a59b 100644
--- a/arch/blackfin/mach-bf609/clock.c
+++ b/arch/blackfin/mach-bf609/clock.c
@@ -97,6 +97,9 @@ EXPORT_SYMBOL(clk_enable);
void clk_disable(struct clk *clk)
{
+ if (!clk)
+ return;
+
if (clk->ops && clk->ops->disable)
clk->ops->disable(clk);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4] blackfin: bf609: let clk_disable() return immediately if clk is NULL
2016-09-18 18:03 [PATCH v4] blackfin: bf609: let clk_disable() return immediately if clk is NULL Masahiro Yamada
@ 2016-11-05 15:47 ` Masahiro Yamada
2017-01-28 13:35 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2016-11-05 15:47 UTC (permalink / raw)
To: Steven Miao, adi-buildroot-devel
Cc: Stephen Boyd, Ralf Baechle, Michael Turquette, Masahiro Yamada,
Linux Kernel Mailing List
Hi Steven,
Could you take a look at this patch, please?
2016-09-19 3:03 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> In many of clk_disable() implementations, it is a no-op for a NULL
> pointer input, but this is one of the exceptions.
>
> Making it treewide consistent will allow clock consumers to call
> clk_disable() without NULL pointer check.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Changes in v4:
> - Split into per-arch patches
>
> Changes in v3:
> - Return only when clk is NULL. Do not take care of error pointer.
>
> Changes in v2:
> - Rebase on Linux 4.6-rc1
>
> arch/blackfin/mach-bf609/clock.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/blackfin/mach-bf609/clock.c b/arch/blackfin/mach-bf609/clock.c
> index 3783058..392a59b 100644
> --- a/arch/blackfin/mach-bf609/clock.c
> +++ b/arch/blackfin/mach-bf609/clock.c
> @@ -97,6 +97,9 @@ EXPORT_SYMBOL(clk_enable);
>
> void clk_disable(struct clk *clk)
> {
> + if (!clk)
> + return;
> +
> if (clk->ops && clk->ops->disable)
> clk->ops->disable(clk);
> }
> --
> 1.9.1
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4] blackfin: bf609: let clk_disable() return immediately if clk is NULL
2016-11-05 15:47 ` Masahiro Yamada
@ 2017-01-28 13:35 ` Masahiro Yamada
0 siblings, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2017-01-28 13:35 UTC (permalink / raw)
To: Steven Miao, adi-buildroot-devel
Cc: Stephen Boyd, Ralf Baechle, Michael Turquette, Masahiro Yamada,
Linux Kernel Mailing List
Hi Steven,
Ping again.
Could you apply this, please?
2016-11-06 0:47 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> Hi Steven,
>
> Could you take a look at this patch, please?
>
>
> 2016-09-19 3:03 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
>> In many of clk_disable() implementations, it is a no-op for a NULL
>> pointer input, but this is one of the exceptions.
>>
>> Making it treewide consistent will allow clock consumers to call
>> clk_disable() without NULL pointer check.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>> Changes in v4:
>> - Split into per-arch patches
>>
>> Changes in v3:
>> - Return only when clk is NULL. Do not take care of error pointer.
>>
>> Changes in v2:
>> - Rebase on Linux 4.6-rc1
>>
>> arch/blackfin/mach-bf609/clock.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/blackfin/mach-bf609/clock.c b/arch/blackfin/mach-bf609/clock.c
>> index 3783058..392a59b 100644
>> --- a/arch/blackfin/mach-bf609/clock.c
>> +++ b/arch/blackfin/mach-bf609/clock.c
>> @@ -97,6 +97,9 @@ EXPORT_SYMBOL(clk_enable);
>>
>> void clk_disable(struct clk *clk)
>> {
>> + if (!clk)
>> + return;
>> +
>> if (clk->ops && clk->ops->disable)
>> clk->ops->disable(clk);
>> }
>> --
>> 1.9.1
>>
>
>
>
> --
> Best Regards
> Masahiro Yamada
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-28 13:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-18 18:03 [PATCH v4] blackfin: bf609: let clk_disable() return immediately if clk is NULL Masahiro Yamada
2016-11-05 15:47 ` Masahiro Yamada
2017-01-28 13:35 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).