linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: build warnings after merge of the crypto tree
@ 2019-08-01  1:53 Stephen Rothwell
  2019-08-01  2:11 ` [PATCH] asm-generic: Remove redundant arch-specific rules for simd.h Herbert Xu
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2019-08-01  1:53 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Ard Biesheuvel

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

scripts/Makefile.asm-generic:25: redundant generic-y found in arch/arm/include/asm/Kbuild: simd.h

Introduced by commit

  82cb54856874 ("asm-generic: make simd.h a mandatory include/asm header")

Also the powerpc ppc64_defconfig build produced this warning:

scripts/Makefile.asm-generic:25: redundant generic-y found in arch/powerpc/include/asm/Kbuild: simd.h

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] asm-generic: Remove redundant arch-specific rules for simd.h
  2019-08-01  1:53 linux-next: build warnings after merge of the crypto tree Stephen Rothwell
@ 2019-08-01  2:11 ` Herbert Xu
  2019-08-01  7:16   ` Ard Biesheuvel
  2019-08-01  7:23   ` Arnd Bergmann
  0 siblings, 2 replies; 4+ messages in thread
From: Herbert Xu @ 2019-08-01  2:11 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Ard Biesheuvel, Linux Crypto Mailing List, Arnd Bergmann

On Thu, Aug 01, 2019 at 11:53:46AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the crypto tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> scripts/Makefile.asm-generic:25: redundant generic-y found in arch/arm/include/asm/Kbuild: simd.h
> 
> Introduced by commit
> 
>   82cb54856874 ("asm-generic: make simd.h a mandatory include/asm header")
> 
> Also the powerpc ppc64_defconfig build produced this warning:
> 
> scripts/Makefile.asm-generic:25: redundant generic-y found in arch/powerpc/include/asm/Kbuild: simd.h

Thanks for the heads up Stephen.  This patch should fix the
warnings.

---8<---
Now that simd.h is in include/asm-generic/Kbuild we don't need
the arch-specific Kbuild rules for them.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 82cb54856874 ("asm-generic: make simd.h a mandatory...")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/arch/arm/include/asm/Kbuild b/arch/arm/include/asm/Kbuild
index 6b2dc15..68ca86f 100644
--- a/arch/arm/include/asm/Kbuild
+++ b/arch/arm/include/asm/Kbuild
@@ -17,7 +17,6 @@ generic-y += parport.h
 generic-y += preempt.h
 generic-y += seccomp.h
 generic-y += serial.h
-generic-y += simd.h
 generic-y += trace_clock.h
 
 generated-y += mach-types.h
diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild
index 9a1d2fc..64870c7 100644
--- a/arch/powerpc/include/asm/Kbuild
+++ b/arch/powerpc/include/asm/Kbuild
@@ -11,4 +11,3 @@ generic-y += mcs_spinlock.h
 generic-y += preempt.h
 generic-y += vtime.h
 generic-y += msi.h
-generic-y += simd.h
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] asm-generic: Remove redundant arch-specific rules for simd.h
  2019-08-01  2:11 ` [PATCH] asm-generic: Remove redundant arch-specific rules for simd.h Herbert Xu
@ 2019-08-01  7:16   ` Ard Biesheuvel
  2019-08-01  7:23   ` Arnd Bergmann
  1 sibling, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2019-08-01  7:16 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, Linux Crypto Mailing List,
	Arnd Bergmann

On Thu, 1 Aug 2019 at 05:11, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Thu, Aug 01, 2019 at 11:53:46AM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the crypto tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > scripts/Makefile.asm-generic:25: redundant generic-y found in arch/arm/include/asm/Kbuild: simd.h
> >
> > Introduced by commit
> >
> >   82cb54856874 ("asm-generic: make simd.h a mandatory include/asm header")
> >
> > Also the powerpc ppc64_defconfig build produced this warning:
> >
> > scripts/Makefile.asm-generic:25: redundant generic-y found in arch/powerpc/include/asm/Kbuild: simd.h
>
> Thanks for the heads up Stephen.  This patch should fix the
> warnings.
>
> ---8<---
> Now that simd.h is in include/asm-generic/Kbuild we don't need
> the arch-specific Kbuild rules for them.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: 82cb54856874 ("asm-generic: make simd.h a mandatory...")
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> diff --git a/arch/arm/include/asm/Kbuild b/arch/arm/include/asm/Kbuild
> index 6b2dc15..68ca86f 100644
> --- a/arch/arm/include/asm/Kbuild
> +++ b/arch/arm/include/asm/Kbuild
> @@ -17,7 +17,6 @@ generic-y += parport.h
>  generic-y += preempt.h
>  generic-y += seccomp.h
>  generic-y += serial.h
> -generic-y += simd.h
>  generic-y += trace_clock.h
>
>  generated-y += mach-types.h
> diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild
> index 9a1d2fc..64870c7 100644
> --- a/arch/powerpc/include/asm/Kbuild
> +++ b/arch/powerpc/include/asm/Kbuild
> @@ -11,4 +11,3 @@ generic-y += mcs_spinlock.h
>  generic-y += preempt.h
>  generic-y += vtime.h
>  generic-y += msi.h
> -generic-y += simd.h

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] asm-generic: Remove redundant arch-specific rules for simd.h
  2019-08-01  2:11 ` [PATCH] asm-generic: Remove redundant arch-specific rules for simd.h Herbert Xu
  2019-08-01  7:16   ` Ard Biesheuvel
@ 2019-08-01  7:23   ` Arnd Bergmann
  1 sibling, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2019-08-01  7:23 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, Ard Biesheuvel,
	Linux Crypto Mailing List

On Thu, Aug 1, 2019 at 4:11 AM Herbert Xu <herbert@gondor.apana.org.au> wrote:

> Now that simd.h is in include/asm-generic/Kbuild we don't need
> the arch-specific Kbuild rules for them.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: 82cb54856874 ("asm-generic: make simd.h a mandatory...")
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Acked-by: Arnd Bergmann <arnd@arndb.de>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-08-01  7:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-01  1:53 linux-next: build warnings after merge of the crypto tree Stephen Rothwell
2019-08-01  2:11 ` [PATCH] asm-generic: Remove redundant arch-specific rules for simd.h Herbert Xu
2019-08-01  7:16   ` Ard Biesheuvel
2019-08-01  7:23   ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).