* [net-next PATCH] net: ethernet: stmmac: remove select QCOM_SOCINFO and make it optional
@ 2022-06-16 22:15 Christian Marangi
2022-06-19 9:00 ` patchwork-bot+netdevbpf
2022-06-19 9:49 ` Arnd Bergmann
0 siblings, 2 replies; 3+ messages in thread
From: Christian Marangi @ 2022-06-16 22:15 UTC (permalink / raw)
To: Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Maxime Coquelin, Christian 'Ansuel' Marangi, netdev,
linux-stm32, linux-arm-kernel, linux-kernel
Cc: kernel test robot
QCOM_SOCINFO depends on QCOM_SMEM but is not selected, this cause some
problems with QCOM_SOCINFO getting selected with the dependency of
QCOM_SMEM not met.
To fix this remove the select in Kconfig and add additional info in the
DWMAC_IPQ806X config description.
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 9ec092d2feb6 ("net: ethernet: stmmac: add missing sgmii configure for ipq806x")
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
index c4bca16dae57..31ff35174034 100644
--- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
+++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
@@ -83,7 +83,6 @@ config DWMAC_IPQ806X
default ARCH_QCOM
depends on OF && (ARCH_QCOM || COMPILE_TEST)
select MFD_SYSCON
- select QCOM_SOCINFO
help
Support for QCA IPQ806X DWMAC Ethernet.
@@ -92,6 +91,9 @@ config DWMAC_IPQ806X
acceleration features available on this SoC. Network devices
will behave like standard non-accelerated ethernet interfaces.
+ Select the QCOM_SOCINFO config flag to enable specific dwmac
+ fixup based on the ipq806x SoC revision.
+
config DWMAC_LPC18XX
tristate "NXP LPC18xx/43xx DWMAC support"
default ARCH_LPC18XX
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net-next PATCH] net: ethernet: stmmac: remove select QCOM_SOCINFO and make it optional
2022-06-16 22:15 [net-next PATCH] net: ethernet: stmmac: remove select QCOM_SOCINFO and make it optional Christian Marangi
@ 2022-06-19 9:00 ` patchwork-bot+netdevbpf
2022-06-19 9:49 ` Arnd Bergmann
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-06-19 9:00 UTC (permalink / raw)
To: Christian Marangi
Cc: peppe.cavallaro, alexandre.torgue, joabreu, davem, edumazet,
kuba, pabeni, mcoquelin.stm32, netdev, linux-stm32,
linux-arm-kernel, linux-kernel, lkp
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 17 Jun 2022 00:15:54 +0200 you wrote:
> QCOM_SOCINFO depends on QCOM_SMEM but is not selected, this cause some
> problems with QCOM_SOCINFO getting selected with the dependency of
> QCOM_SMEM not met.
> To fix this remove the select in Kconfig and add additional info in the
> DWMAC_IPQ806X config description.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 9ec092d2feb6 ("net: ethernet: stmmac: add missing sgmii configure for ipq806x")
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
>
> [...]
Here is the summary with links:
- [net-next] net: ethernet: stmmac: remove select QCOM_SOCINFO and make it optional
https://git.kernel.org/netdev/net-next/c/c205035e3adb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net-next PATCH] net: ethernet: stmmac: remove select QCOM_SOCINFO and make it optional
2022-06-16 22:15 [net-next PATCH] net: ethernet: stmmac: remove select QCOM_SOCINFO and make it optional Christian Marangi
2022-06-19 9:00 ` patchwork-bot+netdevbpf
@ 2022-06-19 9:49 ` Arnd Bergmann
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2022-06-19 9:49 UTC (permalink / raw)
To: Christian Marangi
Cc: Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Maxime Coquelin, Networking, linux-stm32, Linux ARM,
Linux Kernel Mailing List, kernel test robot
On Fri, Jun 17, 2022 at 12:15 AM Christian Marangi <ansuelsmth@gmail.com> wrote:
>
> QCOM_SOCINFO depends on QCOM_SMEM but is not selected, this cause some
> problems with QCOM_SOCINFO getting selected with the dependency of
> QCOM_SMEM not met.
> To fix this remove the select in Kconfig and add additional info in the
> DWMAC_IPQ806X config description.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 9ec092d2feb6 ("net: ethernet: stmmac: add missing sgmii configure for ipq806x")
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> index c4bca16dae57..31ff35174034 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
> +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> @@ -83,7 +83,6 @@ config DWMAC_IPQ806X
> default ARCH_QCOM
> depends on OF && (ARCH_QCOM || COMPILE_TEST)
> select MFD_SYSCON
> - select QCOM_SOCINFO
> help
> Support for QCA IPQ806X DWMAC Ethernet.
>
> @@ -92,6 +91,9 @@ config DWMAC_IPQ806X
> acceleration features available on this SoC. Network devices
> will behave like standard non-accelerated ethernet interfaces.
>
> + Select the QCOM_SOCINFO config flag to enable specific dwmac
> + fixup based on the ipq806x SoC revision.
I think the correct way would have been to use
depends on QCOM_SOCINFO || COMPILE_TEST
here.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-19 9:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-16 22:15 [net-next PATCH] net: ethernet: stmmac: remove select QCOM_SOCINFO and make it optional Christian Marangi
2022-06-19 9:00 ` patchwork-bot+netdevbpf
2022-06-19 9:49 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).