* [PATCH] i2c: acorn: add MODULE_LICENSE tag
@ 2018-01-11 10:37 Arnd Bergmann
2018-01-15 17:10 ` Wolfram Sang
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2018-01-11 10:37 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Arnd Bergmann, linux-i2c, linux-kernel
As of v4.15, Kbuild warns about missing MODULE_LICENSE tags:
WARNING: modpost: missing MODULE_LICENSE() in drivers/i2c/busses/i2c-acorn.o
This adds a license, author and description tag, matching the
comment at the start of the acorn i2c driver.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/i2c/busses/i2c-acorn.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/i2c/busses/i2c-acorn.c b/drivers/i2c/busses/i2c-acorn.c
index 9d7be5af2bf2..6463189ca183 100644
--- a/drivers/i2c/busses/i2c-acorn.c
+++ b/drivers/i2c/busses/i2c-acorn.c
@@ -94,3 +94,7 @@ static int __init i2c_ioc_init(void)
}
module_init(i2c_ioc_init);
+
+MODULE_AUTHOR("Russell King <rmk@arm.linux.org.uk>");
+MODULE_DESCRIPTION("ARM IOC/IOMD i2c driver");
+MODULE_LICENSE("GPL v2");
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] i2c: acorn: add MODULE_LICENSE tag
2018-01-11 10:37 [PATCH] i2c: acorn: add MODULE_LICENSE tag Arnd Bergmann
@ 2018-01-15 17:10 ` Wolfram Sang
2018-01-15 17:19 ` Russell King
0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2018-01-15 17:10 UTC (permalink / raw)
To: Arnd Bergmann, Russell King; +Cc: linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
On Thu, Jan 11, 2018 at 11:37:45AM +0100, Arnd Bergmann wrote:
> As of v4.15, Kbuild warns about missing MODULE_LICENSE tags:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/i2c/busses/i2c-acorn.o
>
> This adds a license, author and description tag, matching the
> comment at the start of the acorn i2c driver.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looks good, but since rmk is still around, let's add him to CC...
> ---
> drivers/i2c/busses/i2c-acorn.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-acorn.c b/drivers/i2c/busses/i2c-acorn.c
> index 9d7be5af2bf2..6463189ca183 100644
> --- a/drivers/i2c/busses/i2c-acorn.c
> +++ b/drivers/i2c/busses/i2c-acorn.c
> @@ -94,3 +94,7 @@ static int __init i2c_ioc_init(void)
> }
>
> module_init(i2c_ioc_init);
> +
> +MODULE_AUTHOR("Russell King <rmk@arm.linux.org.uk>");
> +MODULE_DESCRIPTION("ARM IOC/IOMD i2c driver");
> +MODULE_LICENSE("GPL v2");
> --
> 2.9.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] i2c: acorn: add MODULE_LICENSE tag
2018-01-15 17:10 ` Wolfram Sang
@ 2018-01-15 17:19 ` Russell King
2018-01-15 20:31 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Russell King @ 2018-01-15 17:19 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Arnd Bergmann, linux-i2c, linux-kernel
On Mon, Jan 15, 2018 at 06:10:28PM +0100, Wolfram Sang wrote:
> On Thu, Jan 11, 2018 at 11:37:45AM +0100, Arnd Bergmann wrote:
> > As of v4.15, Kbuild warns about missing MODULE_LICENSE tags:
> >
> > WARNING: modpost: missing MODULE_LICENSE() in drivers/i2c/busses/i2c-acorn.o
> >
> > This adds a license, author and description tag, matching the
> > comment at the start of the acorn i2c driver.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Looks good, but since rmk is still around, let's add him to CC...
>
> > ---
> > drivers/i2c/busses/i2c-acorn.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/i2c/busses/i2c-acorn.c b/drivers/i2c/busses/i2c-acorn.c
> > index 9d7be5af2bf2..6463189ca183 100644
> > --- a/drivers/i2c/busses/i2c-acorn.c
> > +++ b/drivers/i2c/busses/i2c-acorn.c
> > @@ -94,3 +94,7 @@ static int __init i2c_ioc_init(void)
> > }
> >
> > module_init(i2c_ioc_init);
> > +
> > +MODULE_AUTHOR("Russell King <rmk@arm.linux.org.uk>");
linux@armlinux.org.uk please - dspam on _this_ account files such mails
into the spam mailbox.
Thanks.
> > +MODULE_DESCRIPTION("ARM IOC/IOMD i2c driver");
> > +MODULE_LICENSE("GPL v2");
> > --
> > 2.9.0
> >
--
Russell King
ARM architecture Linux Kernel maintainer
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] i2c: acorn: add MODULE_LICENSE tag
2018-01-15 17:19 ` Russell King
@ 2018-01-15 20:31 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2018-01-15 20:31 UTC (permalink / raw)
To: Russell King; +Cc: Wolfram Sang, linux-i2c, Linux Kernel Mailing List
On Mon, Jan 15, 2018 at 6:19 PM, Russell King <linux@armlinux.org.uk> wrote:
> On Mon, Jan 15, 2018 at 06:10:28PM +0100, Wolfram Sang wrote:
>> On Thu, Jan 11, 2018 at 11:37:45AM +0100, Arnd Bergmann wrote:
>> > As of v4.15, Kbuild warns about missing MODULE_LICENSE tags:
>> >
>> > WARNING: modpost: missing MODULE_LICENSE() in drivers/i2c/busses/i2c-acorn.o
>> >
>> > This adds a license, author and description tag, matching the
>> > comment at the start of the acorn i2c driver.
>> >
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Looks good, but since rmk is still around, let's add him to CC...
Oops, I just went with the default from scripts/get_maintainer.pl and
forgot to ensure the author was listed there.
>> > drivers/i2c/busses/i2c-acorn.c | 4 ++++
>> > 1 file changed, 4 insertions(+)
>> >
>> > diff --git a/drivers/i2c/busses/i2c-acorn.c b/drivers/i2c/busses/i2c-acorn.c
>> > index 9d7be5af2bf2..6463189ca183 100644
>> > --- a/drivers/i2c/busses/i2c-acorn.c
>> > +++ b/drivers/i2c/busses/i2c-acorn.c
>> > @@ -94,3 +94,7 @@ static int __init i2c_ioc_init(void)
>> > }
>> >
>> > module_init(i2c_ioc_init);
>> > +
>> > +MODULE_AUTHOR("Russell King <rmk@arm.linux.org.uk>");
>
> linux@armlinux.org.uk please - dspam on _this_ account files such mails
> into the spam mailbox.
Ok, resent now. I think what I did there was to check which address you
use most commonly in the other MODULE_AUTHOR entries.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-15 20:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-11 10:37 [PATCH] i2c: acorn: add MODULE_LICENSE tag Arnd Bergmann
2018-01-15 17:10 ` Wolfram Sang
2018-01-15 17:19 ` Russell King
2018-01-15 20:31 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).