From: Arnd Bergmann <arnd@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Jason Wang" <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Jean-Philippe Brucker" <jean-philippe@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Bill Mills" <bill.mills@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Enrico Weigelt, metux IT consult" <info@metux.net>,
"Jie Deng" <jie.deng@intel.com>,
DTML <devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE"
<virtualization@lists.linux-foundation.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH V3 3/5] dt-bindings: gpio: Add bindings for gpio-virtio
Date: Mon, 26 Jul 2021 10:13:45 +0200 [thread overview]
Message-ID: <CAK8P3a1ze7+z=KQVtYZeGuA3Sjw=wWb44bjsbPpTaw_8m8U5ww@mail.gmail.com> (raw)
In-Reply-To: <605b87ce93b9a528810a5857984bfe6b913d5e73.1627273794.git.viresh.kumar@linaro.org>
On Mon, Jul 26, 2021 at 6:53 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> This patch adds binding for virtio GPIO controller, it is based on
> virtio-device bindings.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>, except
> +
> +properties:
> + $nodename:
> + pattern: '^gpio-virtio(-[a-z0-9]+)?$'
> +
> + gpio: gpio-virtio {
> + compatible = "virtio,29";
The node name here does not appear to be mandated by the schema, but
most others name it "gpio", so I would do the same here instead of
"gpio-virtio".
Arnd
next prev parent reply other threads:[~2021-07-26 8:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 4:51 [PATCH V3 0/5] virtio: Add virtio-device bindings Viresh Kumar
2021-07-26 4:51 ` [PATCH V3 1/5] dt-bindings: virtio: Add binding for virtio devices Viresh Kumar
2021-07-26 14:57 ` Rob Herring
2021-07-26 15:53 ` Arnd Bergmann
2021-07-26 20:36 ` Rob Herring
2021-07-26 21:20 ` Arnd Bergmann
2021-07-27 5:09 ` Viresh Kumar
2021-07-26 4:51 ` [PATCH V3 2/5] dt-bindings: i2c: Add bindings for i2c-virtio Viresh Kumar
2021-07-26 8:06 ` Arnd Bergmann
2021-07-26 8:11 ` Arnd Bergmann
2021-07-26 9:21 ` Viresh Kumar
2021-07-26 15:06 ` Rob Herring
2021-07-26 4:51 ` [PATCH V3 3/5] dt-bindings: gpio: Add bindings for gpio-virtio Viresh Kumar
2021-07-26 8:13 ` Arnd Bergmann [this message]
2021-07-26 15:11 ` Rob Herring
2021-07-26 4:51 ` [PATCH V3 4/5] uapi: virtio_ids: Sync ids with specification Viresh Kumar
2021-07-26 4:51 ` [PATCH V3 5/5] virtio: Bind virtio device to device-tree node Viresh Kumar
2021-09-13 9:19 ` Alexey Kardashevskiy
2021-09-13 9:45 ` Michael S. Tsirkin
2021-09-13 10:27 ` Alexey Kardashevskiy
2021-09-13 14:49 ` Guenter Roeck
2021-09-13 16:19 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1ze7+z=KQVtYZeGuA3Sjw=wWb44bjsbPpTaw_8m8U5ww@mail.gmail.com' \
--to=arnd@kernel.org \
--cc=alex.bennee@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=bill.mills@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=info@metux.net \
--cc=jasowang@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=jie.deng@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=robh+dt@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).