From: Rob Herring <robh+dt@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Viresh Kumar" <viresh.kumar@linaro.org>,
"Jason Wang" <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jean-Philippe Brucker" <jean-philippe@linaro.org>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Bill Mills" <bill.mills@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Enrico Weigelt, metux IT consult" <info@metux.net>,
"Jie Deng" <jie.deng@intel.com>,
DTML <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH V3 1/5] dt-bindings: virtio: Add binding for virtio devices
Date: Mon, 26 Jul 2021 14:36:14 -0600 [thread overview]
Message-ID: <CAL_JsqLk8q6N2Sf43em57OXKkrQ7SW01GBnAEV1zzPMYQF7agA@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a3bCk+iA+YziQrQFg6xH_d9cyySdTN_1j94D9CA8a_Sjw@mail.gmail.com>
On Mon, Jul 26, 2021 at 9:54 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> On Mon, Jul 26, 2021 at 4:57 PM Rob Herring <robh+dt@kernel.org> wrote:
> > On Sun, Jul 25, 2021 at 10:52 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > > + description: |
> > > + Exactly one node describing the virtio device. The name of the node isn't
> > > + significant but its phandle can be used to by a user of the virtio device.
> > > +
> > > + compatible:
> > > + pattern: "^virtio,[0-9a-f]+$"
> >
> > DID is only 4 chars? If so, "^virtio,[0-9a-f]{1,4}$"
>
> Any opinion on whether this should have any namespace prefix (or infix, I guess)
> after "virtio,"?
>
> I previously suggested making it "virtio,device[0-9a-f]{1,4}$", which would
> make it clearer that the following digits are the device ID rather
> than something
> else we might define in the future. Viresh picked this version because it's
> somewhat more consistent with other subsystems.
I'm fine either way, though I do find just a number a bit strange. So
I'd lean toward adding 'device' or even just a 'd'.
BTW, what happens if/when the device protocol is rev'ed? A new DID or
is there a separate revision that's discoverable?
Rob
next prev parent reply other threads:[~2021-07-26 20:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 4:51 [PATCH V3 0/5] virtio: Add virtio-device bindings Viresh Kumar
2021-07-26 4:51 ` [PATCH V3 1/5] dt-bindings: virtio: Add binding for virtio devices Viresh Kumar
2021-07-26 14:57 ` Rob Herring
2021-07-26 15:53 ` Arnd Bergmann
2021-07-26 20:36 ` Rob Herring [this message]
2021-07-26 21:20 ` Arnd Bergmann
2021-07-27 5:09 ` Viresh Kumar
2021-07-26 4:51 ` [PATCH V3 2/5] dt-bindings: i2c: Add bindings for i2c-virtio Viresh Kumar
2021-07-26 8:06 ` Arnd Bergmann
2021-07-26 8:11 ` Arnd Bergmann
2021-07-26 9:21 ` Viresh Kumar
2021-07-26 15:06 ` Rob Herring
2021-07-26 4:51 ` [PATCH V3 3/5] dt-bindings: gpio: Add bindings for gpio-virtio Viresh Kumar
2021-07-26 8:13 ` Arnd Bergmann
2021-07-26 15:11 ` Rob Herring
2021-07-26 4:51 ` [PATCH V3 4/5] uapi: virtio_ids: Sync ids with specification Viresh Kumar
2021-07-26 4:51 ` [PATCH V3 5/5] virtio: Bind virtio device to device-tree node Viresh Kumar
2021-09-13 9:19 ` Alexey Kardashevskiy
2021-09-13 9:45 ` Michael S. Tsirkin
2021-09-13 10:27 ` Alexey Kardashevskiy
2021-09-13 14:49 ` Guenter Roeck
2021-09-13 16:19 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLk8q6N2Sf43em57OXKkrQ7SW01GBnAEV1zzPMYQF7agA@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=alex.bennee@linaro.org \
--cc=arnd@kernel.org \
--cc=bill.mills@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=info@metux.net \
--cc=jasowang@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=jie.deng@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).