From: Arnd Bergmann <arnd@kernel.org>
To: Fangrui Song <maskray@google.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
llvm@lists.linux.dev, Jonathan Corbet <corbet@lwn.net>,
Federico Vaga <federico.vaga@vaga.pv.it>,
Alex Shi <alexs@kernel.org>, Hu Haowen <src.res@email.cn>,
Michal Marek <michal.lkml@markovi.net>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-doc-tw-discuss@lists.sourceforge.net,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Intel Graphics <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] [v2] Kbuild: move to -std=gnu11
Date: Tue, 1 Mar 2022 15:45:51 +0100 [thread overview]
Message-ID: <CAK8P3a2ZBOdEWTB1K9wA0v657VTZc-BC4LkDoQ0uw8Hw8FfSyg@mail.gmail.com> (raw)
In-Reply-To: <20220228214145.o37bgp3zl3rxpeo4@google.com>
On Mon, Feb 28, 2022 at 10:41 PM Fangrui Song <maskray@google.com> wrote:
> >
> >More precisely, the semantics of "extern inline" functions changed
> >between ISO C90 and ISO C99.
>
> Perhaps a clearer explanation to readers is: "extern inline" and "inline" swap
> semantics with gnu_inline (-fgnu89-inline or __attribute__((__gnu_inline__))).
>
> >That's the only concern I have, which I doubt is an issue. The kernel
> >is already covered by the function attribute as you note.
> >
> >Just to have some measure:
> >$ git grep -rn "extern inline" | wc -l
> >116
>
> "^inline" behaves like C99+ "extern inline"
>
> Agree this is handled by
>
> #define inline inline __gnu_inline __inline_maybe_unused notrace
>
Ok, I've reworded it again, but kept it a bit shorter, I don't think we
need the full explanation in this patch description in the end.
Thanks,
Arnd
next prev parent reply other threads:[~2022-03-01 14:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 10:27 [PATCH] [v2] Kbuild: move to -std=gnu11 Arnd Bergmann
2022-02-28 10:50 ` Greg KH
2022-02-28 11:25 ` Mark Rutland
2022-02-28 11:37 ` Arnd Bergmann
2022-02-28 18:40 ` Linus Torvalds
2022-02-28 17:07 ` Masahiro Yamada
2022-02-28 11:47 ` Marco Elver
2022-02-28 11:57 ` Arnd Bergmann
2022-02-28 16:56 ` Nathan Chancellor
2022-02-28 12:36 ` Jani Nikula
2022-02-28 13:01 ` Arnd Bergmann
2022-02-28 13:19 ` David Sterba
2022-02-28 12:48 ` Alex Shi
2022-02-28 12:56 ` David Sterba
2022-02-28 17:02 ` Masahiro Yamada
2022-02-28 18:24 ` Arnd Bergmann
2022-02-28 21:03 ` Nick Desaulniers
2022-02-28 21:41 ` Fangrui Song
2022-03-01 14:45 ` Arnd Bergmann [this message]
2022-03-01 10:43 ` Miguel Ojeda
2022-03-01 14:44 ` Arnd Bergmann
2022-05-16 13:10 ` Guenter Roeck
2022-05-16 13:31 ` [greybus-dev] " Greg KH
2022-05-16 14:19 ` Guenter Roeck
2022-05-18 7:46 ` Arnd Bergmann
2022-05-18 14:07 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a2ZBOdEWTB1K9wA0v657VTZc-BC4LkDoQ0uw8Hw8FfSyg@mail.gmail.com \
--to=arnd@kernel.org \
--cc=alexs@kernel.org \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=federico.vaga@vaga.pv.it \
--cc=greybus-dev@lists.linaro.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-doc-tw-discuss@lists.sourceforge.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=maskray@google.com \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=src.res@email.cn \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).