From: Arnd Bergmann <arnd@arndb.de>
To: kernel test robot <lkp@intel.com>
Cc: Christoph Hellwig <hch@lst.de>,
kbuild-all@lists.01.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>, Jeremy Kerr <jk@ozlabs.org>
Subject: Re: file.c:undefined reference to `.dump_emit'
Date: Mon, 6 Jul 2020 15:04:03 +0200 [thread overview]
Message-ID: <CAK8P3a2dLDf-gOezrzmp0J1ZtnnZgq5KstUO4RZ0Wnfs9J2H_A@mail.gmail.com> (raw)
In-Reply-To: <202007061834.Xh4DF8QN%lkp@intel.com>
On Mon, Jul 6, 2020 at 12:17 PM kernel test robot <lkp@intel.com> wrote:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: dcb7fd82c75ee2d6e6f9d8cc71c52519ed52e258
> commit: 5456ffdee666c66e27ccc1006f9afe83ad55559f powerpc/spufs: simplify spufs core dumping
> date: 9 weeks ago
> config: powerpc64-randconfig-c003-20200706 (attached as .config)
> compiler: powerpc64-linux-gcc (GCC) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> powerpc64-linux-ld: arch/powerpc/platforms/pseries/lpar.o:(.toc+0x0): undefined reference to `mmu_pid_bits'
> powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_proxydma_info_dump':
> >> file.c:(.text+0x4c68): undefined reference to `.dump_emit'
> powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_dma_info_dump':
> file.c:(.text+0x4d70): undefined reference to `.dump_emit'
> powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_wbox_info_dump':
> file.c:(.text+0x4df4): undefined reference to `.dump_emit'
> powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_ibox_info_dump':
> file.c:(.text+0x4e50): undefined reference to `.dump_emit'
> powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_mbox_info_dump':
> file.c:(.text+0x4eb0): undefined reference to `.dump_emit'
> powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o:file.c:(.text+0x4f10): more undefined references to `.dump_emit' follow
I'm sure there is a way to fix this properly with added complexity, either
making dump_emit() an empty inline function when CONFIG_COREDUMP
is disabled, or adding a lot of #ifdef checks in spufs itself.
In the interest of keeping things simple, I'd suggest doing this one instead:
--- a/arch/powerpc/platforms/cell/Kconfig
+++ b/arch/powerpc/platforms/cell/Kconfig
@@ -44,6 +44,7 @@ config SPU_FS
tristate "SPU file system"
default m
depends on PPC_CELL
+ depends on COREDUMP
select SPU_BASE
help
The SPU file system is used to access Synergistic Processing
I'll send a proper patch if there are no objections.
Arnd
next prev parent reply other threads:[~2020-07-06 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 10:13 file.c:undefined reference to `.dump_emit' kernel test robot
2020-07-06 13:04 ` Arnd Bergmann [this message]
2020-07-06 13:19 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a2dLDf-gOezrzmp0J1ZtnnZgq5KstUO4RZ0Wnfs9J2H_A@mail.gmail.com \
--to=arnd@arndb.de \
--cc=hch@lst.de \
--cc=jk@ozlabs.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).