* file.c:undefined reference to `.dump_emit'
@ 2020-07-06 10:13 kernel test robot
2020-07-06 13:04 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2020-07-06 10:13 UTC (permalink / raw)
To: Christoph Hellwig
Cc: kbuild-all, linux-kernel, Al Viro, Arnd Bergmann, Jeremy Kerr
[-- Attachment #1: Type: text/plain, Size: 1684 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: dcb7fd82c75ee2d6e6f9d8cc71c52519ed52e258
commit: 5456ffdee666c66e27ccc1006f9afe83ad55559f powerpc/spufs: simplify spufs core dumping
date: 9 weeks ago
config: powerpc64-randconfig-c003-20200706 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
powerpc64-linux-ld: arch/powerpc/platforms/pseries/lpar.o:(.toc+0x0): undefined reference to `mmu_pid_bits'
powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_proxydma_info_dump':
>> file.c:(.text+0x4c68): undefined reference to `.dump_emit'
powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_dma_info_dump':
file.c:(.text+0x4d70): undefined reference to `.dump_emit'
powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_wbox_info_dump':
file.c:(.text+0x4df4): undefined reference to `.dump_emit'
powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_ibox_info_dump':
file.c:(.text+0x4e50): undefined reference to `.dump_emit'
powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_mbox_info_dump':
file.c:(.text+0x4eb0): undefined reference to `.dump_emit'
powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o:file.c:(.text+0x4f10): more undefined references to `.dump_emit' follow
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34757 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: file.c:undefined reference to `.dump_emit'
2020-07-06 10:13 file.c:undefined reference to `.dump_emit' kernel test robot
@ 2020-07-06 13:04 ` Arnd Bergmann
2020-07-06 13:19 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2020-07-06 13:04 UTC (permalink / raw)
To: kernel test robot
Cc: Christoph Hellwig, kbuild-all, linux-kernel, Al Viro, Jeremy Kerr
On Mon, Jul 6, 2020 at 12:17 PM kernel test robot <lkp@intel.com> wrote:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: dcb7fd82c75ee2d6e6f9d8cc71c52519ed52e258
> commit: 5456ffdee666c66e27ccc1006f9afe83ad55559f powerpc/spufs: simplify spufs core dumping
> date: 9 weeks ago
> config: powerpc64-randconfig-c003-20200706 (attached as .config)
> compiler: powerpc64-linux-gcc (GCC) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> powerpc64-linux-ld: arch/powerpc/platforms/pseries/lpar.o:(.toc+0x0): undefined reference to `mmu_pid_bits'
> powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_proxydma_info_dump':
> >> file.c:(.text+0x4c68): undefined reference to `.dump_emit'
> powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_dma_info_dump':
> file.c:(.text+0x4d70): undefined reference to `.dump_emit'
> powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_wbox_info_dump':
> file.c:(.text+0x4df4): undefined reference to `.dump_emit'
> powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_ibox_info_dump':
> file.c:(.text+0x4e50): undefined reference to `.dump_emit'
> powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_mbox_info_dump':
> file.c:(.text+0x4eb0): undefined reference to `.dump_emit'
> powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o:file.c:(.text+0x4f10): more undefined references to `.dump_emit' follow
I'm sure there is a way to fix this properly with added complexity, either
making dump_emit() an empty inline function when CONFIG_COREDUMP
is disabled, or adding a lot of #ifdef checks in spufs itself.
In the interest of keeping things simple, I'd suggest doing this one instead:
--- a/arch/powerpc/platforms/cell/Kconfig
+++ b/arch/powerpc/platforms/cell/Kconfig
@@ -44,6 +44,7 @@ config SPU_FS
tristate "SPU file system"
default m
depends on PPC_CELL
+ depends on COREDUMP
select SPU_BASE
help
The SPU file system is used to access Synergistic Processing
I'll send a proper patch if there are no objections.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: file.c:undefined reference to `.dump_emit'
2020-07-06 13:04 ` Arnd Bergmann
@ 2020-07-06 13:19 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2020-07-06 13:19 UTC (permalink / raw)
To: kernel test robot
Cc: Christoph Hellwig, kbuild-all, linux-kernel, Al Viro, Jeremy Kerr
On Mon, Jul 6, 2020 at 3:04 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Mon, Jul 6, 2020 at 12:17 PM kernel test robot <lkp@intel.com> wrote:
> >
> In the interest of keeping things simple, I'd suggest doing this one instead:
>
> --- a/arch/powerpc/platforms/cell/Kconfig
> +++ b/arch/powerpc/platforms/cell/Kconfig
> @@ -44,6 +44,7 @@ config SPU_FS
> tristate "SPU file system"
> default m
> depends on PPC_CELL
> + depends on COREDUMP
> select SPU_BASE
> help
> The SPU file system is used to access Synergistic Processing
>
> I'll send a proper patch if there are no objections.
>
I see now that it's not even a regression, the report was just about
part of the output now coming from a different file.
I'll send the fix anyway, there is no need for this to be broken.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-06 13:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06 10:13 file.c:undefined reference to `.dump_emit' kernel test robot
2020-07-06 13:04 ` Arnd Bergmann
2020-07-06 13:19 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).