* [PATCH] Kbuild: shut up uboot mkimage output when building quietly
@ 2021-05-14 13:57 Arnd Bergmann
2021-05-17 7:09 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2021-05-14 13:57 UTC (permalink / raw)
To: Masahiro Yamada, Michal Marek; +Cc: Arnd Bergmann, linux-kbuild, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
When building with 'make -s', most architectures produce no output
at all unless there are warnings. However, on at leat mips and nios2
there is output from /usr/bin/mkimage when that is installed:
Image Name: Linux-5.12.0-next-20210427-00716
Created: Wed Apr 28 22:03:30 2021
Image Type: NIOS II Linux Kernel Image (gzip compressed)
Data Size: 2245876 Bytes = 2193.24 KiB = 2.14 MiB
Load Address: d0000000
Entry Point: d0000000
Make these behave like the others and check for the '${quiet}'
variable to see if we should redirect the output to /dev/null.
Any errors and warnings from mkimage will still be seen as those
get sent to stderr.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
scripts/mkuboot.sh | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/scripts/mkuboot.sh b/scripts/mkuboot.sh
index 4b1fe09e9042..031b5d6b839f 100755
--- a/scripts/mkuboot.sh
+++ b/scripts/mkuboot.sh
@@ -17,4 +17,8 @@ if [ -z "${MKIMAGE}" ]; then
fi
# Call "mkimage" to create U-Boot image
-${MKIMAGE} "$@"
+if [ "${quiet}" != "silent_" ]; then
+${MKIMAGE} "$@" ${REDIRECT}
+else
+${MKIMAGE} "$@" ${REDIRECT} > /dev/null
+fi
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Kbuild: shut up uboot mkimage output when building quietly
2021-05-14 13:57 [PATCH] Kbuild: shut up uboot mkimage output when building quietly Arnd Bergmann
@ 2021-05-17 7:09 ` Masahiro Yamada
2021-05-17 7:28 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2021-05-17 7:09 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Michal Marek, Arnd Bergmann, Linux Kbuild mailing list,
Linux Kernel Mailing List
On Fri, May 14, 2021 at 10:58 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> When building with 'make -s', most architectures produce no output
> at all unless there are warnings. However, on at leat mips and nios2
> there is output from /usr/bin/mkimage when that is installed:
>
> Image Name: Linux-5.12.0-next-20210427-00716
> Created: Wed Apr 28 22:03:30 2021
> Image Type: NIOS II Linux Kernel Image (gzip compressed)
> Data Size: 2245876 Bytes = 2193.24 KiB = 2.14 MiB
> Load Address: d0000000
> Entry Point: d0000000
>
> Make these behave like the others and check for the '${quiet}'
> variable to see if we should redirect the output to /dev/null.
> Any errors and warnings from mkimage will still be seen as those
> get sent to stderr.
Thanks for the report, but I rather want to suppress stdout
in the kbuild core macro.
I wrote this patch.
https://lore.kernel.org/patchwork/patch/1429409/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> scripts/mkuboot.sh | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/mkuboot.sh b/scripts/mkuboot.sh
> index 4b1fe09e9042..031b5d6b839f 100755
> --- a/scripts/mkuboot.sh
> +++ b/scripts/mkuboot.sh
> @@ -17,4 +17,8 @@ if [ -z "${MKIMAGE}" ]; then
> fi
>
> # Call "mkimage" to create U-Boot image
> -${MKIMAGE} "$@"
> +if [ "${quiet}" != "silent_" ]; then
> +${MKIMAGE} "$@" ${REDIRECT}
> +else
> +${MKIMAGE} "$@" ${REDIRECT} > /dev/null
> +fi
> --
> 2.29.2
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Kbuild: shut up uboot mkimage output when building quietly
2021-05-17 7:09 ` Masahiro Yamada
@ 2021-05-17 7:28 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2021-05-17 7:28 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Michal Marek, Linux Kbuild mailing list, Linux Kernel Mailing List
On Mon, May 17, 2021 at 9:09 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Fri, May 14, 2021 at 10:58 PM Arnd Bergmann <arnd@kernel.org> wrote:
> >
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > When building with 'make -s', most architectures produce no output
> > at all unless there are warnings. However, on at leat mips and nios2
> > there is output from /usr/bin/mkimage when that is installed:
> >
> > Image Name: Linux-5.12.0-next-20210427-00716
> > Created: Wed Apr 28 22:03:30 2021
> > Image Type: NIOS II Linux Kernel Image (gzip compressed)
> > Data Size: 2245876 Bytes = 2193.24 KiB = 2.14 MiB
> > Load Address: d0000000
> > Entry Point: d0000000
> >
> > Make these behave like the others and check for the '${quiet}'
> > variable to see if we should redirect the output to /dev/null.
> > Any errors and warnings from mkimage will still be seen as those
> > get sent to stderr.
>
> Thanks for the report, but I rather want to suppress stdout
> in the kbuild core macro.
>
> I wrote this patch.
> https://lore.kernel.org/patchwork/patch/1429409/
Looks good, thank you for taking care of it.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-17 7:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14 13:57 [PATCH] Kbuild: shut up uboot mkimage output when building quietly Arnd Bergmann
2021-05-17 7:09 ` Masahiro Yamada
2021-05-17 7:28 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).