linux-next: build failure after merge of almost all the trees

linux-next: build failure after merge of almost all the trees

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi all,

Today's linux-next build (powerpc allyesconfig) failed like this:

fs/ntfs/aops.c: In function 'ntfs_write_mst_block':
fs/ntfs/aops.c:1311:1: error: the frame size of 2304 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
 1311 | }
      | ^
cc1: all warnings being treated as errors

I have no idea what has caused this.

I have disabled ntfs for now.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of almost all the trees

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

Hi all,

On Thu, 28 Oct 2021 21:26:51 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next build (powerpc allyesconfig) failed like this:
> 
> fs/ntfs/aops.c: In function 'ntfs_write_mst_block':
> fs/ntfs/aops.c:1311:1: error: the frame size of 2304 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
>  1311 | }
>       | ^
> cc1: all warnings being treated as errors
> 
> I have no idea what has caused this.

With a nudge from Arnd, it seems the immediate case was commit

  f22969a66041 ("powerpc/64s: Default to 64K pages for 64 bit book3s")

from the powerpc tree switching the allyesconfig build from 4k pages to
64k pages which expanded a few arrays on the stack in that function.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of almost all the trees

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

Hi all,

On Thu, 28 Oct 2021 23:38:44 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
> 
> On Thu, 28 Oct 2021 21:26:51 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Today's linux-next build (powerpc allyesconfig) failed like this:
> > 
> > fs/ntfs/aops.c: In function 'ntfs_write_mst_block':
> > fs/ntfs/aops.c:1311:1: error: the frame size of 2304 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> >  1311 | }
> >       | ^
> > cc1: all warnings being treated as errors
> > 
> > I have no idea what has caused this.  
> 
> With a nudge from Arnd, it seems the immediate case was commit
> 
>   f22969a66041 ("powerpc/64s: Default to 64K pages for 64 bit book3s")
> 
> from the powerpc tree switching the allyesconfig build from 4k pages to
> 64k pages which expanded a few arrays on the stack in that function.

Can we do something about this, please?
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of almost all the trees

[Arnd Bergmann]

On Tue, Nov 2, 2021 at 7:44 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> On Thu, 28 Oct 2021 23:38:44 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > On Thu, 28 Oct 2021 21:26:51 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Today's linux-next build (powerpc allyesconfig) failed like this:
> > >
> > > fs/ntfs/aops.c: In function 'ntfs_write_mst_block':
> > > fs/ntfs/aops.c:1311:1: error: the frame size of 2304 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> > >  1311 | }
> > >       | ^
> > > cc1: all warnings being treated as errors
> > >
> > > I have no idea what has caused this.
> >
> > With a nudge from Arnd, it seems the immediate case was commit
> >
> >   f22969a66041 ("powerpc/64s: Default to 64K pages for 64 bit book3s")
> >
> > from the powerpc tree switching the allyesconfig build from 4k pages to
> > 64k pages which expanded a few arrays on the stack in that function.
>
> Can we do something about this, please?

I submitted a workaround a while ago. Anton didn't like it, but has not
come up with a proper fix in ntfs either:

https://lore.kernel.org/lkml/20210927141815.1711736-1-arnd@kernel.org/

It does need to be changed a bit as I realized it depends on a rework of
the Kconfig logic that I had in my randconfig build tree to have a common
page size symbol across architectures. Without my other patch, it also
needs to check for PPC_64K_PAGES.

Should I send an updated version of the patch?

       Arnd

Re: linux-next: build failure after merge of almost all the trees

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1985 bytes --]

Hi Arnd,

On Tue, 2 Nov 2021 08:06:10 +0100 Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Tue, Nov 2, 2021 at 7:44 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Thu, 28 Oct 2021 23:38:44 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> > >
> > > On Thu, 28 Oct 2021 21:26:51 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> > > >
> > > > Today's linux-next build (powerpc allyesconfig) failed like this:
> > > >
> > > > fs/ntfs/aops.c: In function 'ntfs_write_mst_block':
> > > > fs/ntfs/aops.c:1311:1: error: the frame size of 2304 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> > > >  1311 | }
> > > >       | ^
> > > > cc1: all warnings being treated as errors
> > > >
> > > > I have no idea what has caused this.  
> > >
> > > With a nudge from Arnd, it seems the immediate case was commit
> > >
> > >   f22969a66041 ("powerpc/64s: Default to 64K pages for 64 bit book3s")
> > >
> > > from the powerpc tree switching the allyesconfig build from 4k pages to
> > > 64k pages which expanded a few arrays on the stack in that function.  
> >
> > Can we do something about this, please?  
> 
> I submitted a workaround a while ago. Anton didn't like it, but has not
> come up with a proper fix in ntfs either:
> 
> https://lore.kernel.org/lkml/20210927141815.1711736-1-arnd@kernel.org/
> 
> It does need to be changed a bit as I realized it depends on a rework of
> the Kconfig logic that I had in my randconfig build tree to have a common
> page size symbol across architectures. Without my other patch, it also
> needs to check for PPC_64K_PAGES.
> 
> Should I send an updated version of the patch?

That would be good, thanks.

Even better would be to split up the function some how, but having had
a bit of a look at it, that may be a much longer job.  I am assuming
that allocations (or their failure) are out of the question in that
particular function.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of almost all the trees

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2243 bytes --]

Hi all,

On Tue, 2 Nov 2021 23:13:07 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Tue, 2 Nov 2021 08:06:10 +0100 Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > On Tue, Nov 2, 2021 at 7:44 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> > >
> > > On Thu, 28 Oct 2021 23:38:44 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:    
> > > >
> > > > On Thu, 28 Oct 2021 21:26:51 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:    
> > > > >
> > > > > Today's linux-next build (powerpc allyesconfig) failed like this:
> > > > >
> > > > > fs/ntfs/aops.c: In function 'ntfs_write_mst_block':
> > > > > fs/ntfs/aops.c:1311:1: error: the frame size of 2304 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> > > > >  1311 | }
> > > > >       | ^
> > > > > cc1: all warnings being treated as errors
> > > > >
> > > > > I have no idea what has caused this.    
> > > >
> > > > With a nudge from Arnd, it seems the immediate case was commit
> > > >
> > > >   f22969a66041 ("powerpc/64s: Default to 64K pages for 64 bit book3s")
> > > >
> > > > from the powerpc tree switching the allyesconfig build from 4k pages to
> > > > 64k pages which expanded a few arrays on the stack in that function.    
> > >
> > > Can we do something about this, please?    
> > 
> > I submitted a workaround a while ago. Anton didn't like it, but has not
> > come up with a proper fix in ntfs either:
> > 
> > https://lore.kernel.org/lkml/20210927141815.1711736-1-arnd@kernel.org/
> > 
> > It does need to be changed a bit as I realized it depends on a rework of
> > the Kconfig logic that I had in my randconfig build tree to have a common
> > page size symbol across architectures. Without my other patch, it also
> > needs to check for PPC_64K_PAGES.
> > 
> > Should I send an updated version of the patch?  
> 
> That would be good, thanks.
> 
> Even better would be to split up the function some how, but having had
> a bit of a look at it, that may be a much longer job.  I am assuming
> that allocations (or their failure) are out of the question in that
> particular function.

Looking again, we probably just need to disable CONFIG_NTFS_RW ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of almost all the trees

[Arnd Bergmann]

On Tue, Nov 2, 2021 at 1:19 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Tue, 2 Nov 2021 23:13:07 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > On Tue, 2 Nov 2021 08:06:10 +0100 Arnd Bergmann <arnd@arndb.de> wrote:
> > > On Tue, Nov 2, 2021 at 7:44 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > It does need to be changed a bit as I realized it depends on a rework of
> > > the Kconfig logic that I had in my randconfig build tree to have a common
> > > page size symbol across architectures. Without my other patch, it also
> > > needs to check for PPC_64K_PAGES.
> > >
> > > Should I send an updated version of the patch?
> >
> > That would be good, thanks.
> >
> > Even better would be to split up the function some how, but having had
> > a bit of a look at it, that may be a much longer job.

Yes, that was my initial conclusion when I looked at the code trying to
redo that loop.

> > I am assuming
> > that allocations (or their failure) are out of the question in that
> > particular function.
>
> Looking again, we probably just need to disable CONFIG_NTFS_RW ...

Ah right, that would work as well. Another possibility would be
to change NTFS_BLOCK_SIZE to 4096, at least in the affected configurations.

According to the documentation I linked to in my commit, file system images
with smaller block sizes should be extremely rare, but I have no idea if the
code would work correctly for normal images after that change.

        Arnd

Re: linux-next: build failure after merge of almost all the trees

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

Hi all,

On Thu, 28 Oct 2021 21:26:51 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
> 
> Today's linux-next build (powerpc allyesconfig) failed like this:
> 
> fs/ntfs/aops.c: In function 'ntfs_write_mst_block':
> fs/ntfs/aops.c:1311:1: error: the frame size of 2304 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
>  1311 | }
>       | ^
> cc1: all warnings being treated as errors
> 
> I have no idea what has caused this.
> 
> I have disabled ntfs for now.

So from today, I have used this instead (i.e. disable CONFIG_NTFS_RW):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 3 Nov 2021 15:17:17 +1100
Subject: [PATCH] Mark NTFS_RW as BROKEN

it currently breaks the ppc allyesonfig build

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 fs/ntfs/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/ntfs/Kconfig b/fs/ntfs/Kconfig
index 1667a7e590d8..68cfef0280f2 100644
--- a/fs/ntfs/Kconfig
+++ b/fs/ntfs/Kconfig
@@ -52,6 +52,7 @@ config NTFS_DEBUG
 config NTFS_RW
 	bool "NTFS write support"
 	depends on NTFS_FS
+	depends on BROKEN
 	help
 	  This enables the partial, but safe, write support in the NTFS driver.
 
-- 
2.33.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]