From: Arnd Bergmann <arnd@kernel.org>
To: Karol Herbst <kherbst@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lyude Paul <lyude@redhat.com>, Ben Skeggs <bskeggs@redhat.com>,
Randy Dunlap <rdunlap@infradead.org>,
Daniel Vetter <daniel@ffwll.ch>,
ML nouveau <nouveau@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] nouveau: make backlight support non optional
Date: Sat, 24 Jul 2021 08:55:31 +0200 [thread overview]
Message-ID: <CAK8P3a3u_jsxQW4dPXtsdKkw1mjKXL-h=qN1SGHytvUMPf3fPw@mail.gmail.com> (raw)
In-Reply-To: <20210723224617.3088886-1-kherbst@redhat.com>
On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst <kherbst@redhat.com> wrote:
>
> In the past this only led to compilation issues. Also the small amount of
> extra .text shouldn't really matter compared to the entire nouveau driver
> anyway.
>
> select DRM_TTM_HELPER
> - select BACKLIGHT_CLASS_DEVICE if DRM_NOUVEAU_BACKLIGHT
> - select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT
> + select BACKLIGHT_CLASS_DEVICE
> + select ACPI_VIDEO if ACPI && X86 && INPUT
> select X86_PLATFORM_DEVICES if ACPI && X86
> select ACPI_WMI if ACPI && X86
I think the logic needs to be the reverse: instead of 'select
BACKLIGHT_CLASS_DEVICE',
this should be 'depends on BACKLIGHT_CLASS_DEVICE', and the same for ACPI_VIDEO.
We may want to add 'default DRM || FB' to BACKLIGHT_CLASS_DEVICE in the
process so we don't lose it for users doing 'make oldconfig' or 'make defconfig'
The rest of the patch looks good to me.
Arnd
next prev parent reply other threads:[~2021-07-24 6:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 22:46 Karol Herbst
2021-07-24 6:55 ` Arnd Bergmann [this message]
2021-07-24 9:54 ` Karol Herbst
2021-07-24 11:56 ` Arnd Bergmann
2021-07-24 12:10 ` Karol Herbst
2021-07-24 12:51 ` Karol Herbst
2021-07-24 14:04 ` Arnd Bergmann
2021-07-24 14:13 ` Karol Herbst
2021-07-24 14:58 ` Arnd Bergmann
2021-08-04 14:10 ` [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices Karol Herbst
2021-08-04 14:19 ` Arnd Bergmann
2021-08-04 14:43 ` Karol Herbst
2021-08-04 18:59 ` Karol Herbst
2021-08-04 21:09 ` Arnd Bergmann
2021-08-04 22:01 ` Karol Herbst
2021-08-05 6:50 ` Arnd Bergmann
2021-08-09 13:20 ` [PATCH] nouveau: make backlight support non optional Jani Nikula
2021-08-09 13:30 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a3u_jsxQW4dPXtsdKkw1mjKXL-h=qN1SGHytvUMPf3fPw@mail.gmail.com' \
--to=arnd@kernel.org \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kherbst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=rdunlap@infradead.org \
--subject='Re: [PATCH] nouveau: make backlight support non optional' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).