From: Ohad Ben-Cohen <ohad@wizery.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
David Brown <davidb@codeaurora.org>,
Tony Lindgren <tony@atomide.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Stuart Yoder <b08248@gmail.com>,
Scott Wood <scottwood@freescale.com>,
Hiroshi Doyu <hdoyu@nvidia.com>
Subject: Re: [PATCH 2/6] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute
Date: Mon, 30 Jan 2012 17:42:42 +0200 [thread overview]
Message-ID: <CAK=WgbYhymxGi4VHKcYe1Lq6KHC3Lp5zCOYGdD334GjmB-mmTQ@mail.gmail.com> (raw)
In-Reply-To: <20120130144909.GT19255@amd.com>
On Mon, Jan 30, 2012 at 4:49 PM, Joerg Roedel <joerg.roedel@amd.com> wrote:
> Hardware specific attributes are intended, but not limited to hardware
> specific drivers. A generic driver that _may_ run on a given hardware
> can use a hardware specific attribute too. If it doesn't run on this
> hardware it will just get -EINVAL back.
That sounds good.
But I'm still not sure what's the advantage of the attribute API on
top of regular, type-safe, dedicated API for every attribute: it
doesn't sound like there's a vast number of attributes, only a
handful, and dedicated API just sound (to me) much more readable and
less prone to error.
But, again, maybe it's only me :)
Thanks,
Ohad.
next prev parent reply other threads:[~2012-01-30 15:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 18:40 [PATCH 0/6 v2] IOMMU: Make IOMMU-API ready for GART-like hardware Joerg Roedel
2012-01-26 18:40 ` [PATCH 1/6] iommu: Add domain-attribute handlers Joerg Roedel
2012-01-26 18:40 ` [PATCH 2/6] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute Joerg Roedel
2012-01-27 7:08 ` Ohad Ben-Cohen
2012-01-27 10:26 ` Joerg Roedel
2012-01-27 11:00 ` Ohad Ben-Cohen
2012-01-27 13:03 ` Joerg Roedel
2012-01-28 20:44 ` Ohad Ben-Cohen
2012-01-30 14:49 ` Joerg Roedel
2012-01-30 15:42 ` Ohad Ben-Cohen [this message]
2012-01-26 18:40 ` [PATCH 3/6] iommu/vt-d: " Joerg Roedel
2012-01-26 18:40 ` [PATCH 4/6] iommu/omap: " Joerg Roedel
2012-01-26 18:40 ` [PATCH 5/6] iommu/msm: " Joerg Roedel
2012-01-27 0:07 ` David Brown
2012-01-26 18:40 ` [PATCH 6/6] iommu/tegra: " Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK=WgbYhymxGi4VHKcYe1Lq6KHC3Lp5zCOYGdD334GjmB-mmTQ@mail.gmail.com' \
--to=ohad@wizery.com \
--cc=b08248@gmail.com \
--cc=davidb@codeaurora.org \
--cc=dwmw2@infradead.org \
--cc=hdoyu@nvidia.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=scottwood@freescale.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).