[PATCH] f_ncm: ncm_bitrate (speed) is unsigned

[PATCH] f_ncm: ncm_bitrate (speed) is unsigned

[Maciej Żenczykowski]

From: Maciej Żenczykowski <maze@google.com>

[  190.544755] configfs-gadget gadget: notify speed -44967296

This is because 4250000000 - 2**32 is -44967296.

Cc: Brooke Basile <brookebasile@gmail.com>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Lorenzo Colitti <lorenzo@google.com>
Cc: Yauheni Kaliuta <yauheni.kaliuta@nokia.com>
Cc: Linux USB Mailing List <linux-usb@vger.kernel.org>
Fixes: 9f6ce4240a2b ("usb: gadget: f_ncm.c added")
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
 drivers/usb/gadget/function/f_ncm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/f_ncm.c b/drivers/usb/gadget/function/f_ncm.c
index 019bea8e09cc..0d23c6c11a13 100644
--- a/drivers/usb/gadget/function/f_ncm.c
+++ b/drivers/usb/gadget/function/f_ncm.c
@@ -583,7 +583,7 @@ static void ncm_do_notify(struct f_ncm *ncm)
 		data[0] = cpu_to_le32(ncm_bitrate(cdev->gadget));
 		data[1] = data[0];
 
-		DBG(cdev, "notify speed %d\n", ncm_bitrate(cdev->gadget));
+		DBG(cdev, "notify speed %u\n", ncm_bitrate(cdev->gadget));
 		ncm->notify_state = NCM_NOTIFY_CONNECT;
 		break;
 	}
-- 
2.32.0.rc1.229.g3e70b5a671-goog

Re: [PATCH] f_ncm: ncm_bitrate (speed) is unsigned

[Lorenzo Colitti]

On Tue, Jun 8, 2021 at 9:53 AM Maciej Żenczykowski
<zenczykowski@gmail.com> wrote:
> --- a/drivers/usb/gadget/function/f_ncm.c
> +++ b/drivers/usb/gadget/function/f_ncm.c
> @@ -583,7 +583,7 @@ static void ncm_do_notify(struct f_ncm *ncm)
>                 data[0] = cpu_to_le32(ncm_bitrate(cdev->gadget));
>                 data[1] = data[0];
>
> -               DBG(cdev, "notify speed %d\n", ncm_bitrate(cdev->gadget));
> +               DBG(cdev, "notify speed %u\n", ncm_bitrate(cdev->gadget));
>                 ncm->notify_state = NCM_NOTIFY_CONNECT;
>                 break;
>         }

Acked-By: Lorenzo Colitti <lorenzo@google.com>