* [PATCH] fs/nilfs2: remove some unused macros to tame gcc
@ 2020-12-09 22:25 Ryusuke Konishi
2020-12-09 22:27 ` Ryusuke Konishi
0 siblings, 1 reply; 3+ messages in thread
From: Ryusuke Konishi @ 2020-12-09 22:25 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-nilfs, LKML
From: Alex Shi <alex.shi@linux.alibaba.com>
There some macros are unused and cause gcc warning. Remove them.
fs/nilfs2/segment.c:137:0: warning: macro "nilfs_cnt32_gt" is not used
[-Wunused-macros]
fs/nilfs2/segment.c:144:0: warning: macro "nilfs_cnt32_le" is not used
[-Wunused-macros]
fs/nilfs2/segment.c:143:0: warning: macro "nilfs_cnt32_lt" is not used
[-Wunused-macros]
Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
---
fs/nilfs2/segment.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c
index e3726aca28ed..cd4da9535aed 100644
--- a/fs/nilfs2/segment.c
+++ b/fs/nilfs2/segment.c
@@ -134,14 +134,9 @@ struct nilfs_sc_operations {
static void nilfs_segctor_do_immediate_flush(struct nilfs_sc_info *);
static void nilfs_dispose_list(struct the_nilfs *, struct list_head *, int);
-#define nilfs_cnt32_gt(a, b) \
- (typecheck(__u32, a) && typecheck(__u32, b) && \
- ((__s32)(b) - (__s32)(a) < 0))
#define nilfs_cnt32_ge(a, b) \
(typecheck(__u32, a) && typecheck(__u32, b) && \
((__s32)(a) - (__s32)(b) >= 0))
-#define nilfs_cnt32_lt(a, b) nilfs_cnt32_gt(b, a)
-#define nilfs_cnt32_le(a, b) nilfs_cnt32_ge(b, a)
static int nilfs_prepare_segment_lock(struct super_block *sb,
struct nilfs_transaction_info *ti)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/nilfs2: remove some unused macros to tame gcc
2020-12-09 22:25 [PATCH] fs/nilfs2: remove some unused macros to tame gcc Ryusuke Konishi
@ 2020-12-09 22:27 ` Ryusuke Konishi
0 siblings, 0 replies; 3+ messages in thread
From: Ryusuke Konishi @ 2020-12-09 22:27 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-nilfs, LKML
Hi Andrew,
Please queue this, a gcc warning fix, for the next merge window.
Thanks,
Ryusuke Konishi
On Thu, Dec 10, 2020 at 7:25 AM Ryusuke Konishi
<konishi.ryusuke@gmail.com> wrote:
>
> From: Alex Shi <alex.shi@linux.alibaba.com>
>
> There some macros are unused and cause gcc warning. Remove them.
>
> fs/nilfs2/segment.c:137:0: warning: macro "nilfs_cnt32_gt" is not used
> [-Wunused-macros]
> fs/nilfs2/segment.c:144:0: warning: macro "nilfs_cnt32_le" is not used
> [-Wunused-macros]
> fs/nilfs2/segment.c:143:0: warning: macro "nilfs_cnt32_lt" is not used
> [-Wunused-macros]
>
> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
> ---
> fs/nilfs2/segment.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c
> index e3726aca28ed..cd4da9535aed 100644
> --- a/fs/nilfs2/segment.c
> +++ b/fs/nilfs2/segment.c
> @@ -134,14 +134,9 @@ struct nilfs_sc_operations {
> static void nilfs_segctor_do_immediate_flush(struct nilfs_sc_info *);
> static void nilfs_dispose_list(struct the_nilfs *, struct list_head *, int);
>
> -#define nilfs_cnt32_gt(a, b) \
> - (typecheck(__u32, a) && typecheck(__u32, b) && \
> - ((__s32)(b) - (__s32)(a) < 0))
> #define nilfs_cnt32_ge(a, b) \
> (typecheck(__u32, a) && typecheck(__u32, b) && \
> ((__s32)(a) - (__s32)(b) >= 0))
> -#define nilfs_cnt32_lt(a, b) nilfs_cnt32_gt(b, a)
> -#define nilfs_cnt32_le(a, b) nilfs_cnt32_ge(b, a)
>
> static int nilfs_prepare_segment_lock(struct super_block *sb,
> struct nilfs_transaction_info *ti)
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] fs/nilfs2: remove some unused macros to tame gcc
@ 2020-11-06 5:48 Alex Shi
0 siblings, 0 replies; 3+ messages in thread
From: Alex Shi @ 2020-11-06 5:48 UTC (permalink / raw)
To: konishi.ryusuke; +Cc: linux-nilfs, linux-kernel
There some macros are unused and cause gcc warning. Remove them.
fs/nilfs2/segment.c:137:0: warning: macro "nilfs_cnt32_gt" is not used
[-Wunused-macros]
fs/nilfs2/segment.c:144:0: warning: macro "nilfs_cnt32_le" is not used
[-Wunused-macros]
fs/nilfs2/segment.c:143:0: warning: macro "nilfs_cnt32_lt" is not used
[-Wunused-macros]
Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: linux-nilfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
fs/nilfs2/segment.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c
index e3726aca28ed..cd4da9535aed 100644
--- a/fs/nilfs2/segment.c
+++ b/fs/nilfs2/segment.c
@@ -134,14 +134,9 @@ struct nilfs_sc_operations {
static void nilfs_segctor_do_immediate_flush(struct nilfs_sc_info *);
static void nilfs_dispose_list(struct the_nilfs *, struct list_head *, int);
-#define nilfs_cnt32_gt(a, b) \
- (typecheck(__u32, a) && typecheck(__u32, b) && \
- ((__s32)(b) - (__s32)(a) < 0))
#define nilfs_cnt32_ge(a, b) \
(typecheck(__u32, a) && typecheck(__u32, b) && \
((__s32)(a) - (__s32)(b) >= 0))
-#define nilfs_cnt32_lt(a, b) nilfs_cnt32_gt(b, a)
-#define nilfs_cnt32_le(a, b) nilfs_cnt32_ge(b, a)
static int nilfs_prepare_segment_lock(struct super_block *sb,
struct nilfs_transaction_info *ti)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-09 22:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 22:25 [PATCH] fs/nilfs2: remove some unused macros to tame gcc Ryusuke Konishi
2020-12-09 22:27 ` Ryusuke Konishi
-- strict thread matches above, loose matches on Subject: below --
2020-11-06 5:48 Alex Shi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).