* [PATCH] drm: lima: Add support for multiple reset lines
@ 2019-10-01 18:29 John Stultz
2019-10-05 9:27 ` Qiang Yu
0 siblings, 1 reply; 2+ messages in thread
From: John Stultz @ 2019-10-01 18:29 UTC (permalink / raw)
To: lkml
Cc: Peter Griffin, Qiang Yu, David Airlie, Daniel Vetter, dri-devel,
lima, John Stultz
From: Peter Griffin <peter.griffin@linaro.org>
Some SoCs like HiKey have 2 reset lines, so update
to use the devm_reset_control_array_* variant of the
API so that multiple resets can be specified in DT.
Cc: Qiang Yu <yuq825@gmail.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: lima@lists.freedesktop.org
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
drivers/gpu/drm/lima/lima_device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/lima/lima_device.c b/drivers/gpu/drm/lima/lima_device.c
index d86b8d81a483..e3e0ca11382e 100644
--- a/drivers/gpu/drm/lima/lima_device.c
+++ b/drivers/gpu/drm/lima/lima_device.c
@@ -105,7 +105,8 @@ static int lima_clk_init(struct lima_device *dev)
if (err)
goto error_out0;
- dev->reset = devm_reset_control_get_optional(dev->dev, NULL);
+ dev->reset = devm_reset_control_array_get_optional_shared(dev->dev);
+
if (IS_ERR(dev->reset)) {
err = PTR_ERR(dev->reset);
if (err != -EPROBE_DEFER)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: lima: Add support for multiple reset lines
2019-10-01 18:29 [PATCH] drm: lima: Add support for multiple reset lines John Stultz
@ 2019-10-05 9:27 ` Qiang Yu
0 siblings, 0 replies; 2+ messages in thread
From: Qiang Yu @ 2019-10-05 9:27 UTC (permalink / raw)
To: John Stultz
Cc: lkml, Peter Griffin, David Airlie, Daniel Vetter, dri-devel, lima
On Wed, Oct 2, 2019 at 2:29 AM John Stultz <john.stultz@linaro.org> wrote:
>
> From: Peter Griffin <peter.griffin@linaro.org>
>
> Some SoCs like HiKey have 2 reset lines, so update
> to use the devm_reset_control_array_* variant of the
> API so that multiple resets can be specified in DT.
>
> Cc: Qiang Yu <yuq825@gmail.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: lima@lists.freedesktop.org
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
> drivers/gpu/drm/lima/lima_device.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_device.c b/drivers/gpu/drm/lima/lima_device.c
> index d86b8d81a483..e3e0ca11382e 100644
> --- a/drivers/gpu/drm/lima/lima_device.c
> +++ b/drivers/gpu/drm/lima/lima_device.c
> @@ -105,7 +105,8 @@ static int lima_clk_init(struct lima_device *dev)
> if (err)
> goto error_out0;
>
> - dev->reset = devm_reset_control_get_optional(dev->dev, NULL);
> + dev->reset = devm_reset_control_array_get_optional_shared(dev->dev);
> +
> if (IS_ERR(dev->reset)) {
> err = PTR_ERR(dev->reset);
> if (err != -EPROBE_DEFER)
> --
> 2.17.1
>
Looks good for me, patch is:
Reviewed-by: Qiang Yu <yuq825@gmail.com>
I'll apply it to drm-misc-next.
Thanks,
Qiang
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-05 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01 18:29 [PATCH] drm: lima: Add support for multiple reset lines John Stultz
2019-10-05 9:27 ` Qiang Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).