From: Daniel Vetter <daniel@ffwll.ch>
To: Rob Clark <robdclark@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"Shi, Yang A" <yang.a.shi@intel.com>,
"'linux-kernel@vger.kernel.org' (linux-kernel@vger.kernel.org)"
<linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
"alexander.deucher@amd.com" <alexander.deucher@amd.com>,
"airlied@redhat.com" <airlied@redhat.com>,
"Liu, Chuansheng" <chuansheng.liu@intel.com>
Subject: Re: [Patch 0/1]drm_irq: Introducing the irq_thread support
Date: Thu, 11 Oct 2012 17:18:00 +0200 [thread overview]
Message-ID: <CAKMK7uFMAx=+ziO5bS6cr+f1x2b5GHCOFsFFTkPJOXOZsF+USw@mail.gmail.com> (raw)
In-Reply-To: <CAF6AEGsd7AyBzJhAt-HTZ+NHajOEUnfpaz2u-KmBS1JWs2yHtA@mail.gmail.com>
On Thu, Oct 11, 2012 at 3:19 PM, Rob Clark <robdclark@gmail.com> wrote:
>> Should the documenation be updated to mark those functions as deprecated for
>> new drivers and explain how to handle IRQ (un)registration manually ?
They're not deprecated, since for most drivers they're good enough.
Maybe just make it clear that they're optional (and whoever's the
first might need to do some refactoring to make things simpler for
fancy irq handling).
> It might be nice to provide the driver an option to give it's own
> install/uninstall irq fxn ptrs.. this way we can keep
> drm_irq_install/uninstall(). In particular, the uninstall fxn still
> does some useful cleanup like wake up anyone waiting for vblank events
> which would still be needed by drivers registering irq in their own
> special way. And the irq pre/post-install stuff is still a bit nice
> to keep.
If a driver needs its own irq setup/teardown magic, I'd prefer if we
simply extract the useful parts of the common code into a little
helper that drivers can call, and don't add new&fancy callbacks and
interface. At least not without really good reasons.
/me has seen enough midlayer awesomeness in drm land already
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2012-10-11 15:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 1:53 [Patch 0/1]drm_irq: Introducing the irq_thread support Liu, Chuansheng
2012-09-05 12:49 ` Alan Cox
2012-09-06 0:42 ` Liu, Chuansheng
2012-09-06 7:39 ` Daniel Vetter
2012-09-05 13:27 ` Daniel Vetter
2012-09-05 15:12 ` Shi, Yang A
2012-09-05 15:32 ` Daniel Vetter
2012-09-06 0:54 ` Liu, Chuansheng
2012-09-05 15:47 ` Rob Clark
2012-09-06 0:48 ` Liu, Chuansheng
2012-10-11 12:07 ` Laurent Pinchart
2012-10-11 13:19 ` Rob Clark
2012-10-11 15:18 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKMK7uFMAx=+ziO5bS6cr+f1x2b5GHCOFsFFTkPJOXOZsF+USw@mail.gmail.com' \
--to=daniel@ffwll.ch \
--cc=airlied@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=chuansheng.liu@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=yang.a.shi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).