archive mirror
 help / color / mirror / Atom feed
From: "Shi, Yang A" <>
To: Daniel Vetter <>,
	"Liu, Chuansheng" <>
Cc: "'' (" 
	"" <>,
	"" <>
Subject: RE: [Patch 0/1]drm_irq: Introducing the irq_thread support
Date: Wed, 5 Sep 2012 15:12:39 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20120905132724.GC5357@phenom.ffwll.local>

Hi Vetter:

    Do you mean we can just not use drm_irq_install, and make request_irq in our kernel driver pre-install or post-install interface?

Best Regards.
Yang Shi

PSI,System Integration, SH

-----Original Message-----
From: Daniel Vetter [] On Behalf Of Daniel Vetter
Sent: Wednesday, September 05, 2012 9:27 PM
To: Liu, Chuansheng
Cc: '' (;;;; Shi, Yang A
Subject: Re: [Patch 0/1]drm_irq: Introducing the irq_thread support

On Wed, Sep 05, 2012 at 01:53:44AM +0000, Liu, Chuansheng wrote:
> This patch is for introducing the irq thread support in drm_irq.
> Why we need irq thread in drm_irq code?
> In our GPU system, the gpu interrupt handler need some time even > 1ms 
> to finish, in that case, the whole system will stay in irq disable status. One case is:
> when audio is playing, it sometimes effects the audio quality.
> So we have to introduce the irq thread in drm_irq, it can help us move 
> some heavy work into irq thread and other irq interrupts can be handled in time. Also the IRQF_ONESHOT is helpful for irq thread.
> Include one patch:
> [PATCH 01/1] drm_irq-Introducing-the-irq_thread-support

For a kms drm driver (and tbh, doing a non-kms driver today is not a great idea), there's no reason to use the drm_irq_install/_unistall helpers.

So if you driver has special needs wrt irq handling that don't neatly fit what the drm_irq stuff provides, simply don't use it - all the generic code that's there is just to keep non-kms userspace going.

Yours, Daniel
Daniel Vetter
Mobile: +41 (0)79 365 57 48

  reply	other threads:[~2012-09-05 15:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05  1:53 [Patch 0/1]drm_irq: Introducing the irq_thread support Liu, Chuansheng
2012-09-05 12:49 ` Alan Cox
2012-09-06  0:42   ` Liu, Chuansheng
2012-09-06  7:39     ` Daniel Vetter
2012-09-05 13:27 ` Daniel Vetter
2012-09-05 15:12   ` Shi, Yang A [this message]
2012-09-05 15:32     ` Daniel Vetter
2012-09-06  0:54       ` Liu, Chuansheng
2012-09-05 15:47   ` Rob Clark
2012-09-06  0:48   ` Liu, Chuansheng
2012-10-11 12:07   ` Laurent Pinchart
2012-10-11 13:19     ` Rob Clark
2012-10-11 15:18       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).