* [PATCH] drm/msm: Add MSM_SUBMIT_BO_NO_IMPLICIT @ 2022-12-06 19:21 Rob Clark 2022-12-07 10:15 ` Lucas Stach 2023-01-05 12:49 ` Daniel Vetter 0 siblings, 2 replies; 6+ messages in thread From: Rob Clark @ 2022-12-06 19:21 UTC (permalink / raw) To: dri-devel Cc: freedreno, linux-arm-msm, Chia-I Wu, Rob Clark, Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul, David Airlie, Daniel Vetter, open list From: Rob Clark <robdclark@chromium.org> In cases where implicit sync is used, it is still useful (for things like sub-allocation, etc) to allow userspace to opt-out of implicit sync on per-BO basis. Signed-off-by: Rob Clark <robdclark@chromium.org> --- drivers/gpu/drm/msm/msm_drv.c | 3 ++- drivers/gpu/drm/msm/msm_gem_submit.c | 11 +++++++++++ include/uapi/drm/msm_drm.h | 4 +++- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 017a512982a2..e0e1199a822f 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -45,9 +45,10 @@ * - 1.7.0 - Add MSM_PARAM_SUSPENDS to access suspend count * - 1.8.0 - Add MSM_BO_CACHED_COHERENT for supported GPUs (a6xx) * - 1.9.0 - Add MSM_SUBMIT_FENCE_SN_IN + * - 1.10.0 - Add MSM_SUBMIT_BO_NO_IMPLICIT */ #define MSM_VERSION_MAJOR 1 -#define MSM_VERSION_MINOR 9 +#define MSM_VERSION_MINOR 10 #define MSM_VERSION_PATCHLEVEL 0 static const struct drm_mode_config_funcs mode_config_funcs = { diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c index eb3536e3d66a..8bad07a04f85 100644 --- a/drivers/gpu/drm/msm/msm_gem_submit.c +++ b/drivers/gpu/drm/msm/msm_gem_submit.c @@ -334,9 +334,20 @@ static int submit_fence_sync(struct msm_gem_submit *submit, bool no_implicit) if (ret) return ret; + /* If userspace has determined that explicit fencing is + * used, it can disable implicit sync on the entire + * submit: + */ if (no_implicit) continue; + /* Otherwise userspace can ask for implicit sync to be + * disabled on specific buffers. This is useful for internal + * usermode driver managed buffers, suballocation, etc. + */ + if (submit->bos[i].flags & MSM_SUBMIT_BO_NO_IMPLICIT) + continue; + ret = drm_sched_job_add_implicit_dependencies(&submit->base, obj, write); diff --git a/include/uapi/drm/msm_drm.h b/include/uapi/drm/msm_drm.h index f54b48ef6a2d..329100016e7c 100644 --- a/include/uapi/drm/msm_drm.h +++ b/include/uapi/drm/msm_drm.h @@ -222,10 +222,12 @@ struct drm_msm_gem_submit_cmd { #define MSM_SUBMIT_BO_READ 0x0001 #define MSM_SUBMIT_BO_WRITE 0x0002 #define MSM_SUBMIT_BO_DUMP 0x0004 +#define MSM_SUBMIT_BO_NO_IMPLICIT 0x0008 #define MSM_SUBMIT_BO_FLAGS (MSM_SUBMIT_BO_READ | \ MSM_SUBMIT_BO_WRITE | \ - MSM_SUBMIT_BO_DUMP) + MSM_SUBMIT_BO_DUMP | \ + MSM_SUBMIT_BO_NO_IMPLICIT) struct drm_msm_gem_submit_bo { __u32 flags; /* in, mask of MSM_SUBMIT_BO_x */ -- 2.38.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/msm: Add MSM_SUBMIT_BO_NO_IMPLICIT 2022-12-06 19:21 [PATCH] drm/msm: Add MSM_SUBMIT_BO_NO_IMPLICIT Rob Clark @ 2022-12-07 10:15 ` Lucas Stach 2022-12-07 14:46 ` Rob Clark 2023-01-05 12:49 ` Daniel Vetter 1 sibling, 1 reply; 6+ messages in thread From: Lucas Stach @ 2022-12-07 10:15 UTC (permalink / raw) To: Rob Clark, dri-devel Cc: Rob Clark, linux-arm-msm, Abhinav Kumar, open list, Sean Paul, Dmitry Baryshkov, freedreno Hi Rob, Am Dienstag, dem 06.12.2022 um 11:21 -0800 schrieb Rob Clark: > From: Rob Clark <robdclark@chromium.org> > > In cases where implicit sync is used, it is still useful (for things > like sub-allocation, etc) to allow userspace to opt-out of implicit > sync on per-BO basis. > Out of curiosity and because I have been thinking about something like that for etnaviv for while: do you only use this for immutable buffers or do you have some kind of userspace fencing in place for the suballocated buffers? Regards, Lucas > Signed-off-by: Rob Clark <robdclark@chromium.org> > --- > drivers/gpu/drm/msm/msm_drv.c | 3 ++- > drivers/gpu/drm/msm/msm_gem_submit.c | 11 +++++++++++ > include/uapi/drm/msm_drm.h | 4 +++- > 3 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 017a512982a2..e0e1199a822f 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -45,9 +45,10 @@ > * - 1.7.0 - Add MSM_PARAM_SUSPENDS to access suspend count > * - 1.8.0 - Add MSM_BO_CACHED_COHERENT for supported GPUs (a6xx) > * - 1.9.0 - Add MSM_SUBMIT_FENCE_SN_IN > + * - 1.10.0 - Add MSM_SUBMIT_BO_NO_IMPLICIT > */ > #define MSM_VERSION_MAJOR 1 > -#define MSM_VERSION_MINOR 9 > +#define MSM_VERSION_MINOR 10 > #define MSM_VERSION_PATCHLEVEL 0 > > static const struct drm_mode_config_funcs mode_config_funcs = { > diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c > index eb3536e3d66a..8bad07a04f85 100644 > --- a/drivers/gpu/drm/msm/msm_gem_submit.c > +++ b/drivers/gpu/drm/msm/msm_gem_submit.c > @@ -334,9 +334,20 @@ static int submit_fence_sync(struct msm_gem_submit *submit, bool no_implicit) > if (ret) > return ret; > > + /* If userspace has determined that explicit fencing is > + * used, it can disable implicit sync on the entire > + * submit: > + */ > if (no_implicit) > continue; > > + /* Otherwise userspace can ask for implicit sync to be > + * disabled on specific buffers. This is useful for internal > + * usermode driver managed buffers, suballocation, etc. > + */ > + if (submit->bos[i].flags & MSM_SUBMIT_BO_NO_IMPLICIT) > + continue; > + > ret = drm_sched_job_add_implicit_dependencies(&submit->base, > obj, > write); > diff --git a/include/uapi/drm/msm_drm.h b/include/uapi/drm/msm_drm.h > index f54b48ef6a2d..329100016e7c 100644 > --- a/include/uapi/drm/msm_drm.h > +++ b/include/uapi/drm/msm_drm.h > @@ -222,10 +222,12 @@ struct drm_msm_gem_submit_cmd { > #define MSM_SUBMIT_BO_READ 0x0001 > #define MSM_SUBMIT_BO_WRITE 0x0002 > #define MSM_SUBMIT_BO_DUMP 0x0004 > +#define MSM_SUBMIT_BO_NO_IMPLICIT 0x0008 > > #define MSM_SUBMIT_BO_FLAGS (MSM_SUBMIT_BO_READ | \ > MSM_SUBMIT_BO_WRITE | \ > - MSM_SUBMIT_BO_DUMP) > + MSM_SUBMIT_BO_DUMP | \ > + MSM_SUBMIT_BO_NO_IMPLICIT) > > struct drm_msm_gem_submit_bo { > __u32 flags; /* in, mask of MSM_SUBMIT_BO_x */ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/msm: Add MSM_SUBMIT_BO_NO_IMPLICIT 2022-12-07 10:15 ` Lucas Stach @ 2022-12-07 14:46 ` Rob Clark 0 siblings, 0 replies; 6+ messages in thread From: Rob Clark @ 2022-12-07 14:46 UTC (permalink / raw) To: Lucas Stach Cc: dri-devel, Rob Clark, linux-arm-msm, Abhinav Kumar, open list, Sean Paul, Dmitry Baryshkov, freedreno On Wed, Dec 7, 2022 at 2:15 AM Lucas Stach <l.stach@pengutronix.de> wrote: > > Hi Rob, > > Am Dienstag, dem 06.12.2022 um 11:21 -0800 schrieb Rob Clark: > > From: Rob Clark <robdclark@chromium.org> > > > > In cases where implicit sync is used, it is still useful (for things > > like sub-allocation, etc) to allow userspace to opt-out of implicit > > sync on per-BO basis. > > > Out of curiosity and because I have been thinking about something like > that for etnaviv for while: do you only use this for immutable buffers > or do you have some kind of userspace fencing in place for the > suballocated buffers? yup, userspace fences.. which is a thing you'd really want for doing suballocation BR, -R > > Regards, > Lucas > > > Signed-off-by: Rob Clark <robdclark@chromium.org> > > --- > > drivers/gpu/drm/msm/msm_drv.c | 3 ++- > > drivers/gpu/drm/msm/msm_gem_submit.c | 11 +++++++++++ > > include/uapi/drm/msm_drm.h | 4 +++- > > 3 files changed, 16 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > > index 017a512982a2..e0e1199a822f 100644 > > --- a/drivers/gpu/drm/msm/msm_drv.c > > +++ b/drivers/gpu/drm/msm/msm_drv.c > > @@ -45,9 +45,10 @@ > > * - 1.7.0 - Add MSM_PARAM_SUSPENDS to access suspend count > > * - 1.8.0 - Add MSM_BO_CACHED_COHERENT for supported GPUs (a6xx) > > * - 1.9.0 - Add MSM_SUBMIT_FENCE_SN_IN > > + * - 1.10.0 - Add MSM_SUBMIT_BO_NO_IMPLICIT > > */ > > #define MSM_VERSION_MAJOR 1 > > -#define MSM_VERSION_MINOR 9 > > +#define MSM_VERSION_MINOR 10 > > #define MSM_VERSION_PATCHLEVEL 0 > > > > static const struct drm_mode_config_funcs mode_config_funcs = { > > diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c > > index eb3536e3d66a..8bad07a04f85 100644 > > --- a/drivers/gpu/drm/msm/msm_gem_submit.c > > +++ b/drivers/gpu/drm/msm/msm_gem_submit.c > > @@ -334,9 +334,20 @@ static int submit_fence_sync(struct msm_gem_submit *submit, bool no_implicit) > > if (ret) > > return ret; > > > > + /* If userspace has determined that explicit fencing is > > + * used, it can disable implicit sync on the entire > > + * submit: > > + */ > > if (no_implicit) > > continue; > > > > + /* Otherwise userspace can ask for implicit sync to be > > + * disabled on specific buffers. This is useful for internal > > + * usermode driver managed buffers, suballocation, etc. > > + */ > > + if (submit->bos[i].flags & MSM_SUBMIT_BO_NO_IMPLICIT) > > + continue; > > + > > ret = drm_sched_job_add_implicit_dependencies(&submit->base, > > obj, > > write); > > diff --git a/include/uapi/drm/msm_drm.h b/include/uapi/drm/msm_drm.h > > index f54b48ef6a2d..329100016e7c 100644 > > --- a/include/uapi/drm/msm_drm.h > > +++ b/include/uapi/drm/msm_drm.h > > @@ -222,10 +222,12 @@ struct drm_msm_gem_submit_cmd { > > #define MSM_SUBMIT_BO_READ 0x0001 > > #define MSM_SUBMIT_BO_WRITE 0x0002 > > #define MSM_SUBMIT_BO_DUMP 0x0004 > > +#define MSM_SUBMIT_BO_NO_IMPLICIT 0x0008 > > > > #define MSM_SUBMIT_BO_FLAGS (MSM_SUBMIT_BO_READ | \ > > MSM_SUBMIT_BO_WRITE | \ > > - MSM_SUBMIT_BO_DUMP) > > + MSM_SUBMIT_BO_DUMP | \ > > + MSM_SUBMIT_BO_NO_IMPLICIT) > > > > struct drm_msm_gem_submit_bo { > > __u32 flags; /* in, mask of MSM_SUBMIT_BO_x */ > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/msm: Add MSM_SUBMIT_BO_NO_IMPLICIT 2022-12-06 19:21 [PATCH] drm/msm: Add MSM_SUBMIT_BO_NO_IMPLICIT Rob Clark 2022-12-07 10:15 ` Lucas Stach @ 2023-01-05 12:49 ` Daniel Vetter 2023-01-05 14:51 ` Rob Clark 1 sibling, 1 reply; 6+ messages in thread From: Daniel Vetter @ 2023-01-05 12:49 UTC (permalink / raw) To: Rob Clark Cc: dri-devel, freedreno, linux-arm-msm, Chia-I Wu, Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul, David Airlie, Daniel Vetter, open list On Tue, Dec 06, 2022 at 11:21:23AM -0800, Rob Clark wrote: > From: Rob Clark <robdclark@chromium.org> > > In cases where implicit sync is used, it is still useful (for things > like sub-allocation, etc) to allow userspace to opt-out of implicit > sync on per-BO basis. > > Signed-off-by: Rob Clark <robdclark@chromium.org> > --- > drivers/gpu/drm/msm/msm_drv.c | 3 ++- > drivers/gpu/drm/msm/msm_gem_submit.c | 11 +++++++++++ > include/uapi/drm/msm_drm.h | 4 +++- > 3 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 017a512982a2..e0e1199a822f 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -45,9 +45,10 @@ > * - 1.7.0 - Add MSM_PARAM_SUSPENDS to access suspend count > * - 1.8.0 - Add MSM_BO_CACHED_COHERENT for supported GPUs (a6xx) > * - 1.9.0 - Add MSM_SUBMIT_FENCE_SN_IN > + * - 1.10.0 - Add MSM_SUBMIT_BO_NO_IMPLICIT > */ > #define MSM_VERSION_MAJOR 1 > -#define MSM_VERSION_MINOR 9 > +#define MSM_VERSION_MINOR 10 > #define MSM_VERSION_PATCHLEVEL 0 > > static const struct drm_mode_config_funcs mode_config_funcs = { > diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c > index eb3536e3d66a..8bad07a04f85 100644 > --- a/drivers/gpu/drm/msm/msm_gem_submit.c > +++ b/drivers/gpu/drm/msm/msm_gem_submit.c > @@ -334,9 +334,20 @@ static int submit_fence_sync(struct msm_gem_submit *submit, bool no_implicit) > if (ret) > return ret; > > + /* If userspace has determined that explicit fencing is > + * used, it can disable implicit sync on the entire > + * submit: > + */ > if (no_implicit) > continue; > > + /* Otherwise userspace can ask for implicit sync to be > + * disabled on specific buffers. This is useful for internal > + * usermode driver managed buffers, suballocation, etc. > + */ > + if (submit->bos[i].flags & MSM_SUBMIT_BO_NO_IMPLICIT) > + continue; > + > ret = drm_sched_job_add_implicit_dependencies(&submit->base, Won't this break shrinkers and fun stuff like that? It's why we added the new USAGE_OTHER fence slot at least, and also why I wonder whether we shouldn't push this into the helper to make the right call. Every driver kinda needs the same wheel. -Daniel > obj, > write); > diff --git a/include/uapi/drm/msm_drm.h b/include/uapi/drm/msm_drm.h > index f54b48ef6a2d..329100016e7c 100644 > --- a/include/uapi/drm/msm_drm.h > +++ b/include/uapi/drm/msm_drm.h > @@ -222,10 +222,12 @@ struct drm_msm_gem_submit_cmd { > #define MSM_SUBMIT_BO_READ 0x0001 > #define MSM_SUBMIT_BO_WRITE 0x0002 > #define MSM_SUBMIT_BO_DUMP 0x0004 > +#define MSM_SUBMIT_BO_NO_IMPLICIT 0x0008 > > #define MSM_SUBMIT_BO_FLAGS (MSM_SUBMIT_BO_READ | \ > MSM_SUBMIT_BO_WRITE | \ > - MSM_SUBMIT_BO_DUMP) > + MSM_SUBMIT_BO_DUMP | \ > + MSM_SUBMIT_BO_NO_IMPLICIT) > > struct drm_msm_gem_submit_bo { > __u32 flags; /* in, mask of MSM_SUBMIT_BO_x */ > -- > 2.38.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/msm: Add MSM_SUBMIT_BO_NO_IMPLICIT 2023-01-05 12:49 ` Daniel Vetter @ 2023-01-05 14:51 ` Rob Clark 2023-01-05 14:52 ` Daniel Vetter 0 siblings, 1 reply; 6+ messages in thread From: Rob Clark @ 2023-01-05 14:51 UTC (permalink / raw) To: Rob Clark, dri-devel, freedreno, linux-arm-msm, Chia-I Wu, Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul, David Airlie, open list Cc: Daniel Vetter On Thu, Jan 5, 2023 at 4:49 AM Daniel Vetter <daniel@ffwll.ch> wrote: > > On Tue, Dec 06, 2022 at 11:21:23AM -0800, Rob Clark wrote: > > From: Rob Clark <robdclark@chromium.org> > > > > In cases where implicit sync is used, it is still useful (for things > > like sub-allocation, etc) to allow userspace to opt-out of implicit > > sync on per-BO basis. > > > > Signed-off-by: Rob Clark <robdclark@chromium.org> > > --- > > drivers/gpu/drm/msm/msm_drv.c | 3 ++- > > drivers/gpu/drm/msm/msm_gem_submit.c | 11 +++++++++++ > > include/uapi/drm/msm_drm.h | 4 +++- > > 3 files changed, 16 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > > index 017a512982a2..e0e1199a822f 100644 > > --- a/drivers/gpu/drm/msm/msm_drv.c > > +++ b/drivers/gpu/drm/msm/msm_drv.c > > @@ -45,9 +45,10 @@ > > * - 1.7.0 - Add MSM_PARAM_SUSPENDS to access suspend count > > * - 1.8.0 - Add MSM_BO_CACHED_COHERENT for supported GPUs (a6xx) > > * - 1.9.0 - Add MSM_SUBMIT_FENCE_SN_IN > > + * - 1.10.0 - Add MSM_SUBMIT_BO_NO_IMPLICIT > > */ > > #define MSM_VERSION_MAJOR 1 > > -#define MSM_VERSION_MINOR 9 > > +#define MSM_VERSION_MINOR 10 > > #define MSM_VERSION_PATCHLEVEL 0 > > > > static const struct drm_mode_config_funcs mode_config_funcs = { > > diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c > > index eb3536e3d66a..8bad07a04f85 100644 > > --- a/drivers/gpu/drm/msm/msm_gem_submit.c > > +++ b/drivers/gpu/drm/msm/msm_gem_submit.c > > @@ -334,9 +334,20 @@ static int submit_fence_sync(struct msm_gem_submit *submit, bool no_implicit) > > if (ret) > > return ret; > > > > + /* If userspace has determined that explicit fencing is > > + * used, it can disable implicit sync on the entire > > + * submit: > > + */ > > if (no_implicit) > > continue; > > > > + /* Otherwise userspace can ask for implicit sync to be > > + * disabled on specific buffers. This is useful for internal > > + * usermode driver managed buffers, suballocation, etc. > > + */ > > + if (submit->bos[i].flags & MSM_SUBMIT_BO_NO_IMPLICIT) > > + continue; > > + > > ret = drm_sched_job_add_implicit_dependencies(&submit->base, > > Won't this break shrinkers and fun stuff like that? It's why we added the > new USAGE_OTHER fence slot at least, and also why I wonder whether we Only if the entire explicit sync path was busted.. My daily driver for email/docs/meet/chat/corpstuff is a 4G device and CrOS is all explicit sync.. I would have found out rapidly and dramatically if it was busted :-P But seriously, this doesn't change what fences we attach to buffers, only what the sched job waits on > shouldn't push this into the helper to make the right call. Every driver > kinda needs the same wheel. We kinda already have moved everything we can (with the current driver-specific-uabi model) to helpers, what is left is driver specific ioctl parsing. We absolutely should take a step back and re-evaluate this before anyone else adds a new submit/execbuf ioctl. For example, the driver specific ioctl could just have a pointer to a drm_gem_submit_bo_table type structure, and then we could move the whole thing to a helper. Short of breaking the submit ioctl up (which a uring type uabi would let us do), I think the next best thing is to split out common cross-driver structs for common parts of submit/execbuf. BR, -R > -Daniel > > > obj, > > write); > > diff --git a/include/uapi/drm/msm_drm.h b/include/uapi/drm/msm_drm.h > > index f54b48ef6a2d..329100016e7c 100644 > > --- a/include/uapi/drm/msm_drm.h > > +++ b/include/uapi/drm/msm_drm.h > > @@ -222,10 +222,12 @@ struct drm_msm_gem_submit_cmd { > > #define MSM_SUBMIT_BO_READ 0x0001 > > #define MSM_SUBMIT_BO_WRITE 0x0002 > > #define MSM_SUBMIT_BO_DUMP 0x0004 > > +#define MSM_SUBMIT_BO_NO_IMPLICIT 0x0008 > > > > #define MSM_SUBMIT_BO_FLAGS (MSM_SUBMIT_BO_READ | \ > > MSM_SUBMIT_BO_WRITE | \ > > - MSM_SUBMIT_BO_DUMP) > > + MSM_SUBMIT_BO_DUMP | \ > > + MSM_SUBMIT_BO_NO_IMPLICIT) > > > > struct drm_msm_gem_submit_bo { > > __u32 flags; /* in, mask of MSM_SUBMIT_BO_x */ > > -- > > 2.38.1 > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/msm: Add MSM_SUBMIT_BO_NO_IMPLICIT 2023-01-05 14:51 ` Rob Clark @ 2023-01-05 14:52 ` Daniel Vetter 0 siblings, 0 replies; 6+ messages in thread From: Daniel Vetter @ 2023-01-05 14:52 UTC (permalink / raw) To: Rob Clark Cc: dri-devel, freedreno, linux-arm-msm, Chia-I Wu, Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul, David Airlie, open list On Thu, 5 Jan 2023 at 15:51, Rob Clark <robdclark@gmail.com> wrote: > > On Thu, Jan 5, 2023 at 4:49 AM Daniel Vetter <daniel@ffwll.ch> wrote: > > > > On Tue, Dec 06, 2022 at 11:21:23AM -0800, Rob Clark wrote: > > > From: Rob Clark <robdclark@chromium.org> > > > > > > In cases where implicit sync is used, it is still useful (for things > > > like sub-allocation, etc) to allow userspace to opt-out of implicit > > > sync on per-BO basis. > > > > > > Signed-off-by: Rob Clark <robdclark@chromium.org> > > > --- > > > drivers/gpu/drm/msm/msm_drv.c | 3 ++- > > > drivers/gpu/drm/msm/msm_gem_submit.c | 11 +++++++++++ > > > include/uapi/drm/msm_drm.h | 4 +++- > > > 3 files changed, 16 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > > > index 017a512982a2..e0e1199a822f 100644 > > > --- a/drivers/gpu/drm/msm/msm_drv.c > > > +++ b/drivers/gpu/drm/msm/msm_drv.c > > > @@ -45,9 +45,10 @@ > > > * - 1.7.0 - Add MSM_PARAM_SUSPENDS to access suspend count > > > * - 1.8.0 - Add MSM_BO_CACHED_COHERENT for supported GPUs (a6xx) > > > * - 1.9.0 - Add MSM_SUBMIT_FENCE_SN_IN > > > + * - 1.10.0 - Add MSM_SUBMIT_BO_NO_IMPLICIT > > > */ > > > #define MSM_VERSION_MAJOR 1 > > > -#define MSM_VERSION_MINOR 9 > > > +#define MSM_VERSION_MINOR 10 > > > #define MSM_VERSION_PATCHLEVEL 0 > > > > > > static const struct drm_mode_config_funcs mode_config_funcs = { > > > diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c > > > index eb3536e3d66a..8bad07a04f85 100644 > > > --- a/drivers/gpu/drm/msm/msm_gem_submit.c > > > +++ b/drivers/gpu/drm/msm/msm_gem_submit.c > > > @@ -334,9 +334,20 @@ static int submit_fence_sync(struct msm_gem_submit *submit, bool no_implicit) > > > if (ret) > > > return ret; > > > > > > + /* If userspace has determined that explicit fencing is > > > + * used, it can disable implicit sync on the entire > > > + * submit: > > > + */ > > > if (no_implicit) > > > continue; > > > > > > + /* Otherwise userspace can ask for implicit sync to be > > > + * disabled on specific buffers. This is useful for internal > > > + * usermode driver managed buffers, suballocation, etc. > > > + */ > > > + if (submit->bos[i].flags & MSM_SUBMIT_BO_NO_IMPLICIT) > > > + continue; > > > + > > > ret = drm_sched_job_add_implicit_dependencies(&submit->base, > > > > Won't this break shrinkers and fun stuff like that? It's why we added the > > new USAGE_OTHER fence slot at least, and also why I wonder whether we > > Only if the entire explicit sync path was busted.. My daily driver for > email/docs/meet/chat/corpstuff is a 4G device and CrOS is all explicit > sync.. I would have found out rapidly and dramatically if it was > busted :-P > > But seriously, this doesn't change what fences we attach to buffers, > only what the sched job waits on Oh I'm a silly one :-) > > shouldn't push this into the helper to make the right call. Every driver > > kinda needs the same wheel. > > We kinda already have moved everything we can (with the current > driver-specific-uabi model) to helpers, what is left is driver > specific ioctl parsing. We absolutely should take a step back and > re-evaluate this before anyone else adds a new submit/execbuf ioctl. > For example, the driver specific ioctl could just have a pointer to a > drm_gem_submit_bo_table type structure, and then we could move the > whole thing to a helper. Short of breaking the submit ioctl up (which > a uring type uabi would let us do), I think the next best thing is to > split out common cross-driver structs for common parts of > submit/execbuf. Yeah I thought this was the "attach fence to dma_resv" side of things. This here is I think fine as a pattern, unless we build some kind of outright submit ioctl helpers that take care of everything. -Daniel > > BR, > -R > > > -Daniel > > > > > obj, > > > write); > > > diff --git a/include/uapi/drm/msm_drm.h b/include/uapi/drm/msm_drm.h > > > index f54b48ef6a2d..329100016e7c 100644 > > > --- a/include/uapi/drm/msm_drm.h > > > +++ b/include/uapi/drm/msm_drm.h > > > @@ -222,10 +222,12 @@ struct drm_msm_gem_submit_cmd { > > > #define MSM_SUBMIT_BO_READ 0x0001 > > > #define MSM_SUBMIT_BO_WRITE 0x0002 > > > #define MSM_SUBMIT_BO_DUMP 0x0004 > > > +#define MSM_SUBMIT_BO_NO_IMPLICIT 0x0008 > > > > > > #define MSM_SUBMIT_BO_FLAGS (MSM_SUBMIT_BO_READ | \ > > > MSM_SUBMIT_BO_WRITE | \ > > > - MSM_SUBMIT_BO_DUMP) > > > + MSM_SUBMIT_BO_DUMP | \ > > > + MSM_SUBMIT_BO_NO_IMPLICIT) > > > > > > struct drm_msm_gem_submit_bo { > > > __u32 flags; /* in, mask of MSM_SUBMIT_BO_x */ > > > -- > > > 2.38.1 > > > > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > http://blog.ffwll.ch -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-05 14:53 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-12-06 19:21 [PATCH] drm/msm: Add MSM_SUBMIT_BO_NO_IMPLICIT Rob Clark 2022-12-07 10:15 ` Lucas Stach 2022-12-07 14:46 ` Rob Clark 2023-01-05 12:49 ` Daniel Vetter 2023-01-05 14:51 ` Rob Clark 2023-01-05 14:52 ` Daniel Vetter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).