From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sean Paul <seanpaul@chromium.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fbcon: mark dummy functions 'inline'
Date: Wed, 2 Aug 2017 12:02:50 +0200 [thread overview]
Message-ID: <CAKMK7uHkyCh+2rUaV_4k5gyGWfECWnYcSh6BMnDDBqdPgNYF8Q@mail.gmail.com> (raw)
In-Reply-To: <20170802093826.3703737-1-arnd@arndb.de>
On Wed, Aug 2, 2017 at 11:38 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly introduced fb_console_init/exit declarations have a
> dummy alternative that is marked 'static' in the header but not
> inline, leading to a warning whenever the header gets included:
>
> In file included from drivers/video/fbdev/core/fbmem.c:35:0:
> include/linux/fbcon.h:9:13: error: 'fb_console_exit' defined but not used [-Werror=unused-function]
>
> This adds the intended 'inline'.
>
> Fixes: 6104c37094e7 ("fbcon: Make fbcon a built-time depency for fbdev")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> include/linux/fbcon.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/fbcon.h b/include/linux/fbcon.h
> index 0fac6305d51c..f68a7db14165 100644
> --- a/include/linux/fbcon.h
> +++ b/include/linux/fbcon.h
> @@ -5,8 +5,8 @@
> void __init fb_console_init(void);
> void __exit fb_console_exit(void);
> #else
> -static void fb_console_init(void) {}
> -static void fb_console_exit(void) {}
> +static inline void fb_console_init(void) {}
> +static inline void fb_console_exit(void) {}
> #endif
>
> #endif /* _LINUX_FBCON_H */
> --
> 2.9.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2017-08-02 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170802093851epcas3p174be8da865110e7586d3f51da22fba51@epcas3p1.samsung.com>
2017-08-02 9:38 ` [PATCH] fbcon: mark dummy functions 'inline' Arnd Bergmann
2017-08-02 10:02 ` Daniel Vetter [this message]
2017-08-07 15:11 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKMK7uHkyCh+2rUaV_4k5gyGWfECWnYcSh6BMnDDBqdPgNYF8Q@mail.gmail.com \
--to=daniel.vetter@ffwll.ch \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).