From: Daniel Colascione <dancol@google.com>
To: Tycho Andersen <tycho@tycho.ws>
Cc: Christian Brauner <christian@brauner.io>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Jann Horn <jannh@google.com>, Andy Lutomirski <luto@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>, Aleksa Sarai <cyphar@cyphar.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
Tim Murray <timmurray@google.com>,
linux-man <linux-man@vger.kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v1 2/2] signal: add procfd_signal() syscall
Date: Mon, 19 Nov 2018 14:49:22 -0800 [thread overview]
Message-ID: <CAKOZuetQDziWeRLydHbDNv1abGM3LyF=WohLFvbzmtdT_+nBdg@mail.gmail.com> (raw)
In-Reply-To: <20181119223954.GA4992@cisco>
On Mon, Nov 19, 2018 at 2:40 PM Tycho Andersen <tycho@tycho.ws> wrote:
> Can I just register an objection here that I think using a syscall
> just for this is silly?
Yes, you can argue that the bikeshed should be ioctl-colored and not
syscall-colored.
> My understanding is that the concern is that some code might do:
>
> unknown_fd = recv_fd();
> ioctl(unknown_fd, SOME_IOCTL, NULL); // where SOME_IOCTL == PROC_FD_KILL
> // whoops, unknown_fd was a procfd and we killed a task!
>
> In my experience when writing fd sending/receiving code, the sender and
> receiver are fairly tightly coupled. Has anyone ever actually fixed a
> bug where they had an fd that they lost track of what "type" it was
> and screwed up like this? It seems completely theoretical to me.
Yes, I have fixed bugs of this form.
> The ioctl() approach has the benefit of being extensible.
The system call table is also extensible. ioctl is for when a given
piece of functionality *can't* realistically get its own system call
because it's separated from the main kernel somehow. procfs is a core
part of the kernel, so we can and should expose interfaces to it using
system calls.
> Adding a
> syscall means that everyone has to do all the boilerplate for each new
> pid op in the kernel, arches, libc, strace, etc.
These tools also care about ioctls. Adding a system call is a pain,
but the solution is to make adding system calls less of a pain, not to
permanently make the Linux ABI worse.
next prev parent reply other threads:[~2018-11-19 22:49 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 10:32 [PATCH v1 0/2] proc: allow signaling processes via file descriptors Christian Brauner
2018-11-19 10:32 ` [PATCH v1 1/2] proc: get process file descriptor from /proc/<pid> Christian Brauner
2018-11-19 15:32 ` Andy Lutomirski
2018-11-19 18:20 ` Christian Brauner
2018-11-19 10:32 ` [PATCH v1 2/2] signal: add procfd_signal() syscall Christian Brauner
2018-11-19 15:45 ` Andy Lutomirski
2018-11-19 15:57 ` Daniel Colascione
2018-11-19 18:39 ` Christian Brauner
2018-11-19 15:59 ` Daniel Colascione
2018-11-19 18:29 ` Christian Brauner
2018-11-19 19:02 ` Eric W. Biederman
2018-11-19 19:31 ` Christian Brauner
2018-11-19 19:39 ` Daniel Colascione
2018-11-19 17:10 ` Eugene Syromiatnikov
2018-11-19 18:23 ` Christian Brauner
2018-11-19 17:14 ` Eugene Syromiatnikov
2018-11-19 20:28 ` Aleksa Sarai
2018-11-19 20:55 ` Christian Brauner
2018-11-19 21:13 ` Christian Brauner
2018-11-19 21:18 ` Aleksa Sarai
2018-11-19 21:20 ` Christian Brauner
2018-11-19 21:21 ` Christian Brauner
2018-11-19 21:25 ` Aleksa Sarai
2018-11-19 21:26 ` Daniel Colascione
2018-11-19 21:36 ` Aleksa Sarai
2018-11-19 21:37 ` Christian Brauner
2018-11-19 21:41 ` Daniel Colascione
2018-11-20 4:59 ` Eric W. Biederman
2018-11-20 10:31 ` Christian Brauner
2018-11-21 21:39 ` Serge E. Hallyn
2018-11-19 21:23 ` Aleksa Sarai
2018-11-22 7:41 ` Serge E. Hallyn
2018-11-19 22:39 ` Tycho Andersen
2018-11-19 22:49 ` Daniel Colascione [this message]
2018-11-19 23:07 ` Tycho Andersen
2018-11-20 0:27 ` Andy Lutomirski
2018-11-20 0:32 ` Christian Brauner
2018-11-20 0:34 ` Andy Lutomirski
2018-11-20 0:49 ` Daniel Colascione
2018-11-22 7:48 ` Serge E. Hallyn
2018-11-19 23:35 ` kbuild test robot
2018-11-19 23:37 ` kbuild test robot
2018-11-19 23:45 ` Christian Brauner
2018-11-28 21:45 ` Joey Pabalinas
2018-11-28 22:05 ` Christian Brauner
2018-11-28 23:02 ` Joey Pabalinas
2018-11-19 10:32 ` [PATCH] procfd_signal.2: document procfd_signal syscall Christian Brauner
2018-11-20 13:29 ` Michael Kerrisk (man-pages)
2018-11-28 20:59 ` Florian Weimer
2018-11-28 21:12 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKOZuetQDziWeRLydHbDNv1abGM3LyF=WohLFvbzmtdT_+nBdg@mail.gmail.com' \
--to=dancol@google.com \
--cc=akpm@linux-foundation.org \
--cc=christian@brauner.io \
--cc=cyphar@cyphar.com \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=luto@kernel.org \
--cc=oleg@redhat.com \
--cc=serge@hallyn.com \
--cc=timmurray@google.com \
--cc=tycho@tycho.ws \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).