linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tordek <kedrot@gmail.com>
To: Oleg Drokin <oleg.drokin@intel.com>,
	lustre-devel@lists.lustre.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging/lustre: conrpc.c - fix sparse error: incompatible types in comparison expression (different address spaces)
Date: Fri, 5 May 2017 10:53:11 -0300	[thread overview]
Message-ID: <CAKUXR6Mo-3QR0PQGf_7Otx2S3imowZzBD0Xs=xAY-m_sdHGNaw@mail.gmail.com> (raw)
In-Reply-To: <20170505135129.14757-1-kedrot@gmail.com>

This patch makes a lot of new warnings pop up, because the error is
blocking the rest of the file from being processed.

On 5 May 2017 at 10:51, Guillermo O. Freschi <kedrot@gmail.com> wrote:
> Signed-off-by: Guillermo O. Freschi <kedrot@gmail.com>
> ---
>  drivers/staging/lustre/lnet/selftest/conrpc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/selftest/conrpc.c b/drivers/staging/lustre/lnet/selftest/conrpc.c
> index da36c55b86d3..f4578200994f 100644
> --- a/drivers/staging/lustre/lnet/selftest/conrpc.c
> +++ b/drivers/staging/lustre/lnet/selftest/conrpc.c
> @@ -487,7 +487,7 @@ lstcon_rpc_trans_interpreter(struct lstcon_rpc_trans *trans,
>                                    sizeof(struct list_head)))
>                         return -EFAULT;
>
> -               if (tmp.next == head_up)
> +               if ((struct list_head __user *)tmp.next == head_up)
>                         return 0;
>
>                 next = tmp.next;
> --
> 2.11.0
>

  reply	other threads:[~2017-05-05 13:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-05 13:51 [PATCH] drivers: staging/lustre: conrpc.c - fix sparse error: incompatible types in comparison expression (different address spaces) Guillermo O. Freschi
2017-05-05 13:53 ` Tordek [this message]
2017-06-01 21:42   ` Tordek
     [not found]   ` <CAKUXR6NiUCFbJjWdQYPU_CQ-wJovXR255ZnOwHRtU6OSrm5PZg@mail.gmail.com>
2017-06-02  4:08     ` [lustre-devel] " Dilger, Andreas
2017-06-02  5:15       ` Tordek
2017-06-07  9:15       ` [PATCH 1/2] " Guillermo O. Freschi
2017-06-07  9:15         ` [PATCH 2/2] drivers: staging/lustre: conrpc.c - fix sparse warning: warning: incorrect type in argument * " Guillermo O. Freschi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKUXR6Mo-3QR0PQGf_7Otx2S3imowZzBD0Xs=xAY-m_sdHGNaw@mail.gmail.com' \
    --to=kedrot@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).