From: "Guillermo O. Freschi" <kedrot@gmail.com>
To: Oleg Drokin <oleg.drokin@intel.com>,
lustre-devel@lists.lustre.org, linux-kernel@vger.kernel.org
Cc: "Guillermo O. Freschi" <kedrot@gmail.com>
Subject: [PATCH 2/2] drivers: staging/lustre: conrpc.c - fix sparse warning: warning: incorrect type in argument * (different address spaces)
Date: Wed, 7 Jun 2017 06:15:19 -0300 [thread overview]
Message-ID: <20170607091519.5248-2-kedrot@gmail.com> (raw)
In-Reply-To: <20170607091519.5248-1-kedrot@gmail.com>
The calls to `copy_to_user` suggest that `ent` is pointing to userspace
memory, but `ent` is missing the `__user` qualifier.
Signed-off-by: Guillermo O. Freschi <kedrot@gmail.com>
---
drivers/staging/lustre/lnet/selftest/conrpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/selftest/conrpc.c b/drivers/staging/lustre/lnet/selftest/conrpc.c
index f4578200994f..04a5d7e80151 100644
--- a/drivers/staging/lustre/lnet/selftest/conrpc.c
+++ b/drivers/staging/lustre/lnet/selftest/conrpc.c
@@ -469,7 +469,7 @@ lstcon_rpc_trans_interpreter(struct lstcon_rpc_trans *trans,
{
struct list_head tmp;
struct list_head __user *next;
- struct lstcon_rpc_ent *ent;
+ struct lstcon_rpc_ent __user *ent;
struct srpc_generic_reply *rep;
struct lstcon_rpc *crpc;
struct srpc_msg *msg;
--
2.11.0
prev parent reply other threads:[~2017-06-07 9:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 13:51 [PATCH] drivers: staging/lustre: conrpc.c - fix sparse error: incompatible types in comparison expression (different address spaces) Guillermo O. Freschi
2017-05-05 13:53 ` Tordek
2017-06-01 21:42 ` Tordek
[not found] ` <CAKUXR6NiUCFbJjWdQYPU_CQ-wJovXR255ZnOwHRtU6OSrm5PZg@mail.gmail.com>
2017-06-02 4:08 ` [lustre-devel] " Dilger, Andreas
2017-06-02 5:15 ` Tordek
2017-06-07 9:15 ` [PATCH 1/2] " Guillermo O. Freschi
2017-06-07 9:15 ` Guillermo O. Freschi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607091519.5248-2-kedrot@gmail.com \
--to=kedrot@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).