[PATCH] net: wireless: b43legacy: radio.c: Remove unused function

[PATCH] net: wireless: b43legacy: radio.c: Remove unused function

[Rickard Strandqvist]

Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/net/wireless/b43legacy/radio.c |   19 -------------------
 drivers/net/wireless/b43legacy/radio.h |    1 -
 2 files changed, 20 deletions(-)

diff --git a/drivers/net/wireless/b43legacy/radio.c b/drivers/net/wireless/b43legacy/radio.c
index 8961776..9501420 100644
--- a/drivers/net/wireless/b43legacy/radio.c
+++ b/drivers/net/wireless/b43legacy/radio.c
@@ -1743,25 +1743,6 @@ u16 freq_r3A_value(u16 frequency)
 	return value;
 }
 
-void b43legacy_radio_set_tx_iq(struct b43legacy_wldev *dev)
-{
-	static const u8 data_high[5] = { 0x00, 0x40, 0x80, 0x90, 0xD0 };
-	static const u8 data_low[5]  = { 0x00, 0x01, 0x05, 0x06, 0x0A };
-	u16 tmp = b43legacy_radio_read16(dev, 0x001E);
-	int i;
-	int j;
-
-	for (i = 0; i < 5; i++) {
-		for (j = 0; j < 5; j++) {
-			if (tmp == (data_high[i] | data_low[j])) {
-				b43legacy_phy_write(dev, 0x0069, (i - j) << 8 |
-						    0x00C0);
-				return;
-			}
-		}
-	}
-}
-
 int b43legacy_radio_selectchannel(struct b43legacy_wldev *dev,
 				  u8 channel,
 				  int synthetic_pu_workaround)
diff --git a/drivers/net/wireless/b43legacy/radio.h b/drivers/net/wireless/b43legacy/radio.h
index bccb3d7..dd2976d 100644
--- a/drivers/net/wireless/b43legacy/radio.h
+++ b/drivers/net/wireless/b43legacy/radio.h
@@ -92,7 +92,6 @@ void b43legacy_nrssi_hw_write(struct b43legacy_wldev *dev, u16 offset, s16 val);
 void b43legacy_nrssi_hw_update(struct b43legacy_wldev *dev, u16 val);
 void b43legacy_nrssi_mem_update(struct b43legacy_wldev *dev);
 
-void b43legacy_radio_set_tx_iq(struct b43legacy_wldev *dev);
 u16 b43legacy_radio_calibrationvalue(struct b43legacy_wldev *dev);
 
 #endif /* B43legacy_RADIO_H_ */
-- 
1.7.10.4

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

[Rafał Miłecki]

On 1 January 2015 at 16:46, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.

It seems to be for A-PHY based hardware (with 0x2060 radio id) which
is not handled by b43legacy. Should be safe to drop this code (we
won't likely need it).

Ack

-- 
Rafał

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

[Rafał Miłecki]

On 2 January 2015 at 13:05, Rafał Miłecki <zajec5@gmail.com> wrote:
> On 1 January 2015 at 16:46, Rickard Strandqvist
> <rickard_strandqvist@spectrumdigital.se> wrote:
>> Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere.
>>
>> This was partially found by using a static code analysis program called cppcheck.
>
> It seems to be for A-PHY based hardware (with 0x2060 radio id) which
> is not handled by b43legacy. Should be safe to drop this code (we
> won't likely need it).
>
> Ack

For future, we prefix patches with just a driver name. So this could
be simply called
b43legacy: radio.c: Remove unused function

-- 
Rafał

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

[Sedat Dilek]

On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki <zajec5@gmail.com> wrote:
> On 2 January 2015 at 13:05, Rafał Miłecki <zajec5@gmail.com> wrote:
>> On 1 January 2015 at 16:46, Rickard Strandqvist
>> <rickard_strandqvist@spectrumdigital.se> wrote:
>>> Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere.
>>>
>>> This was partially found by using a static code analysis program called cppcheck.
>>
>> It seems to be for A-PHY based hardware (with 0x2060 radio id) which
>> is not handled by b43legacy. Should be safe to drop this code (we
>> won't likely need it).
>>
>> Ack
>
> For future, we prefix patches with just a driver name. So this could
> be simply called
> b43legacy: radio.c: Remove unused function
>

Alternatively...

"b43legacy: Remove unused function in radio.c"

BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck
to get such stuff?

- Sedat -

[1] https://lkml.org/lkml/2015/1/2/51

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

[Rafał Miłecki]

On 2 January 2015 at 18:46, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> 2015-01-02 13:14 GMT+01:00 Sedat Dilek <sedat.dilek@gmail.com>:
>>
>> On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki <zajec5@gmail.com> wrote:
>> > On 2 January 2015 at 13:05, Rafał Miłecki <zajec5@gmail.com> wrote:
>> >> On 1 January 2015 at 16:46, Rickard Strandqvist
>> >> <rickard_strandqvist@spectrumdigital.se> wrote:
>> >>> Remove the function b43legacy_radio_set_tx_iq() that is not used
>> >>> anywhere.
>> >>>
>> >>> This was partially found by using a static code analysis program
>> >>> called cppcheck.
>> >>
>> >> It seems to be for A-PHY based hardware (with 0x2060 radio id) which
>> >> is not handled by b43legacy. Should be safe to drop this code (we
>> >> won't likely need it).
>> >>
>> >> Ack
>> >
>> > For future, we prefix patches with just a driver name. So this could
>> > be simply called
>> > b43legacy: radio.c: Remove unused function
>> >
>>
>> Alternatively...
>>
>> "b43legacy: Remove unused function in radio.c"
>>
>> BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck
>> to get such stuff?
>>
>> - Sedat -
>>
>> [1] https://lkml.org/lkml/2015/1/2/51
>
>
>
> Hi Rafal and Sedat
>
> Rafal do you mean I should remove the entire b43legacy part?

1) I gave you Ack for the changes
2) You could drop "net: wireless: " or better use something Sedat proposed

-- 
Rafał

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

[Sedat Dilek]

On Sat, Jan 3, 2015 at 1:28 PM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> 2015-01-02 22:34 GMT+01:00 Rafał Miłecki <zajec5@gmail.com>:
>>
>> On 2 January 2015 at 18:46, Rickard Strandqvist
>> <rickard_strandqvist@spectrumdigital.se> wrote:
>> > 2015-01-02 13:14 GMT+01:00 Sedat Dilek <sedat.dilek@gmail.com>:
>> >>
>> >> On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki <zajec5@gmail.com> wrote:
>> >> > On 2 January 2015 at 13:05, Rafał Miłecki <zajec5@gmail.com> wrote:
>> >> >> On 1 January 2015 at 16:46, Rickard Strandqvist
>> >> >> <rickard_strandqvist@spectrumdigital.se> wrote:
>> >> >>> Remove the function b43legacy_radio_set_tx_iq() that is not used
>> >> >>> anywhere.
>> >> >>>
>> >> >>> This was partially found by using a static code analysis program
>> >> >>> called cppcheck.
>> >> >>
>> >> >> It seems to be for A-PHY based hardware (with 0x2060 radio id) which
>> >> >> is not handled by b43legacy. Should be safe to drop this code (we
>> >> >> won't likely need it).
>> >> >>
>> >> >> Ack
>> >> >
>> >> > For future, we prefix patches with just a driver name. So this could
>> >> > be simply called
>> >> > b43legacy: radio.c: Remove unused function
>> >> >
>> >>
>> >> Alternatively...
>> >>
>> >> "b43legacy: Remove unused function in radio.c"
>> >>
>> >> BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck
>> >> to get such stuff?
>> >>
>> >> - Sedat -
>> >>
>> >> [1] https://lkml.org/lkml/2015/1/2/51
>> >
>> >
>> >
>> > Hi Rafal and Sedat
>> >
>> > Rafal do you mean I should remove the entire b43legacy part?
>>
>> 1) I gave you Ack for the changes
>> 2) You could drop "net: wireless: " or better use something Sedat proposed
>>
>> --
>> Rafał
>
>
>
> Hi
>
> Nice, yes I miss the Ack :)
>
> I just got one more complaining about my subject-line in "net: wireless: "
> I use some sed call for this, so it's easy to fix. I will now remove that
> part hereinafter.
> I check in Documentation/ but did not find any clear info for this.
>

The easiest way to make (sub)maintainers happy is to check the git-log...

$ git log --oneline /path/to/file

...and look how other contributors labeled their patches.

[1] is the 1st address to look at on how to submit patches to Linux-kernel.
To promote the good work of Greg, see [2,3] for a video and tutorial
on that topic, too.

- Sedat -

[1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches
[2] https://www.youtube.com/watch?v=XXix80GCvpo
[3] https://github.com/gregkh/kernel-tutorial

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

[Rickard Strandqvist]

2015-01-03 14:19 GMT+01:00 Sedat Dilek <sedat.dilek@gmail.com>:
>
> On Sat, Jan 3, 2015 at 1:28 PM, Rickard Strandqvist
> <rickard_strandqvist@spectrumdigital.se> wrote:
> > 2015-01-02 22:34 GMT+01:00 Rafał Miłecki <zajec5@gmail.com>:
> >>
> >> On 2 January 2015 at 18:46, Rickard Strandqvist
> >> <rickard_strandqvist@spectrumdigital.se> wrote:
> >> > 2015-01-02 13:14 GMT+01:00 Sedat Dilek <sedat.dilek@gmail.com>:
> >> >>
> >> >> On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki <zajec5@gmail.com> wrote:
> >> >> > On 2 January 2015 at 13:05, Rafał Miłecki <zajec5@gmail.com> wrote:
> >> >> >> On 1 January 2015 at 16:46, Rickard Strandqvist
> >> >> >> <rickard_strandqvist@spectrumdigital.se> wrote:
> >> >> >>> Remove the function b43legacy_radio_set_tx_iq() that is not used
> >> >> >>> anywhere.
> >> >> >>>
> >> >> >>> This was partially found by using a static code analysis program
> >> >> >>> called cppcheck.
> >> >> >>
> >> >> >> It seems to be for A-PHY based hardware (with 0x2060 radio id) which
> >> >> >> is not handled by b43legacy. Should be safe to drop this code (we
> >> >> >> won't likely need it).
> >> >> >>
> >> >> >> Ack
> >> >> >
> >> >> > For future, we prefix patches with just a driver name. So this could
> >> >> > be simply called
> >> >> > b43legacy: radio.c: Remove unused function
> >> >> >
> >> >>
> >> >> Alternatively...
> >> >>
> >> >> "b43legacy: Remove unused function in radio.c"
> >> >>
> >> >> BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck
> >> >> to get such stuff?
> >> >>
> >> >> - Sedat -
> >> >>
> >> >> [1] https://lkml.org/lkml/2015/1/2/51
> >> >
> >> >
> >> >
> >> > Hi Rafal and Sedat
> >> >
> >> > Rafal do you mean I should remove the entire b43legacy part?
> >>
> >> 1) I gave you Ack for the changes
> >> 2) You could drop "net: wireless: " or better use something Sedat proposed
> >>
> >> --
> >> Rafał
> >
> >
> >
> > Hi
> >
> > Nice, yes I miss the Ack :)
> >
> > I just got one more complaining about my subject-line in "net: wireless: "
> > I use some sed call for this, so it's easy to fix. I will now remove that
> > part hereinafter.
> > I check in Documentation/ but did not find any clear info for this.
> >
>
> The easiest way to make (sub)maintainers happy is to check the git-log...
>
> $ git log --oneline /path/to/file
>
> ...and look how other contributors labeled their patches.
>
> [1] is the 1st address to look at on how to submit patches to Linux-kernel.
> To promote the good work of Greg, see [2,3] for a video and tutorial
> on that topic, too.
>
> - Sedat -
>
> [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches
> [2] https://www.youtube.com/watch?v=XXix80GCvpo
> [3] https://github.com/gregkh/kernel-tutorial



Hi Sedat

Thanks for the tip :)

To bad with the audio in the video thow. Have read SubmittingPatches before.


But I have now added a line in my script that does a:

git log -10 --oneline

So I can at least see the other subjekt lines, and make adjustments if
necessary.



Kind regards
Rickard Strandqvist

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

[Sedat Dilek]

On Sat, Jan 3, 2015 at 3:45 PM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
[ ... ]
>> > I just got one more complaining about my subject-line in "net: wireless: "
>> > I use some sed call for this, so it's easy to fix. I will now remove that
>> > part hereinafter.
>> > I check in Documentation/ but did not find any clear info for this.
>> >
>>
>> The easiest way to make (sub)maintainers happy is to check the git-log...
>>
>> $ git log --oneline /path/to/file
>>
>> ...and look how other contributors labeled their patches.
>>
>> [1] is the 1st address to look at on how to submit patches to Linux-kernel.
>> To promote the good work of Greg, see [2,3] for a video and tutorial
>> on that topic, too.
>>
>> - Sedat -
>>
>> [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches
>> [2] https://www.youtube.com/watch?v=XXix80GCvpo
>> [3] https://github.com/gregkh/kernel-tutorial
>
>
>
> Hi Sedat
>
> Thanks for the tip :)
>
> To bad with the audio in the video thow. Have read SubmittingPatches before.
>

AFAICS there is another (earlier) video "Write and Submit your first
Linux kernel Patch" from FOSDEM 2010.

For German readers I can recommend the book from [2] (no I get no
money for promotion).

- Sedat -

[1] https://www.youtube.com/watch?v=LLBrBBImJt4
[2] http://www.opensourcepress.de/de/produkte/Git/33227/978-3-95539-119-5-

>
> But I have now added a line in my script that does a:
>
> git log -10 --oneline
>
> So I can at least see the other subjekt lines, and make adjustments if
> necessary.
>
>
>
> Kind regards
> Rickard Strandqvist

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

[Rickard Strandqvist]

2015-01-03 15:51 GMT+01:00 Sedat Dilek <sedat.dilek@gmail.com>:
> On Sat, Jan 3, 2015 at 3:45 PM, Rickard Strandqvist
> <rickard_strandqvist@spectrumdigital.se> wrote:
> [ ... ]
>>> > I just got one more complaining about my subject-line in "net: wireless: "
>>> > I use some sed call for this, so it's easy to fix. I will now remove that
>>> > part hereinafter.
>>> > I check in Documentation/ but did not find any clear info for this.
>>> >
>>>
>>> The easiest way to make (sub)maintainers happy is to check the git-log...
>>>
>>> $ git log --oneline /path/to/file
>>>
>>> ...and look how other contributors labeled their patches.
>>>
>>> [1] is the 1st address to look at on how to submit patches to Linux-kernel.
>>> To promote the good work of Greg, see [2,3] for a video and tutorial
>>> on that topic, too.
>>>
>>> - Sedat -
>>>
>>> [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches
>>> [2] https://www.youtube.com/watch?v=XXix80GCvpo
>>> [3] https://github.com/gregkh/kernel-tutorial
>>
>>
>>
>> Hi Sedat
>>
>> Thanks for the tip :)
>>
>> To bad with the audio in the video thow. Have read SubmittingPatches before.
>>
>
> AFAICS there is another (earlier) video "Write and Submit your first
> Linux kernel Patch" from FOSDEM 2010.
>
> For German readers I can recommend the book from [2] (no I get no
> money for promotion).
>
> - Sedat -
>
> [1] https://www.youtube.com/watch?v=LLBrBBImJt4
> [2] http://www.opensourcepress.de/de/produkte/Git/33227/978-3-95539-119-5-
>
>>
>> But I have now added a line in my script that does a:
>>
>> git log -10 --oneline
>>
>> So I can at least see the other subjekt lines, and make adjustments if
>> necessary.
>>
>>
>>
>> Kind regards
>> Rickard Strandqvist


Hi

Good video!
Wish I had seen this a year ago.

Sorry, no German for me :)


Kind regards
Rickard Strandqvist

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

[Rafał Miłecki]

On 3 January 2015 at 13:28, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> 2015-01-02 22:34 GMT+01:00 Rafał Miłecki <zajec5@gmail.com>:
>>
>> 1) I gave you Ack for the changes
>> 2) You could drop "net: wireless: " or better use something Sedat proposed
>
> Nice, yes I miss the Ack :)
>
> I just got one more complaining about my subject-line in "net: wireless: "
> I use some sed call for this, so it's easy to fix. I will now remove that
> part hereinafter.

Will you re-send this patch with a proper subject then, please?

-- 
Rafał

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

[Rickard Strandqvist]

2015-01-05 7:34 GMT+01:00 Rafał Miłecki <zajec5@gmail.com>:
> On 3 January 2015 at 13:28, Rickard Strandqvist
> <rickard_strandqvist@spectrumdigital.se> wrote:
>> 2015-01-02 22:34 GMT+01:00 Rafał Miłecki <zajec5@gmail.com>:
>>>
>>> 1) I gave you Ack for the changes
>>> 2) You could drop "net: wireless: " or better use something Sedat proposed
>>
>> Nice, yes I miss the Ack :)
>>
>> I just got one more complaining about my subject-line in "net: wireless: "
>> I use some sed call for this, so it's easy to fix. I will now remove that
>> part hereinafter.
>
> Will you re-send this patch with a proper subject then, please?
>
> --
> Rafał


Hi Rafał

Ok, resent the patch.

Just a thought about this naming.
Now I have changed in radio.c and radio.h, what happens when I send
another patch for other files in the same directory, the caption will
then be identical.


Kind regards
Rickard Strandqvist