* [PATCH] ksmbd: fix documentation for 2 functions
@ 2021-09-28 22:56 Enzo Matsumiya
2021-09-29 0:08 ` Namjae Jeon
0 siblings, 1 reply; 3+ messages in thread
From: Enzo Matsumiya @ 2021-09-28 22:56 UTC (permalink / raw)
To: linux-cifs
Cc: pc, Enzo Matsumiya, Namjae Jeon, Sergey Senozhatsky,
Steve French, Hyunchul Lee, linux-kernel
ksmbd_kthread_fn() and create_socket() returns 0 or error code, and not
task_struct/ERR_PTR.
Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
---
fs/ksmbd/transport_tcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ksmbd/transport_tcp.c b/fs/ksmbd/transport_tcp.c
index dc15a5ecd2e0..c14320e03b69 100644
--- a/fs/ksmbd/transport_tcp.c
+++ b/fs/ksmbd/transport_tcp.c
@@ -215,7 +215,7 @@ static int ksmbd_tcp_new_connection(struct socket *client_sk)
* ksmbd_kthread_fn() - listen to new SMB connections and callback server
* @p: arguments to forker thread
*
- * Return: Returns a task_struct or ERR_PTR
+ * Return: 0 on success, error number otherwise
*/
static int ksmbd_kthread_fn(void *p)
{
@@ -387,7 +387,7 @@ static void tcp_destroy_socket(struct socket *ksmbd_socket)
/**
* create_socket - create socket for ksmbd/0
*
- * Return: Returns a task_struct or ERR_PTR
+ * Return: 0 on success, error number otherwise
*/
static int create_socket(struct interface *iface)
{
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ksmbd: fix documentation for 2 functions
2021-09-28 22:56 [PATCH] ksmbd: fix documentation for 2 functions Enzo Matsumiya
@ 2021-09-29 0:08 ` Namjae Jeon
2021-09-29 3:54 ` Steve French
0 siblings, 1 reply; 3+ messages in thread
From: Namjae Jeon @ 2021-09-29 0:08 UTC (permalink / raw)
To: Enzo Matsumiya
Cc: linux-cifs, pc, Sergey Senozhatsky, Steve French, Hyunchul Lee,
linux-kernel
2021-09-29 7:56 GMT+09:00, Enzo Matsumiya <ematsumiya@suse.de>:
> ksmbd_kthread_fn() and create_socket() returns 0 or error code, and not
> task_struct/ERR_PTR.
>
> Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Thanks for your patch!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ksmbd: fix documentation for 2 functions
2021-09-29 0:08 ` Namjae Jeon
@ 2021-09-29 3:54 ` Steve French
0 siblings, 0 replies; 3+ messages in thread
From: Steve French @ 2021-09-29 3:54 UTC (permalink / raw)
To: Namjae Jeon
Cc: Enzo Matsumiya, CIFS, Paulo Alcantara, Sergey Senozhatsky,
Steve French, Hyunchul Lee, LKML
merged into cifsd-for-next
On Tue, Sep 28, 2021 at 7:10 PM Namjae Jeon <linkinjeon@kernel.org> wrote:
>
> 2021-09-29 7:56 GMT+09:00, Enzo Matsumiya <ematsumiya@suse.de>:
> > ksmbd_kthread_fn() and create_socket() returns 0 or error code, and not
> > task_struct/ERR_PTR.
> >
> > Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
> Acked-by: Namjae Jeon <linkinjeon@kernel.org>
>
> Thanks for your patch!
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-29 3:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 22:56 [PATCH] ksmbd: fix documentation for 2 functions Enzo Matsumiya
2021-09-29 0:08 ` Namjae Jeon
2021-09-29 3:54 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).