* RE: [PATCH] exfat: fix overflow for large capacity partition
[not found] ` <PUZPR04MB63161D3BE9104FF48BD298DE81719@PUZPR04MB6316.apcprd04.prod.outlook.com>
@ 2022-08-23 3:26 ` Sungjong Seo
2022-08-26 9:06 ` Namjae Jeon
1 sibling, 0 replies; 2+ messages in thread
From: Sungjong Seo @ 2022-08-23 3:26 UTC (permalink / raw)
To: 'Namjae Jeon'; +Cc: 'linux-fsdevel', 'linux-kernel'
> Using int type for sector index, there will be overflow in a large
> capacity partition.
>
> For example, if storage with sector size of 512 bytes and partition
> capacity is larger than 2TB, there will be overflow.
>
> Fixes: 1b6138385499 ("exfat: reduce block requests when zeroing a cluster")
>
> Signed-off-by: Yuezhang Mo <Yuezhang.Mo@sony.com>
> Reviewed-by: Andy Wu <Andy.Wu@sony.com>
> Reviewed-by: Aoyama Wataru <wataru.aoyama@sony.com>
Looks good!
Acked-by: Sungjong Seo <sj1557.seo@samsung.com>
>
> ---
> fs/exfat/fatent.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/exfat/fatent.c b/fs/exfat/fatent.c index
> ee0b7cf51157..41ae4cce1f42 100644
> --- a/fs/exfat/fatent.c
> +++ b/fs/exfat/fatent.c
> @@ -270,8 +270,7 @@ int exfat_zeroed_cluster(struct inode *dir, unsigned
> int clu)
> struct super_block *sb = dir->i_sb;
> struct exfat_sb_info *sbi = EXFAT_SB(sb);
> struct buffer_head *bh;
> - sector_t blknr, last_blknr;
> - int i;
> + sector_t blknr, last_blknr, i;
>
> blknr = exfat_cluster_to_sector(sbi, clu);
> last_blknr = blknr + sbi->sect_per_clus;
> --
> 2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] exfat: fix overflow for large capacity partition
[not found] ` <PUZPR04MB63161D3BE9104FF48BD298DE81719@PUZPR04MB6316.apcprd04.prod.outlook.com>
2022-08-23 3:26 ` [PATCH] exfat: fix overflow for large capacity partition Sungjong Seo
@ 2022-08-26 9:06 ` Namjae Jeon
1 sibling, 0 replies; 2+ messages in thread
From: Namjae Jeon @ 2022-08-26 9:06 UTC (permalink / raw)
To: Yuezhang.Mo
Cc: sj1557.seo, linux-fsdevel, linux-kernel, Wataru.Aoyama, Andy.Wu
2022-08-23 12:26 GMT+09:00, Sungjong Seo <sj1557.seo@samsung.com>:
>> Using int type for sector index, there will be overflow in a large
>> capacity partition.
>>
>> For example, if storage with sector size of 512 bytes and partition
>> capacity is larger than 2TB, there will be overflow.
>>
>> Fixes: 1b6138385499 ("exfat: reduce block requests when zeroing a
>> cluster")
>>
>> Signed-off-by: Yuezhang Mo <Yuezhang.Mo@sony.com>
>> Reviewed-by: Andy Wu <Andy.Wu@sony.com>
>> Reviewed-by: Aoyama Wataru <wataru.aoyama@sony.com>
>
> Looks good!
> Acked-by: Sungjong Seo <sj1557.seo@samsung.com>
Applied, Thanks!
>
>>
>> ---
>> fs/exfat/fatent.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/fs/exfat/fatent.c b/fs/exfat/fatent.c index
>> ee0b7cf51157..41ae4cce1f42 100644
>> --- a/fs/exfat/fatent.c
>> +++ b/fs/exfat/fatent.c
>> @@ -270,8 +270,7 @@ int exfat_zeroed_cluster(struct inode *dir, unsigned
>> int clu)
>> struct super_block *sb = dir->i_sb;
>> struct exfat_sb_info *sbi = EXFAT_SB(sb);
>> struct buffer_head *bh;
>> - sector_t blknr, last_blknr;
>> - int i;
>> + sector_t blknr, last_blknr, i;
>>
>> blknr = exfat_cluster_to_sector(sbi, clu);
>> last_blknr = blknr + sbi->sect_per_clus;
>> --
>> 2.25.1
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread