From: Namjae Jeon <linkinjeon@gmail.com>
To: Seungwon Jeon <tgih.jun@samsung.com>
Cc: Saugata Das <saugata.das@linaro.org>,
linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] mmc: core: Support packed command for eMMC4.5 device
Date: Thu, 26 Jan 2012 15:42:42 +0900 [thread overview]
Message-ID: <CAKYAXd8zFf7AF5_X-divH51+B=Y2YC1ZjZF00D_=+R6eF8qe9g@mail.gmail.com> (raw)
In-Reply-To: <000c01ccdbf0$71fe58b0$55fb0a10$%jun@samsung.com>
2012/1/26 Seungwon Jeon <tgih.jun@samsung.com>:
> Namjae Jeon <linkinjeon@gmail.com>:
>> 2012/1/25 Namjae Jeon <linkinjeon@gmail.com>:
>> >>> >> +
>> >>> >> +static int mmc_blk_issue_packed_rd(struct mmc_queue *mq,
>> >>> >> + struct mmc_queue_req *mq_rq)
>> >>> >> +{
>> >>> >> + struct mmc_blk_data *md = mq->data;
>> >>> >> + struct mmc_card *card = md->queue.card;
>> >>> >> + int status, ret = -EIO, retry = 2;
>> > Hi. Seungwon.
>> > First Thansk for your reply.
>> > There is one more my review comment.
>> > I think that EIO of ret is not needed. there is no case to be skipped
>> > if/ese condition in do while loop.
> Oh, no need practically.
> Thank you for your inspection.
>
>>
>> Hi. Seungwon.
>>
>> if ((!mmc_host_is_spi(card->host) && rq_data_dir(req) != READ) ||
>> + (mq_mrq->packed_cmd == MMC_PACKED_WR_HDR)) {
>>
>> it seems more better that upper if condition is changed like the below.
> Do you have any reason for your comment?
> Packed command(4.5 feature) is regardless of SPI.
> SPI mode has been removed since version 4.3.
>
>>
>> if (!mmc_host_is_spi(card->host) && ((rq_data_dir(req) != READ) ||
>> + (mq_mrq->packed_cmd == MMC_PACKED_WR_HDR))) {
>>
>>
>> +++ b/drivers/mmc/core/host.c
>> @@ -346,6 +346,8 @@ struct mmc_host *mmc_alloc_host(int extra, struct
>> device *dev)
>> host->max_blk_size = 512;
>> host->max_blk_count = PAGE_CACHE_SIZE / 512;
>>
>> + host->packed_min = 2;
>> +
>> return host;
>>
>> if packed_min is fixed value without increasing/decreasing, it seems
>> more better to use macro.
>> Thanks.
> packed_min is not fixed value.
> Could you refer the following is changes log about v3?
>
> Changes in v3:
> - Add a variable member in mmc_host for minimum number of packed entries.
> This value can be overridden by host.
Ah.. Okay~ I clearly understand about two queston.
Totally, Looks good to me.
Thanks for your reply.
And I heard that packed cmd is not good while reading small chunk,
If so, I want to use packed write cmd not read cmd.
Can I use packed only packed write cmd by seperating
MMC_CAP2_PACKED_READ_CMD and MMC_CAP2_PACKED_WRITE_CMD ?
>
> Best regards,
> Seungwon Jeon.
>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-01-26 6:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 4:06 [PATCH v3 2/2] mmc: core: Support packed command for eMMC4.5 device Seungwon Jeon
2012-01-23 10:03 ` Saugata Das
2012-01-24 22:54 ` Namjae Jeon
2012-01-25 5:18 ` Seungwon Jeon
2012-01-25 5:31 ` Namjae Jeon
2012-01-26 4:31 ` Namjae Jeon
2012-01-26 6:05 ` Seungwon Jeon
2012-01-26 6:42 ` Namjae Jeon [this message]
2012-01-26 7:24 ` Seungwon Jeon
2012-01-26 7:39 ` Namjae Jeon
2012-01-25 5:17 ` Seungwon Jeon
2012-01-26 20:52 ` Saugata Das
2012-01-27 6:55 ` Seungwon Jeon
2012-01-27 13:19 ` Saugata Das
2012-02-02 9:50 ` Seungwon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKYAXd8zFf7AF5_X-divH51+B=Y2YC1ZjZF00D_=+R6eF8qe9g@mail.gmail.com' \
--to=linkinjeon@gmail.com \
--cc=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=saugata.das@linaro.org \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).