linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namjae Jeon <linkinjeon@gmail.com>
To: Seungwon Jeon <tgih.jun@samsung.com>
Cc: Saugata Das <saugata.das@linaro.org>,
	linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] mmc: core: Support packed command for eMMC4.5 device
Date: Wed, 25 Jan 2012 14:31:00 +0900	[thread overview]
Message-ID: <CAKYAXd_jdGfpC9kcYht=qnfaTPwE+YEx1fo89GkpRyWcN6igig@mail.gmail.com> (raw)
In-Reply-To: <002501ccdb20$c98b2e80$5ca18b80$%jun@samsung.com>

>> >> +
>> >> +static int mmc_blk_issue_packed_rd(struct mmc_queue *mq,
>> >> +               struct mmc_queue_req *mq_rq)
>> >> +{
>> >> +       struct mmc_blk_data *md = mq->data;
>> >> +       struct mmc_card *card = md->queue.card;
>> >> +       int status, ret = -EIO, retry = 2;
Hi. Seungwon.
First Thansk for your reply.
There is one more my review comment.
I think that EIO of ret is not needed. there is no case to be skipped
if/ese condition in do while loop.

  reply	other threads:[~2012-01-25  5:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-20  4:06 [PATCH v3 2/2] mmc: core: Support packed command for eMMC4.5 device Seungwon Jeon
2012-01-23 10:03 ` Saugata Das
2012-01-24 22:54   ` Namjae Jeon
2012-01-25  5:18     ` Seungwon Jeon
2012-01-25  5:31       ` Namjae Jeon [this message]
2012-01-26  4:31         ` Namjae Jeon
2012-01-26  6:05           ` Seungwon Jeon
2012-01-26  6:42             ` Namjae Jeon
2012-01-26  7:24               ` Seungwon Jeon
2012-01-26  7:39                 ` Namjae Jeon
2012-01-25  5:17   ` Seungwon Jeon
2012-01-26 20:52     ` Saugata Das
2012-01-27  6:55       ` Seungwon Jeon
2012-01-27 13:19         ` Saugata Das
2012-02-02  9:50           ` Seungwon Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKYAXd_jdGfpC9kcYht=qnfaTPwE+YEx1fo89GkpRyWcN6igig@mail.gmail.com' \
    --to=linkinjeon@gmail.com \
    --cc=cjb@laptop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=saugata.das@linaro.org \
    --cc=tgih.jun@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).