[PATCH 2/2] f2fs: add REQ_META about metadata requests for submit bio

[PATCH 2/2] f2fs: add REQ_META about metadata requests for submit bio

[Namjae Jeon]

From: Namjae Jeon <namjae.jeon@samsung.com>

Adding REQ_META for all the metadata requests can help in improving the
FS performance, if the underlying device supports TAGGING.
So, when considering the submit_bio path for all the f2fs requests. We can
add REQ_META for all the META requests.
As a precursor to this change we considered the commit
4265900e0be653f5b78baf2816857ef57cf1332f 'mmc: MMC-4.5 Data Tag Support'

Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
---
 fs/f2fs/segment.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 1193a26..a2e5de7 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -689,6 +689,9 @@ static void do_submit_bio(struct f2fs_sb_info *sbi,
 	if (type >= META_FLUSH)
 		rw = WRITE_FLUSH_FUA;
 
+	if (type == META)
+		rw |= REQ_META;
+
 	if (sbi->bio[btype]) {
 		struct bio_private *p = sbi->bio[btype]->bi_private;
 		trace_f2fs_do_submit_bio(sbi->sb, btype, sync,
-- 
1.7.9.5

Re: [PATCH 2/2] f2fs: add REQ_META about metadata requests for submit bio

[Jaegeuk Kim]

[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]

2013-04-20 (토), 01:27 +0900, Namjae Jeon:
> From: Namjae Jeon <namjae.jeon@samsung.com>
> 
> Adding REQ_META for all the metadata requests can help in improving the
> FS performance, if the underlying device supports TAGGING.
> So, when considering the submit_bio path for all the f2fs requests. We can
> add REQ_META for all the META requests.
> As a precursor to this change we considered the commit
> 4265900e0be653f5b78baf2816857ef57cf1332f 'mmc: MMC-4.5 Data Tag Support'
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
> ---
>  fs/f2fs/segment.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 1193a26..a2e5de7 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -689,6 +689,9 @@ static void do_submit_bio(struct f2fs_sb_info *sbi,
>  	if (type >= META_FLUSH)
>  		rw = WRITE_FLUSH_FUA;
>  
> +	if (type == META)

Should be if (btype == META).
Thanks,

> +		rw |= REQ_META;
> +
>  	if (sbi->bio[btype]) {
>  		struct bio_private *p = sbi->bio[btype]->bi_private;
>  		trace_f2fs_do_submit_bio(sbi->sb, btype, sync,

-- 
Jaegeuk Kim
Samsung

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 2/2] f2fs: add REQ_META about metadata requests for submit bio

[Namjae Jeon]

2013/4/22, Jaegeuk Kim <jaegeuk.kim@samsung.com>:
> 2013-04-20 (토), 01:27 +0900, Namjae Jeon:
>> From: Namjae Jeon <namjae.jeon@samsung.com>
>>
>> Adding REQ_META for all the metadata requests can help in improving the
>> FS performance, if the underlying device supports TAGGING.
>> So, when considering the submit_bio path for all the f2fs requests. We
>> can
>> add REQ_META for all the META requests.
>> As a precursor to this change we considered the commit
>> 4265900e0be653f5b78baf2816857ef57cf1332f 'mmc: MMC-4.5 Data Tag Support'
>>
>> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
>> Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
>> ---
>>  fs/f2fs/segment.c |    3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
>> index 1193a26..a2e5de7 100644
>> --- a/fs/f2fs/segment.c
>> +++ b/fs/f2fs/segment.c
>> @@ -689,6 +689,9 @@ static void do_submit_bio(struct f2fs_sb_info *sbi,
>>  	if (type >= META_FLUSH)
>>  		rw = WRITE_FLUSH_FUA;
>>
>> +	if (type == META)
>
> Should be if (btype == META).
> Thanks,
Yes, Right :)
Thanks for fixing.
>
>> +		rw |= REQ_META;
>> +
>>  	if (sbi->bio[btype]) {
>>  		struct bio_private *p = sbi->bio[btype]->bi_private;
>>  		trace_f2fs_do_submit_bio(sbi->sb, btype, sync,
>
> --
> Jaegeuk Kim
> Samsung
>

Re: [PATCH 2/2] f2fs: add REQ_META about metadata requests for submit bio

[Namjae Jeon]

>>>
>>> +	if (type == META)
>>
>> Should be if (btype == META).
>> Thanks,
> Yes, Right :)
> Thanks for fixing.
Hi. Jaegeuk.
Should I resend the fixed patch as above your comment ?

Thanks.
>>
>>> +		rw |= REQ_META;
>>> +
>>>  	if (sbi->bio[btype]) {
>>>  		struct bio_private *p = sbi->bio[btype]->bi_private;
>>>  		trace_f2fs_do_submit_bio(sbi->sb, btype, sync,
>>
>> --
>> Jaegeuk Kim
>> Samsung
>>
>

Re: [PATCH 2/2] f2fs: add REQ_META about metadata requests for submit bio

[Jaegeuk Kim]

[-- Attachment #1: Type: text/plain, Size: 842 bytes --]

2013-04-24 (수), 15:08 +0900, Namjae Jeon:
> >>>
> >>> +	if (type == META)
> >>
> >> Should be if (btype == META).
> >> Thanks,
> > Yes, Right :)
> > Thanks for fixing.
> Hi. Jaegeuk.
> Should I resend the fixed patch as above your comment ?

I can handle it. :)
Thanks,

> 
> Thanks.
> >>
> >>> +		rw |= REQ_META;
> >>> +
> >>>  	if (sbi->bio[btype]) {
> >>>  		struct bio_private *p = sbi->bio[btype]->bi_private;
> >>>  		trace_f2fs_do_submit_bio(sbi->sb, btype, sync,
> >>
> >> --
> >> Jaegeuk Kim
> >> Samsung
> >>
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Jaegeuk Kim
Samsung

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]