* [PATCH] kernel/SRCU: Fix ctags
@ 2018-08-28 15:44 Sam Protsenko
2018-09-11 16:57 ` Sam Protsenko
0 siblings, 1 reply; 2+ messages in thread
From: Sam Protsenko @ 2018-08-28 15:44 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, Peter Zijlstra, David S . Miller, Rafael J . Wysocki
ctags indexing ("make tags" command) throws this warning:
ctags: Warning: include/linux/notifier.h:125:
null expansion of name pattern "\1"
This is the result of DEFINE_PER_CPU() macro exapansion. Fix that by
getting rid of line break.
Similar fix was already done in commit 25528213fe9f ("tags: Fix
DEFINE_PER_CPU expansions"), but this one probably wasn't noticed.
Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
include/linux/notifier.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/notifier.h b/include/linux/notifier.h
index f35c7bf76143..2c6ff4cde938 100644
--- a/include/linux/notifier.h
+++ b/include/linux/notifier.h
@@ -122,8 +122,7 @@ extern void srcu_init_notifier_head(struct srcu_notifier_head *nh);
#ifdef CONFIG_TREE_SRCU
#define _SRCU_NOTIFIER_HEAD(name, mod) \
- static DEFINE_PER_CPU(struct srcu_data, \
- name##_head_srcu_data); \
+ static DEFINE_PER_CPU(struct srcu_data, name##_head_srcu_data); \
mod struct srcu_notifier_head name = \
SRCU_NOTIFIER_INIT(name, name##_head_srcu_data)
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kernel/SRCU: Fix ctags
2018-08-28 15:44 [PATCH] kernel/SRCU: Fix ctags Sam Protsenko
@ 2018-09-11 16:57 ` Sam Protsenko
0 siblings, 0 replies; 2+ messages in thread
From: Sam Protsenko @ 2018-09-11 16:57 UTC (permalink / raw)
To: linux-kernel, Greg Kroah-Hartman, Kate Stewart
Cc: Peter Zijlstra, David S . Miller, Rafael J . Wysocki
Hi guys,
It's been a while since I sent this one. Can we please merge it if
there is no objections?
Thanks.
On Tue, Aug 28, 2018 at 6:44 PM, Sam Protsenko
<semen.protsenko@linaro.org> wrote:
> ctags indexing ("make tags" command) throws this warning:
>
> ctags: Warning: include/linux/notifier.h:125:
> null expansion of name pattern "\1"
>
> This is the result of DEFINE_PER_CPU() macro exapansion. Fix that by
> getting rid of line break.
>
> Similar fix was already done in commit 25528213fe9f ("tags: Fix
> DEFINE_PER_CPU expansions"), but this one probably wasn't noticed.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> include/linux/notifier.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/notifier.h b/include/linux/notifier.h
> index f35c7bf76143..2c6ff4cde938 100644
> --- a/include/linux/notifier.h
> +++ b/include/linux/notifier.h
> @@ -122,8 +122,7 @@ extern void srcu_init_notifier_head(struct srcu_notifier_head *nh);
>
> #ifdef CONFIG_TREE_SRCU
> #define _SRCU_NOTIFIER_HEAD(name, mod) \
> - static DEFINE_PER_CPU(struct srcu_data, \
> - name##_head_srcu_data); \
> + static DEFINE_PER_CPU(struct srcu_data, name##_head_srcu_data); \
> mod struct srcu_notifier_head name = \
> SRCU_NOTIFIER_INIT(name, name##_head_srcu_data)
>
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-11 16:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-28 15:44 [PATCH] kernel/SRCU: Fix ctags Sam Protsenko
2018-09-11 16:57 ` Sam Protsenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).