[PATCHv3 0/4] Add device tree data for omap5

[PATCHv3 0/4] Add device tree data for omap5

[Sourav Poddar]

The following patch series add i2c support for omap5.
As well as enable I2C based devices like pressure and temperature
through device tree. Also add onchip keypad dts data.

Cc: Benoit Cousson <b-cousson@ti.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>

Sourav Poddar (4):
  arm/dts: omap5-evm: Add I2C support
  arm/dts: omap5-evm: Add tmp102 sensor support
  arm/dts: omap5-evm: Add keypad data
  arm/dts: omap5-evm: Add bmp085 sensor support

v2->v3
- Rebased on 3.6-rc1
- Add comments for tmp102 and bmp085
 arch/arm/boot/dts/omap5-evm.dts |   32 +++++++++++++++++++++++++++++++
 arch/arm/boot/dts/omap5.dtsi    |   40 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 72 insertions(+), 0 deletions(-)

[PATCHv3 1/4] arm/dts: omap5-evm: Add I2C support

[Sourav Poddar]

Add I2C data node in omap5 device tree file.

Tested on omap5430 evm.

Cc: Benoit Cousson <b-cousson@ti.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
 arch/arm/boot/dts/omap5.dtsi |   35 +++++++++++++++++++++++++++++++++++
 1 files changed, 35 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index 57e5270..6b68dfe 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -145,6 +145,41 @@
 			#interrupt-cells = <1>;
 		};
 
+		i2c1: i2c@48070000 {
+			compatible = "ti,omap4-i2c";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			ti,hwmods = "i2c1";
+		};
+
+		i2c2: i2c@48072000 {
+			compatible = "ti,omap4-i2c";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			ti,hwmods = "i2c2";
+		};
+
+		i2c3: i2c@48060000 {
+			compatible = "ti,omap4-i2c";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			ti,hwmods = "i2c3";
+		};
+
+		i2c4: i2c@4807A000 {
+			compatible = "ti,omap4-i2c";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			ti,hwmods = "i2c4";
+		};
+
+		i2c5: i2c@4807C000 {
+			compatible = "ti,omap4-i2c";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			ti,hwmods = "i2c5";
+		};
+
 		uart1: serial@4806a000 {
 			compatible = "ti,omap4-uart";
 			ti,hwmods = "uart1";
-- 
1.7.1

[PATCHv3 2/4] arm/dts: omap5-evm: Add tmp102 sensor support

[Sourav Poddar]

Add tmp102 temperature sensor data in omap5 evm dts file.

Tested on omap5430 evm with 3.5 custom kernel.

Cc: Benoit Cousson <b-cousson@ti.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
 arch/arm/boot/dts/omap5-evm.dts |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/omap5-evm.dts b/arch/arm/boot/dts/omap5-evm.dts
index 200c39a..b302802 100644
--- a/arch/arm/boot/dts/omap5-evm.dts
+++ b/arch/arm/boot/dts/omap5-evm.dts
@@ -18,3 +18,13 @@
 		reg = <0x80000000 0x40000000>; /* 1 GB */
 	};
 };
+
+&i2c4 {
+	clock-frequency = <400000>;
+
+	/* Temperature Sensor */
+	tmp102@48{
+		compatible = "ti,tmp102";
+		reg = <0x48>;
+	};
+};
-- 
1.7.1

[PATCHv3 3/4] arm/dts: omap5-evm: Add keypad data

[Sourav Poddar]

Add keypad data node in omap5 device tree file.
Also fill the device tree binding parameters
with the required value in "omap5-evm" dts file.

Tested on omap5430 evm with 3.5 custom kernel.

Cc: Benoit Cousson <b-cousson@ti.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
 arch/arm/boot/dts/omap5-evm.dts |   12 ++++++++++++
 arch/arm/boot/dts/omap5.dtsi    |    5 +++++
 2 files changed, 17 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/omap5-evm.dts b/arch/arm/boot/dts/omap5-evm.dts
index b302802..8835026 100644
--- a/arch/arm/boot/dts/omap5-evm.dts
+++ b/arch/arm/boot/dts/omap5-evm.dts
@@ -17,6 +17,18 @@
 		device_type = "memory";
 		reg = <0x80000000 0x40000000>; /* 1 GB */
 	};
+
+	keypad {
+		keypad,num-rows = <8>;
+		keypad,num-columns = <8>;
+		linux,keymap = < 0x02020073  /* VOLUP */
+			0x02030072  /* VOLDOWM */
+			0x020400e7  /* SEND */
+			0x02050066  /* HOME */
+			0x0206006b  /* END */
+			0x020700d9 >; /* SEARCH */
+		linux,input-no-autorepeat;
+	};
 };
 
 &i2c4 {
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index 6b68dfe..c38b823 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -216,4 +216,9 @@
 			clock-frequency = <48000000>;
 		};
 	};
+
+	keypad {
+		compatible = "ti,omap4-keypad";
+		ti,hwmods = "kbd";
+	};
 };
-- 
1.7.1

[PATCHv3 4/4] arm/dts: omap5-evm: Add bmp085 sensor support

[Sourav Poddar]

Add bmp085 pressure sensor data in omap5 evm dts file.

Tested on omap5430 evm with 3.5 custom kernel.

Cc: Benoit Cousson <b-cousson@ti.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
 arch/arm/boot/dts/omap5-evm.dts |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/omap5-evm.dts b/arch/arm/boot/dts/omap5-evm.dts
index 8835026..378ccc2 100644
--- a/arch/arm/boot/dts/omap5-evm.dts
+++ b/arch/arm/boot/dts/omap5-evm.dts
@@ -40,3 +40,13 @@
 		reg = <0x48>;
 	};
 };
+
+&i2c2 {
+	clock-frequency = <400000>;
+
+	/* Pressure Sensor */
+	bmp085@77 {
+		compatible = "bosch,bmp085";
+		reg = <0x77>;
+	};
+};
-- 
1.7.1

Re: [PATCHv3 0/4] Add device tree data for omap5

[Poddar, Sourav]

Hi All,

On Tue, Aug 14, 2012 at 9:54 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
> The following patch series add i2c support for omap5.
> As well as enable I2C based devices like pressure and temperature
> through device tree. Also add onchip keypad dts data.
>
> Cc: Benoit Cousson <b-cousson@ti.com>
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
> Sourav Poddar (4):
>   arm/dts: omap5-evm: Add I2C support
>   arm/dts: omap5-evm: Add tmp102 sensor support
>   arm/dts: omap5-evm: Add keypad data
>   arm/dts: omap5-evm: Add bmp085 sensor support
>
> v2->v3
> - Rebased on 3.6-rc1
> - Add comments for tmp102 and bmp085
>  arch/arm/boot/dts/omap5-evm.dts |   32 +++++++++++++++++++++++++++++++
>  arch/arm/boot/dts/omap5.dtsi    |   40 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 72 insertions(+), 0 deletions(-)
>
Any comment on this series?

~Sourav

Re: [PATCHv3 0/4] Add device tree data for omap5

[Benoit Cousson]

On 08/20/2012 02:10 PM, Poddar, Sourav wrote:
> Hi All,
> 
> On Tue, Aug 14, 2012 at 9:54 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
>> The following patch series add i2c support for omap5.
>> As well as enable I2C based devices like pressure and temperature
>> through device tree. Also add onchip keypad dts data.
>>
>> Cc: Benoit Cousson <b-cousson@ti.com>
>> Cc: Felipe Balbi <balbi@ti.com>
>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>
>> Sourav Poddar (4):
>>   arm/dts: omap5-evm: Add I2C support
>>   arm/dts: omap5-evm: Add tmp102 sensor support
>>   arm/dts: omap5-evm: Add keypad data
>>   arm/dts: omap5-evm: Add bmp085 sensor support
>>
>> v2->v3
>> - Rebased on 3.6-rc1
>> - Add comments for tmp102 and bmp085
>>  arch/arm/boot/dts/omap5-evm.dts |   32 +++++++++++++++++++++++++++++++
>>  arch/arm/boot/dts/omap5.dtsi    |   40 +++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 72 insertions(+), 0 deletions(-)
>>
> Any comment on this series?

Didn't we mentioned updating the trivial-devices.txt in the
documentation to list these devices?

Otherwise it it fine. You can add the documentation and I'll take these
patches as well along with the others.

Regards,
Benoit

Re: [PATCHv3 0/4] Add device tree data for omap5

[Poddar, Sourav]

Hi Benoit,

On Mon, Aug 20, 2012 at 5:43 PM, Benoit Cousson <b-cousson@ti.com> wrote:
> On 08/20/2012 02:10 PM, Poddar, Sourav wrote:
>> Hi All,
>>
>> On Tue, Aug 14, 2012 at 9:54 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
>>> The following patch series add i2c support for omap5.
>>> As well as enable I2C based devices like pressure and temperature
>>> through device tree. Also add onchip keypad dts data.
>>>
>>> Cc: Benoit Cousson <b-cousson@ti.com>
>>> Cc: Felipe Balbi <balbi@ti.com>
>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>
>>> Sourav Poddar (4):
>>>   arm/dts: omap5-evm: Add I2C support
>>>   arm/dts: omap5-evm: Add tmp102 sensor support
>>>   arm/dts: omap5-evm: Add keypad data
>>>   arm/dts: omap5-evm: Add bmp085 sensor support
>>>
>>> v2->v3
>>> - Rebased on 3.6-rc1
>>> - Add comments for tmp102 and bmp085
>>>  arch/arm/boot/dts/omap5-evm.dts |   32 +++++++++++++++++++++++++++++++
>>>  arch/arm/boot/dts/omap5.dtsi    |   40 +++++++++++++++++++++++++++++++++++++++
>>>  2 files changed, 72 insertions(+), 0 deletions(-)
>>>
>> Any comment on this series?
>
> Didn't we mentioned updating the trivial-devices.txt in the
> documentation to list these devices?
>
I had posted a patch for updating the Documentation, though I created
a seperate
hwmon/tmp102.txt file. There is a comment to add it to trivial devices. So,
I will post a single patch doing so.

> Otherwise it it fine. You can add the documentation and I'll take these
> patches as well along with the others.
>
> Regards,
> Benoit

Re: [PATCHv3 0/4] Add device tree data for omap5

[Benoit Cousson]

On 08/20/2012 02:17 PM, Poddar, Sourav wrote:
> Hi Benoit,
> 
> On Mon, Aug 20, 2012 at 5:43 PM, Benoit Cousson <b-cousson@ti.com> wrote:
>> On 08/20/2012 02:10 PM, Poddar, Sourav wrote:
>>> Hi All,
>>>
>>> On Tue, Aug 14, 2012 at 9:54 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
>>>> The following patch series add i2c support for omap5.
>>>> As well as enable I2C based devices like pressure and temperature
>>>> through device tree. Also add onchip keypad dts data.
>>>>
>>>> Cc: Benoit Cousson <b-cousson@ti.com>
>>>> Cc: Felipe Balbi <balbi@ti.com>
>>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>>
>>>> Sourav Poddar (4):
>>>>   arm/dts: omap5-evm: Add I2C support
>>>>   arm/dts: omap5-evm: Add tmp102 sensor support
>>>>   arm/dts: omap5-evm: Add keypad data
>>>>   arm/dts: omap5-evm: Add bmp085 sensor support
>>>>
>>>> v2->v3
>>>> - Rebased on 3.6-rc1
>>>> - Add comments for tmp102 and bmp085
>>>>  arch/arm/boot/dts/omap5-evm.dts |   32 +++++++++++++++++++++++++++++++
>>>>  arch/arm/boot/dts/omap5.dtsi    |   40 +++++++++++++++++++++++++++++++++++++++
>>>>  2 files changed, 72 insertions(+), 0 deletions(-)
>>>>
>>> Any comment on this series?
>>
>> Didn't we mentioned updating the trivial-devices.txt in the
>> documentation to list these devices?
>>
> I had posted a patch for updating the Documentation, though I created
> a seperate
> hwmon/tmp102.txt file. There is a comment to add it to trivial devices. So,
> I will post a single patch doing so.

Cool, I'll take it on top of this one then.

Thanks,
Benoit

Re: [PATCHv3 0/4] Add device tree data for omap5

[Benoit Cousson]

Hi Sourav,

While rebasing your series on top of Tony's lo/devel-dt, I realized that the keypad nodes are not located at the correct place :-(

At the moment they are just floating at the top level of the dts while they belong to the ocp bus and thus should be put there.

I fixed that since it was trivial and cleaned as well the changelog and the comments to aligned then properly. I added as well the physical address to the node name and a label for easy reference at board level.

I did some basic test on my OMAP4 sdp, but that all I can do so far.

Could you just check if this is still fine for OMAP5 before I ask Tony to pull that.

I based that on top of Tony's DT patches due to conflict with the existing MMC patch in it.



The following changes since commit 85d7ff9b907685b6469058888f1d961b3e8d47ad:
  Olof Johansson (1):
        ARM: omap: add dtb targets

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git for_3.7/dts

Sourav Poddar (6):
      arm/dts: omap5-evm: Add I2C support
      arm/dts: omap5-evm: Add tmp102 sensor support
      arm/dts: omap5-evm: Add keypad data
      arm/dts: omap5-evm: Add bmp085 sensor support
      arm/dts: omap4-sdp: Add keypad data
      Documentation: dt: i2c: trivial-devices: Update for tmp102

 .../devicetree/bindings/i2c/trivial-devices.txt    |    1 +
 arch/arm/boot/dts/omap4-sdp.dts                    |   70 ++++++++++++++++++++
 arch/arm/boot/dts/omap4.dtsi                       |    5 ++
 arch/arm/boot/dts/omap5-evm.dts                    |   33 +++++++++
 arch/arm/boot/dts/omap5.dtsi                       |   40 +++++++++++
 5 files changed, 149 insertions(+), 0 deletions(-)

Regards,
Benoit

Re: [PATCHv3 0/4] Add device tree data for omap5

[Poddar, Sourav]

Hi Benoit,

On Fri, Aug 31, 2012 at 3:02 PM, Benoit Cousson <b-cousson@ti.com> wrote:
> Hi Sourav,
>
> While rebasing your series on top of Tony's lo/devel-dt, I realized that the keypad nodes are not located at the correct place :-(
>
> At the moment they are just floating at the top level of the dts while they belong to the ocp bus and thus should be put there.
>
My bad, never realised always used it at the top level. Sorry for the
inconvenience.
> I fixed that since it was trivial and cleaned as well the changelog and the comments to aligned then properly. I added as well the physical address to the node name and a label for easy reference at board level.
>
Thanks for fixing it up.
> I did some basic test on my OMAP4 sdp, but that all I can do so far.
>
> Could you just check if this is still fine for OMAP5 before I ask Tony to pull that.
>
I just booted the below mentioned branch and its booting fine on omap5. Did
some keypad functionality test also and keypad seems to be working
fine on omap5.
> I based that on top of Tony's DT patches due to conflict with the existing MMC patch in it.
>
>
>
> The following changes since commit 85d7ff9b907685b6469058888f1d961b3e8d47ad:
>   Olof Johansson (1):
>         ARM: omap: add dtb targets
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git for_3.7/dts
>
> Sourav Poddar (6):
>       arm/dts: omap5-evm: Add I2C support
>       arm/dts: omap5-evm: Add tmp102 sensor support
>       arm/dts: omap5-evm: Add keypad data
>       arm/dts: omap5-evm: Add bmp085 sensor support
>       arm/dts: omap4-sdp: Add keypad data
>       Documentation: dt: i2c: trivial-devices: Update for tmp102
>
>  .../devicetree/bindings/i2c/trivial-devices.txt    |    1 +
>  arch/arm/boot/dts/omap4-sdp.dts                    |   70 ++++++++++++++++++++
>  arch/arm/boot/dts/omap4.dtsi                       |    5 ++
>  arch/arm/boot/dts/omap5-evm.dts                    |   33 +++++++++
>  arch/arm/boot/dts/omap5.dtsi                       |   40 +++++++++++
>  5 files changed, 149 insertions(+), 0 deletions(-)
>
> Regards,
> Benoit
>

Thanks,
Sourav