* Re: [PATCH 2/2] sched: Remove unused function group_first_cpu()
2022-06-17 18:11 ` [PATCH 2/2] sched: Remove unused function group_first_cpu() Zhang Qiao
@ 2022-06-17 14:09 ` Valentin Schneider
2022-06-20 5:57 ` Vincent Guittot
2022-06-28 7:16 ` [tip: sched/core] " tip-bot2 for Zhang Qiao
2 siblings, 0 replies; 7+ messages in thread
From: Valentin Schneider @ 2022-06-17 14:09 UTC (permalink / raw)
To: Zhang Qiao, mingo, peterz, juri.lelli, vincent.guittot
Cc: dietmar.eggemann, rostedt, bsegall, mgorman, bristot,
linux-kernel, zhangqiao22
On 18/06/22 02:11, Zhang Qiao wrote:
> group_first_cpu() is an unused function
as of commit afe06efdf07c ("sched: Extend scheduler's asym packing")
>, remove it.
>
> Signed-off-by: Zhang Qiao <zhangqiao22@huawei.com>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 0/2] scheduler loadbalancer cleanup
@ 2022-06-17 18:11 Zhang Qiao
2022-06-17 18:11 ` [PATCH 1/2] sched/fair: Remove redundant word " *" Zhang Qiao
2022-06-17 18:11 ` [PATCH 2/2] sched: Remove unused function group_first_cpu() Zhang Qiao
0 siblings, 2 replies; 7+ messages in thread
From: Zhang Qiao @ 2022-06-17 18:11 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot
Cc: dietmar.eggemann, rostedt, bsegall, mgorman, bristot, vschneid,
linux-kernel, zhangqiao22
Zhang Qiao (2):
sched/fair: Remove redundant word " *"
sched: Remove unused function group_first_cpu()
kernel/sched/fair.c | 2 +-
kernel/sched/sched.h | 9 ---------
2 files changed, 1 insertion(+), 10 deletions(-)
--
2.18.0.huawei.25
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] sched/fair: Remove redundant word " *"
2022-06-17 18:11 [PATCH 0/2] scheduler loadbalancer cleanup Zhang Qiao
@ 2022-06-17 18:11 ` Zhang Qiao
2022-06-28 7:16 ` [tip: sched/core] " tip-bot2 for Zhang Qiao
2022-06-17 18:11 ` [PATCH 2/2] sched: Remove unused function group_first_cpu() Zhang Qiao
1 sibling, 1 reply; 7+ messages in thread
From: Zhang Qiao @ 2022-06-17 18:11 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot
Cc: dietmar.eggemann, rostedt, bsegall, mgorman, bristot, vschneid,
linux-kernel, zhangqiao22
" *" is redundant. so remove it.
Signed-off-by: Zhang Qiao <zhangqiao22@huawei.com>
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 77b2048a9326..0598679a7f2a 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8500,7 +8500,7 @@ static inline int sg_imbalanced(struct sched_group *group)
/*
* group_has_capacity returns true if the group has spare capacity that could
* be used by some tasks.
- * We consider that a group has spare capacity if the * number of task is
+ * We consider that a group has spare capacity if the number of task is
* smaller than the number of CPUs or if the utilization is lower than the
* available capacity for CFS tasks.
* For the latter, we use a threshold to stabilize the state, to take into
--
2.18.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] sched: Remove unused function group_first_cpu()
2022-06-17 18:11 [PATCH 0/2] scheduler loadbalancer cleanup Zhang Qiao
2022-06-17 18:11 ` [PATCH 1/2] sched/fair: Remove redundant word " *" Zhang Qiao
@ 2022-06-17 18:11 ` Zhang Qiao
2022-06-17 14:09 ` Valentin Schneider
` (2 more replies)
1 sibling, 3 replies; 7+ messages in thread
From: Zhang Qiao @ 2022-06-17 18:11 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot
Cc: dietmar.eggemann, rostedt, bsegall, mgorman, bristot, vschneid,
linux-kernel, zhangqiao22
group_first_cpu() is an unused function, remove it.
Signed-off-by: Zhang Qiao <zhangqiao22@huawei.com>
---
kernel/sched/sched.h | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 01259611beb9..8f57e9391e82 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -1810,15 +1810,6 @@ static inline struct cpumask *group_balance_mask(struct sched_group *sg)
return to_cpumask(sg->sgc->cpumask);
}
-/**
- * group_first_cpu - Returns the first CPU in the cpumask of a sched_group.
- * @group: The group whose first CPU is to be returned.
- */
-static inline unsigned int group_first_cpu(struct sched_group *group)
-{
- return cpumask_first(sched_group_span(group));
-}
-
extern int group_balance_cpu(struct sched_group *sg);
#ifdef CONFIG_SCHED_DEBUG
--
2.18.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] sched: Remove unused function group_first_cpu()
2022-06-17 18:11 ` [PATCH 2/2] sched: Remove unused function group_first_cpu() Zhang Qiao
2022-06-17 14:09 ` Valentin Schneider
@ 2022-06-20 5:57 ` Vincent Guittot
2022-06-28 7:16 ` [tip: sched/core] " tip-bot2 for Zhang Qiao
2 siblings, 0 replies; 7+ messages in thread
From: Vincent Guittot @ 2022-06-20 5:57 UTC (permalink / raw)
To: Zhang Qiao
Cc: mingo, peterz, juri.lelli, dietmar.eggemann, rostedt, bsegall,
mgorman, bristot, vschneid, linux-kernel
On Fri, 17 Jun 2022 at 06:14, Zhang Qiao <zhangqiao22@huawei.com> wrote:
>
> group_first_cpu() is an unused function, remove it.
>
> Signed-off-by: Zhang Qiao <zhangqiao22@huawei.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
> kernel/sched/sched.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 01259611beb9..8f57e9391e82 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -1810,15 +1810,6 @@ static inline struct cpumask *group_balance_mask(struct sched_group *sg)
> return to_cpumask(sg->sgc->cpumask);
> }
>
> -/**
> - * group_first_cpu - Returns the first CPU in the cpumask of a sched_group.
> - * @group: The group whose first CPU is to be returned.
> - */
> -static inline unsigned int group_first_cpu(struct sched_group *group)
> -{
> - return cpumask_first(sched_group_span(group));
> -}
> -
> extern int group_balance_cpu(struct sched_group *sg);
>
> #ifdef CONFIG_SCHED_DEBUG
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [tip: sched/core] sched: Remove unused function group_first_cpu()
2022-06-17 18:11 ` [PATCH 2/2] sched: Remove unused function group_first_cpu() Zhang Qiao
2022-06-17 14:09 ` Valentin Schneider
2022-06-20 5:57 ` Vincent Guittot
@ 2022-06-28 7:16 ` tip-bot2 for Zhang Qiao
2 siblings, 0 replies; 7+ messages in thread
From: tip-bot2 for Zhang Qiao @ 2022-06-28 7:16 UTC (permalink / raw)
To: linux-tip-commits
Cc: Zhang Qiao, Peter Zijlstra (Intel),
Valentin Schneider, x86, linux-kernel
The following commit has been merged into the sched/core branch of tip:
Commit-ID: c64b551f6a338eb9724a2f9ef3dddf80ccef2894
Gitweb: https://git.kernel.org/tip/c64b551f6a338eb9724a2f9ef3dddf80ccef2894
Author: Zhang Qiao <zhangqiao22@huawei.com>
AuthorDate: Sat, 18 Jun 2022 02:11:51 +08:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Tue, 28 Jun 2022 09:08:29 +02:00
sched: Remove unused function group_first_cpu()
As of commit afe06efdf07c ("sched: Extend scheduler's asym packing")
group_first_cpu() became an unused function, remove it.
Signed-off-by: Zhang Qiao <zhangqiao22@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
Link: https://lore.kernel.org/r/20220617181151.29980-3-zhangqiao22@huawei.com
---
kernel/sched/sched.h | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 1e34bb4..02c9705 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -1810,15 +1810,6 @@ static inline struct cpumask *group_balance_mask(struct sched_group *sg)
return to_cpumask(sg->sgc->cpumask);
}
-/**
- * group_first_cpu - Returns the first CPU in the cpumask of a sched_group.
- * @group: The group whose first CPU is to be returned.
- */
-static inline unsigned int group_first_cpu(struct sched_group *group)
-{
- return cpumask_first(sched_group_span(group));
-}
-
extern int group_balance_cpu(struct sched_group *sg);
#ifdef CONFIG_SCHED_DEBUG
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [tip: sched/core] sched/fair: Remove redundant word " *"
2022-06-17 18:11 ` [PATCH 1/2] sched/fair: Remove redundant word " *" Zhang Qiao
@ 2022-06-28 7:16 ` tip-bot2 for Zhang Qiao
0 siblings, 0 replies; 7+ messages in thread
From: tip-bot2 for Zhang Qiao @ 2022-06-28 7:16 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Zhang Qiao, Peter Zijlstra (Intel), x86, linux-kernel
The following commit has been merged into the sched/core branch of tip:
Commit-ID: fb95a5a04d72aecdd5e151a4c2f7e4cde368bc10
Gitweb: https://git.kernel.org/tip/fb95a5a04d72aecdd5e151a4c2f7e4cde368bc10
Author: Zhang Qiao <zhangqiao22@huawei.com>
AuthorDate: Sat, 18 Jun 2022 02:11:50 +08:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Tue, 28 Jun 2022 09:08:29 +02:00
sched/fair: Remove redundant word " *"
" *" is redundant. so remove it.
Signed-off-by: Zhang Qiao <zhangqiao22@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20220617181151.29980-2-zhangqiao22@huawei.com
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 8bed757..7400600 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8496,7 +8496,7 @@ static inline int sg_imbalanced(struct sched_group *group)
/*
* group_has_capacity returns true if the group has spare capacity that could
* be used by some tasks.
- * We consider that a group has spare capacity if the * number of task is
+ * We consider that a group has spare capacity if the number of task is
* smaller than the number of CPUs or if the utilization is lower than the
* available capacity for CFS tasks.
* For the latter, we use a threshold to stabilize the state, to take into
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-06-28 7:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-17 18:11 [PATCH 0/2] scheduler loadbalancer cleanup Zhang Qiao
2022-06-17 18:11 ` [PATCH 1/2] sched/fair: Remove redundant word " *" Zhang Qiao
2022-06-28 7:16 ` [tip: sched/core] " tip-bot2 for Zhang Qiao
2022-06-17 18:11 ` [PATCH 2/2] sched: Remove unused function group_first_cpu() Zhang Qiao
2022-06-17 14:09 ` Valentin Schneider
2022-06-20 5:57 ` Vincent Guittot
2022-06-28 7:16 ` [tip: sched/core] " tip-bot2 for Zhang Qiao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).