* [PATCH -next] sched: Remove unused inline function uclamp_bucket_base_value()
@ 2020-09-22 13:24 YueHaibing
2020-09-23 10:21 ` Dietmar Eggemann
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: YueHaibing @ 2020-09-22 13:24 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman
Cc: linux-kernel, YueHaibing
There is no caller in tree, so can remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
kernel/sched/core.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 2d95dc3f4644..1b06b952dbbe 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -940,11 +940,6 @@ static inline unsigned int uclamp_bucket_id(unsigned int clamp_value)
return clamp_value / UCLAMP_BUCKET_DELTA;
}
-static inline unsigned int uclamp_bucket_base_value(unsigned int clamp_value)
-{
- return UCLAMP_BUCKET_DELTA * uclamp_bucket_id(clamp_value);
-}
-
static inline unsigned int uclamp_none(enum uclamp_id clamp_id)
{
if (clamp_id == UCLAMP_MIN)
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] sched: Remove unused inline function uclamp_bucket_base_value()
2020-09-22 13:24 [PATCH -next] sched: Remove unused inline function uclamp_bucket_base_value() YueHaibing
@ 2020-09-23 10:21 ` Dietmar Eggemann
2020-09-25 14:12 ` Vincent Guittot
2020-09-29 7:56 ` [tip: sched/core] " tip-bot2 for YueHaibing
2 siblings, 0 replies; 4+ messages in thread
From: Dietmar Eggemann @ 2020-09-23 10:21 UTC (permalink / raw)
To: YueHaibing, mingo, peterz, juri.lelli, vincent.guittot, rostedt,
bsegall, mgorman
Cc: linux-kernel
On 22/09/2020 15:24, YueHaibing wrote:
> There is no caller in tree, so can remove it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> kernel/sched/core.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 2d95dc3f4644..1b06b952dbbe 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -940,11 +940,6 @@ static inline unsigned int uclamp_bucket_id(unsigned int clamp_value)
> return clamp_value / UCLAMP_BUCKET_DELTA;
> }
>
> -static inline unsigned int uclamp_bucket_base_value(unsigned int clamp_value)
> -{
> - return UCLAMP_BUCKET_DELTA * uclamp_bucket_id(clamp_value);
> -}
> -
> static inline unsigned int uclamp_none(enum uclamp_id clamp_id)
> {
> if (clamp_id == UCLAMP_MIN)
>
LGTM.
It got introduced in commit 60daf9c194106 ("sched/uclamp: Add bucket
local max tracking") but was never used.
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] sched: Remove unused inline function uclamp_bucket_base_value()
2020-09-22 13:24 [PATCH -next] sched: Remove unused inline function uclamp_bucket_base_value() YueHaibing
2020-09-23 10:21 ` Dietmar Eggemann
@ 2020-09-25 14:12 ` Vincent Guittot
2020-09-29 7:56 ` [tip: sched/core] " tip-bot2 for YueHaibing
2 siblings, 0 replies; 4+ messages in thread
From: Vincent Guittot @ 2020-09-25 14:12 UTC (permalink / raw)
To: YueHaibing
Cc: Ingo Molnar, Peter Zijlstra, Juri Lelli, Dietmar Eggemann,
Steven Rostedt, Ben Segall, Mel Gorman, linux-kernel
On Tue, 22 Sep 2020 at 15:24, YueHaibing <yuehaibing@huawei.com> wrote:
>
> There is no caller in tree, so can remove it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
> kernel/sched/core.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 2d95dc3f4644..1b06b952dbbe 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -940,11 +940,6 @@ static inline unsigned int uclamp_bucket_id(unsigned int clamp_value)
> return clamp_value / UCLAMP_BUCKET_DELTA;
> }
>
> -static inline unsigned int uclamp_bucket_base_value(unsigned int clamp_value)
> -{
> - return UCLAMP_BUCKET_DELTA * uclamp_bucket_id(clamp_value);
> -}
> -
> static inline unsigned int uclamp_none(enum uclamp_id clamp_id)
> {
> if (clamp_id == UCLAMP_MIN)
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip: sched/core] sched: Remove unused inline function uclamp_bucket_base_value()
2020-09-22 13:24 [PATCH -next] sched: Remove unused inline function uclamp_bucket_base_value() YueHaibing
2020-09-23 10:21 ` Dietmar Eggemann
2020-09-25 14:12 ` Vincent Guittot
@ 2020-09-29 7:56 ` tip-bot2 for YueHaibing
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot2 for YueHaibing @ 2020-09-29 7:56 UTC (permalink / raw)
To: linux-tip-commits
Cc: YueHaibing, Peter Zijlstra (Intel), Dietmar Eggemann, x86, LKML
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 51bd5121c4eb25b911f6bc1ab4de5fe865fe0dcb
Gitweb: https://git.kernel.org/tip/51bd5121c4eb25b911f6bc1ab4de5fe865fe0dcb
Author: YueHaibing <yuehaibing@huawei.com>
AuthorDate: Tue, 22 Sep 2020 21:24:10 +08:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Fri, 25 Sep 2020 14:23:25 +02:00
sched: Remove unused inline function uclamp_bucket_base_value()
There is no caller in tree, so can remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Link: https://lkml.kernel.org/r/20200922132410.48440-1-yuehaibing@huawei.com
---
kernel/sched/core.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index c36dc1a..dd32d85 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -940,11 +940,6 @@ static inline unsigned int uclamp_bucket_id(unsigned int clamp_value)
return clamp_value / UCLAMP_BUCKET_DELTA;
}
-static inline unsigned int uclamp_bucket_base_value(unsigned int clamp_value)
-{
- return UCLAMP_BUCKET_DELTA * uclamp_bucket_id(clamp_value);
-}
-
static inline unsigned int uclamp_none(enum uclamp_id clamp_id)
{
if (clamp_id == UCLAMP_MIN)
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-29 7:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-22 13:24 [PATCH -next] sched: Remove unused inline function uclamp_bucket_base_value() YueHaibing
2020-09-23 10:21 ` Dietmar Eggemann
2020-09-25 14:12 ` Vincent Guittot
2020-09-29 7:56 ` [tip: sched/core] " tip-bot2 for YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).