From: Vincent Guittot <vincent.guittot@linaro.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
Ingo Molnar <mingo@redhat.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Morten Rasmussen <morten.rasmussen@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel <linux-kernel@vger.kernel.org>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>
Subject: Re: [PATCH 2/6] sched/fair.c: change "has_capacity" to "has_free_capacity"
Date: Thu, 15 May 2014 09:28:05 +0200 [thread overview]
Message-ID: <CAKfTPtCGXVWMD9YhzorFzbEk31h27PRGzv2+ZAvzwHrSrr==2Q@mail.gmail.com> (raw)
In-Reply-To: <20140515072105.GY30445@twins.programming.kicks-ass.net>
On 15 May 2014 09:21, Peter Zijlstra <peterz@infradead.org> wrote:
> On Wed, May 14, 2014 at 04:57:06PM -0400, Nicolas Pitre wrote:
>> The capacity of a CPU/group should be some intrinsic value that doesn't
>> change with task placement. It is like a container which capacity is
>> stable regardless of the amount of liquid in it... unless the container
>> itself is crushed that is, but that's another story.
>>
>> Therefore let's rename "has_capacity" to "has_free_capacity" in order to
>> better convey the wanted meaning.
>>
>
> Yeah, not really, the whole capacity thing is bollocks, but sure we can
> rename it for as long as it still lives ;-)
Hi,
Yes, I'm preparing an update of my rework around cpu_power and this
field will disappear
Vincent
next prev parent reply other threads:[~2014-05-15 7:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 20:57 [PATCH 0/6] sched: expel confusing usage of the term "power" Nicolas Pitre
2014-05-14 20:57 ` [PATCH 1/6] sched/fair.c: remove "power" from struct numa_stats Nicolas Pitre
2014-05-14 20:57 ` [PATCH 2/6] sched/fair.c: change "has_capacity" to "has_free_capacity" Nicolas Pitre
2014-05-15 7:21 ` Peter Zijlstra
2014-05-15 7:28 ` Vincent Guittot [this message]
2014-05-14 20:57 ` [PATCH 3/6] sched/fair.c: disambiguate existing/remaining "capacity" usage Nicolas Pitre
2014-05-15 7:39 ` Vincent Guittot
2014-05-15 16:06 ` Nicolas Pitre
2014-05-14 20:57 ` [PATCH 4/6] sched: let struct sched_group_power care about CPU capacity Nicolas Pitre
2014-05-14 20:57 ` [PATCH 5/6] sched: remove remaining power to the CPU Nicolas Pitre
2014-05-16 9:00 ` Preeti Murthy
2014-05-16 16:34 ` Nicolas Pitre
2014-05-14 20:57 ` [PATCH 6/6] sched: final power vs capacity cleanup Nicolas Pitre
2014-05-15 7:29 ` Peter Zijlstra
2014-05-15 16:12 ` Nicolas Pitre
2014-05-20 3:05 ` Nicolas Pitre
2014-05-15 7:41 ` [PATCH 0/6] sched: expel confusing usage of the term "power" Vincent Guittot
2014-05-15 16:15 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKfTPtCGXVWMD9YhzorFzbEk31h27PRGzv2+ZAvzwHrSrr==2Q@mail.gmail.com' \
--to=vincent.guittot@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=nicolas.pitre@linaro.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).