* Re: [tip:sched/core] sched/fair: Fix rounding bug for asym packing
[not found] <tip-8d2ef665a9bbee36a2a9d855eb4e97d87953fee5@git.kernel.org>
@ 2019-01-21 12:47 ` Peter Zijlstra
2019-01-21 13:22 ` Vincent Guittot
0 siblings, 1 reply; 2+ messages in thread
From: Peter Zijlstra @ 2019-01-21 12:47 UTC (permalink / raw)
To: linux-kernel, mingo, vincent.guittot, tglx, hpa, torvalds
Cc: linux-tip-commits, valentin.schneider
Sorry guys, I seem to have messed this up :/
Valentin pointed me out that I missed v3 and v4 of these patches; v3 got
lost in the x-mas pile and v4 was actually on my todo list for this
week, but I'd forgotten I'd already queued v2.
I'll go queue delta patches.
On Mon, Jan 21, 2019 at 03:33:53AM -0800, tip-bot for Vincent Guittot wrote:
> index 50aa2aba69bd..2ccd6e093326 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -8190,6 +8190,12 @@ static inline void update_sg_lb_stats(struct lb_env *env,
> /* Adjust by relative CPU capacity of the group */
> sgs->group_capacity = group->sgc->capacity;
> sgs->avg_load = (sgs->group_load*SCHED_CAPACITY_SCALE) / sgs->group_capacity;
> + /*
> + * Prevent division rounding to make the computation of imbalance
> + * slightly less than original value and to prevent the rq to be then
> + * selected as busiest queue:
> + */
> + sgs->avg_load += 1;
>
> if (sgs->sum_nr_running)
> sgs->load_per_task = sgs->sum_weighted_load / sgs->sum_nr_running;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [tip:sched/core] sched/fair: Fix rounding bug for asym packing
2019-01-21 12:47 ` [tip:sched/core] sched/fair: Fix rounding bug for asym packing Peter Zijlstra
@ 2019-01-21 13:22 ` Vincent Guittot
0 siblings, 0 replies; 2+ messages in thread
From: Vincent Guittot @ 2019-01-21 13:22 UTC (permalink / raw)
To: Peter Zijlstra
Cc: linux-kernel, Ingo Molnar, Thomas Gleixner, H. Peter Anvin,
Linus Torvalds, linux-tip-commits, Valentin Schneider
On Mon, 21 Jan 2019 at 13:47, Peter Zijlstra <peterz@infradead.org> wrote:
>
>
> Sorry guys, I seem to have messed this up :/
>
> Valentin pointed me out that I missed v3 and v4 of these patches; v3 got
I was about to sent an email about that too
> lost in the x-mas pile and v4 was actually on my todo list for this
> week, but I'd forgotten I'd already queued v2.
>
> I'll go queue delta patches.
Thanks
>
> On Mon, Jan 21, 2019 at 03:33:53AM -0800, tip-bot for Vincent Guittot wrote:
> > index 50aa2aba69bd..2ccd6e093326 100644
> > --- a/kernel/sched/fair.c
> > +++ b/kernel/sched/fair.c
> > @@ -8190,6 +8190,12 @@ static inline void update_sg_lb_stats(struct lb_env *env,
> > /* Adjust by relative CPU capacity of the group */
> > sgs->group_capacity = group->sgc->capacity;
> > sgs->avg_load = (sgs->group_load*SCHED_CAPACITY_SCALE) / sgs->group_capacity;
> > + /*
> > + * Prevent division rounding to make the computation of imbalance
> > + * slightly less than original value and to prevent the rq to be then
> > + * selected as busiest queue:
> > + */
> > + sgs->avg_load += 1;
> >
> > if (sgs->sum_nr_running)
> > sgs->load_per_task = sgs->sum_weighted_load / sgs->sum_nr_running;
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-21 13:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tip-8d2ef665a9bbee36a2a9d855eb4e97d87953fee5@git.kernel.org>
2019-01-21 12:47 ` [tip:sched/core] sched/fair: Fix rounding bug for asym packing Peter Zijlstra
2019-01-21 13:22 ` Vincent Guittot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).