From: Vincent Guittot <vincent.guittot@linaro.org>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
linux-kernel@vger.kernel.org, parth@linux.ibm.com,
qais.yousef@arm.com, chris.hyser@oracle.com,
pkondeti@codeaurora.org, Valentin.Schneider@arm.com,
patrick.bellasi@matbug.net, David.Laight@aculab.com,
pjt@google.com, pavel@ucw.cz, tj@kernel.org,
dhaval.giani@oracle.com, qperret@google.com,
tim.c.chen@linux.intel.com
Subject: Re: [PATCH 3/6] sched: Allow sched_{get,set}attr to change latency_nice of the task
Date: Mon, 28 Mar 2022 14:41:27 +0200 [thread overview]
Message-ID: <CAKfTPtCr0se4T=21VONvsR1wmxhWFiLDeh-Wpc3xhFxUYMh5OQ@mail.gmail.com> (raw)
In-Reply-To: <6bee2e39-34a8-905f-084f-379b8476ea98@arm.com>
On Mon, 28 Mar 2022 at 11:23, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>
> On 11/03/2022 17:14, Vincent Guittot wrote:
>
> [...]
>
> > @@ -98,6 +99,22 @@ struct sched_param {
> > * scheduled on a CPU with no more capacity than the specified value.
> > *
> > * A task utilization boundary can be reset by setting the attribute to -1.
> > + *
> > + * Latency Tolerance Attributes
> > + * ===========================
> > + *
> > + * A subset of sched_attr attributes allows to specify the relative latency
> > + * requirements of a task with respect to the other tasks running/queued in the
> > + * system.
> > + *
> > + * @ sched_latency_nice task's latency_nice value
> > + *
> > + * The latency_nice of a task can have any value in a range of
> > + * [LATENCY_NICE_MIN..LATENCY_NICE_MAX].
>
> s/LATENCY_NICE_MIN/MIN_LATENCY_NICE
> s/LATENCY_NICE_MAX/MAX_LATENCY_NICE
yes
>
> > + * A task with latency_nice with the value of LATENCY_NICE_MIN can be
> > + * taken for a task with lower latency requirements as opposed to the task with
> > + * higher latency_nice.
>
> low latency nice (priority): -20 -> high weight: 1024 ... Doesn't a task
> with MIN_LATENCY_NICE -20 have the highest latency requirements?
IIUC, What Parth wanted to say here is that low latency nice
(priority): -20 is taken for a task which needs low latency. The low
applies to latency not requirements
>
> [...]
next prev parent reply other threads:[~2022-03-28 12:41 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 16:14 [PATCH 0/6] Add latency_nice priority Vincent Guittot
2022-03-11 16:14 ` [PATCH 1/6] sched: Introduce latency-nice as a per-task attribute Vincent Guittot
2022-03-11 16:14 ` [PATCH 2/6] sched/core: Propagate parent task's latency requirements to the child task Vincent Guittot
2022-03-22 0:22 ` Tim Chen
2022-03-22 14:57 ` Vincent Guittot
2022-03-11 16:14 ` [PATCH 3/6] sched: Allow sched_{get,set}attr to change latency_nice of the task Vincent Guittot
2022-03-22 0:22 ` Tim Chen
2022-03-22 14:55 ` Vincent Guittot
2022-03-28 9:23 ` Dietmar Eggemann
2022-03-28 12:41 ` Vincent Guittot [this message]
2022-03-11 16:14 ` [PATCH 4/6] sched/core: Add permission checks for setting the latency_nice value Vincent Guittot
2022-03-11 16:14 ` [RFC 5/6] sched/fair: Take into account latency nice at wakeup Vincent Guittot
2022-03-15 0:53 ` Josh Don
2022-03-15 13:54 ` Vincent Guittot
2022-03-28 9:24 ` Dietmar Eggemann
2022-03-28 12:51 ` Vincent Guittot
2022-05-01 15:58 ` Tao Zhou
2022-05-02 9:54 ` Vincent Guittot
2022-05-02 12:30 ` Vincent Guittot
2022-05-02 15:08 ` Tao Zhou
2022-05-02 15:26 ` Tao Zhou
2022-05-02 15:47 ` Tao Zhou
2022-05-02 16:21 ` Vincent Guittot
2022-05-02 23:09 ` Tao Zhou
2022-05-03 2:30 ` Tao Zhou
2022-05-03 12:40 ` Vincent Guittot
2022-05-04 11:14 ` Chen Yu
2022-05-04 12:39 ` Vincent Guittot
2022-03-11 16:14 ` [RFC 6/6] sched/fair: Add sched group latency support Vincent Guittot
2022-03-15 0:58 ` Josh Don
2022-03-15 17:07 ` Vincent Guittot
2022-03-21 17:24 ` Tejun Heo
2022-03-22 16:10 ` Vincent Guittot
2022-03-22 16:40 ` Tejun Heo
2022-03-23 15:04 ` Vincent Guittot
2022-03-23 18:20 ` Chris Hyser
2022-03-22 16:41 ` Tim Chen
2022-03-23 15:23 ` Vincent Guittot
2022-03-22 16:39 ` [PATCH 0/6] Add latency_nice priority Qais Yousef
2022-03-23 15:32 ` Vincent Guittot
2022-03-24 17:25 ` Qais Yousef
2022-03-25 13:27 ` Vincent Guittot
2022-03-28 16:27 ` Qais Yousef
2022-03-30 7:30 ` Vincent Guittot
2022-03-28 9:24 ` Dietmar Eggemann
2022-03-28 12:56 ` Vincent Guittot
2022-04-01 12:15 ` Qais Yousef
2022-04-02 8:46 ` Vincent Guittot
2022-04-09 17:08 ` Qais Yousef
2022-04-09 17:28 ` Steven Rostedt
2022-04-09 18:10 ` Qais Yousef
2022-04-11 7:26 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKfTPtCr0se4T=21VONvsR1wmxhWFiLDeh-Wpc3xhFxUYMh5OQ@mail.gmail.com' \
--to=vincent.guittot@linaro.org \
--cc=David.Laight@aculab.com \
--cc=Valentin.Schneider@arm.com \
--cc=bsegall@google.com \
--cc=chris.hyser@oracle.com \
--cc=dhaval.giani@oracle.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=parth@linux.ibm.com \
--cc=patrick.bellasi@matbug.net \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=pkondeti@codeaurora.org \
--cc=qais.yousef@arm.com \
--cc=qperret@google.com \
--cc=rostedt@goodmis.org \
--cc=tim.c.chen@linux.intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).