* [PATCH] riscv, qemu_fw_cfg: Add support for RISC-V architecture
@ 2023-10-11 11:47 Björn Töpel
2023-10-11 13:01 ` Clément Léger
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Björn Töpel @ 2023-10-11 11:47 UTC (permalink / raw)
To: Gabriel Somlo, Michael S. Tsirkin, qemu-devel
Cc: Björn Töpel, linux-kernel, linux-riscv
From: Björn Töpel <bjorn@rivosinc.com>
Qemu fw_cfg support was missing for RISC-V, which made it hard to do
proper vmcore dumps from qemu.
Add the missing RISC-V arch-defines.
You can now do vmcore dumps from qemu. Add "-device vmcoreinfo" to the
qemu command-line. From the qemu montior:
(qemu) dump-guest-memory vmcore
The vmcore can now be used, e.g., with the "crash" utility.
Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
---
drivers/firmware/Kconfig | 2 +-
drivers/firmware/qemu_fw_cfg.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index b59e3041fd62..f05ff56629b3 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -155,7 +155,7 @@ config RASPBERRYPI_FIRMWARE
config FW_CFG_SYSFS
tristate "QEMU fw_cfg device support in sysfs"
- depends on SYSFS && (ARM || ARM64 || PARISC || PPC_PMAC || SPARC || X86)
+ depends on SYSFS && (ARM || ARM64 || PARISC || PPC_PMAC || RISCV || SPARC || X86)
depends on HAS_IOPORT_MAP
default n
help
diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
index a69399a6b7c0..1448f61173b3 100644
--- a/drivers/firmware/qemu_fw_cfg.c
+++ b/drivers/firmware/qemu_fw_cfg.c
@@ -211,7 +211,7 @@ static void fw_cfg_io_cleanup(void)
/* arch-specific ctrl & data register offsets are not available in ACPI, DT */
#if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CFG_DATA_OFF))
-# if (defined(CONFIG_ARM) || defined(CONFIG_ARM64))
+# if (defined(CONFIG_ARM) || defined(CONFIG_ARM64) || defined(CONFIG_RISCV))
# define FW_CFG_CTRL_OFF 0x08
# define FW_CFG_DATA_OFF 0x00
# define FW_CFG_DMA_OFF 0x10
base-commit: 1c8b86a3799f7e5be903c3f49fcdaee29fd385b5
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv, qemu_fw_cfg: Add support for RISC-V architecture
2023-10-11 11:47 [PATCH] riscv, qemu_fw_cfg: Add support for RISC-V architecture Björn Töpel
@ 2023-10-11 13:01 ` Clément Léger
2023-10-12 0:08 ` Alistair Francis
2023-10-12 9:46 ` Michael S. Tsirkin
2 siblings, 0 replies; 4+ messages in thread
From: Clément Léger @ 2023-10-11 13:01 UTC (permalink / raw)
To: Björn Töpel, Gabriel Somlo, Michael S. Tsirkin, qemu-devel
Cc: Björn Töpel, linux-kernel, linux-riscv
Hi Björn,
On 11/10/2023 13:47, Björn Töpel wrote:
> From: Björn Töpel <bjorn@rivosinc.com>
>
> Qemu fw_cfg support was missing for RISC-V, which made it hard to do
> proper vmcore dumps from qemu.
>
> Add the missing RISC-V arch-defines.
>
> You can now do vmcore dumps from qemu. Add "-device vmcoreinfo" to the
> qemu command-line. From the qemu montior:
small typo here: monitor
> (qemu) dump-guest-memory vmcore
>
> The vmcore can now be used, e.g., with the "crash" utility.
>
> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
> ---
> drivers/firmware/Kconfig | 2 +-
> drivers/firmware/qemu_fw_cfg.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index b59e3041fd62..f05ff56629b3 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -155,7 +155,7 @@ config RASPBERRYPI_FIRMWARE
>
> config FW_CFG_SYSFS
> tristate "QEMU fw_cfg device support in sysfs"
> - depends on SYSFS && (ARM || ARM64 || PARISC || PPC_PMAC || SPARC || X86)
> + depends on SYSFS && (ARM || ARM64 || PARISC || PPC_PMAC || RISCV || SPARC || X86)
> depends on HAS_IOPORT_MAP
> default n
> help
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index a69399a6b7c0..1448f61173b3 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -211,7 +211,7 @@ static void fw_cfg_io_cleanup(void)
>
> /* arch-specific ctrl & data register offsets are not available in ACPI, DT */
> #if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CFG_DATA_OFF))
> -# if (defined(CONFIG_ARM) || defined(CONFIG_ARM64))
> +# if (defined(CONFIG_ARM) || defined(CONFIG_ARM64) || defined(CONFIG_RISCV))
> # define FW_CFG_CTRL_OFF 0x08
> # define FW_CFG_DATA_OFF 0x00
> # define FW_CFG_DMA_OFF 0x10
>
> base-commit: 1c8b86a3799f7e5be903c3f49fcdaee29fd385b5
I didn't know that qemu could generate vmcore files. BTW, whenever I
don't have 'crash' at hand, I often use them with gdb and vmlinux-gdb.py
debugging scripts. Anyway, works as expected:
Tested-by: Clément Léger <cleger@rivosinc.com>
Clément
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv, qemu_fw_cfg: Add support for RISC-V architecture
2023-10-11 11:47 [PATCH] riscv, qemu_fw_cfg: Add support for RISC-V architecture Björn Töpel
2023-10-11 13:01 ` Clément Léger
@ 2023-10-12 0:08 ` Alistair Francis
2023-10-12 9:46 ` Michael S. Tsirkin
2 siblings, 0 replies; 4+ messages in thread
From: Alistair Francis @ 2023-10-12 0:08 UTC (permalink / raw)
To: Björn Töpel
Cc: Gabriel Somlo, Michael S. Tsirkin, qemu-devel,
Björn Töpel, linux-kernel, linux-riscv
On Wed, Oct 11, 2023 at 11:34 PM Björn Töpel <bjorn@kernel.org> wrote:
>
> From: Björn Töpel <bjorn@rivosinc.com>
>
> Qemu fw_cfg support was missing for RISC-V, which made it hard to do
> proper vmcore dumps from qemu.
>
> Add the missing RISC-V arch-defines.
>
> You can now do vmcore dumps from qemu. Add "-device vmcoreinfo" to the
> qemu command-line. From the qemu montior:
> (qemu) dump-guest-memory vmcore
>
> The vmcore can now be used, e.g., with the "crash" utility.
>
> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> drivers/firmware/Kconfig | 2 +-
> drivers/firmware/qemu_fw_cfg.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index b59e3041fd62..f05ff56629b3 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -155,7 +155,7 @@ config RASPBERRYPI_FIRMWARE
>
> config FW_CFG_SYSFS
> tristate "QEMU fw_cfg device support in sysfs"
> - depends on SYSFS && (ARM || ARM64 || PARISC || PPC_PMAC || SPARC || X86)
> + depends on SYSFS && (ARM || ARM64 || PARISC || PPC_PMAC || RISCV || SPARC || X86)
> depends on HAS_IOPORT_MAP
> default n
> help
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index a69399a6b7c0..1448f61173b3 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -211,7 +211,7 @@ static void fw_cfg_io_cleanup(void)
>
> /* arch-specific ctrl & data register offsets are not available in ACPI, DT */
> #if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CFG_DATA_OFF))
> -# if (defined(CONFIG_ARM) || defined(CONFIG_ARM64))
> +# if (defined(CONFIG_ARM) || defined(CONFIG_ARM64) || defined(CONFIG_RISCV))
> # define FW_CFG_CTRL_OFF 0x08
> # define FW_CFG_DATA_OFF 0x00
> # define FW_CFG_DMA_OFF 0x10
>
> base-commit: 1c8b86a3799f7e5be903c3f49fcdaee29fd385b5
> --
> 2.39.2
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv, qemu_fw_cfg: Add support for RISC-V architecture
2023-10-11 11:47 [PATCH] riscv, qemu_fw_cfg: Add support for RISC-V architecture Björn Töpel
2023-10-11 13:01 ` Clément Léger
2023-10-12 0:08 ` Alistair Francis
@ 2023-10-12 9:46 ` Michael S. Tsirkin
2 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2023-10-12 9:46 UTC (permalink / raw)
To: Björn Töpel
Cc: Gabriel Somlo, qemu-devel, Björn Töpel, linux-kernel,
linux-riscv
On Wed, Oct 11, 2023 at 01:47:21PM +0200, Björn Töpel wrote:
> From: Björn Töpel <bjorn@rivosinc.com>
>
> Qemu fw_cfg support was missing for RISC-V, which made it hard to do
> proper vmcore dumps from qemu.
>
> Add the missing RISC-V arch-defines.
>
> You can now do vmcore dumps from qemu. Add "-device vmcoreinfo" to the
> qemu command-line. From the qemu montior:
> (qemu) dump-guest-memory vmcore
>
> The vmcore can now be used, e.g., with the "crash" utility.
>
> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
> ---
with typo fixed:
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> drivers/firmware/Kconfig | 2 +-
> drivers/firmware/qemu_fw_cfg.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index b59e3041fd62..f05ff56629b3 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -155,7 +155,7 @@ config RASPBERRYPI_FIRMWARE
>
> config FW_CFG_SYSFS
> tristate "QEMU fw_cfg device support in sysfs"
> - depends on SYSFS && (ARM || ARM64 || PARISC || PPC_PMAC || SPARC || X86)
> + depends on SYSFS && (ARM || ARM64 || PARISC || PPC_PMAC || RISCV || SPARC || X86)
> depends on HAS_IOPORT_MAP
> default n
> help
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index a69399a6b7c0..1448f61173b3 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -211,7 +211,7 @@ static void fw_cfg_io_cleanup(void)
>
> /* arch-specific ctrl & data register offsets are not available in ACPI, DT */
> #if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CFG_DATA_OFF))
> -# if (defined(CONFIG_ARM) || defined(CONFIG_ARM64))
> +# if (defined(CONFIG_ARM) || defined(CONFIG_ARM64) || defined(CONFIG_RISCV))
> # define FW_CFG_CTRL_OFF 0x08
> # define FW_CFG_DATA_OFF 0x00
> # define FW_CFG_DMA_OFF 0x10
>
> base-commit: 1c8b86a3799f7e5be903c3f49fcdaee29fd385b5
> --
> 2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-12 9:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-11 11:47 [PATCH] riscv, qemu_fw_cfg: Add support for RISC-V architecture Björn Töpel
2023-10-11 13:01 ` Clément Léger
2023-10-12 0:08 ` Alistair Francis
2023-10-12 9:46 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).