* [PATCH 2/4] cpufreq: exynos: Consider hibernation in pm notifier
@ 2013-11-19 13:29 Jonghwan Choi
2013-11-19 14:32 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Jonghwan Choi @ 2013-11-19 13:29 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar, Kukjin Kim
Cc: linux-kernel, linux-samsung-soc, Jonghwan Choi
Frequency lock should be considered in suspend/hibernation.
Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
---
drivers/cpufreq/exynos-cpufreq.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
index f3c2287..cd05b0a 100644
--- a/drivers/cpufreq/exynos-cpufreq.c
+++ b/drivers/cpufreq/exynos-cpufreq.c
@@ -187,6 +187,7 @@ static int exynos_cpufreq_pm_notifier(struct notifier_block *notifier,
int ret;
switch (pm_event) {
+ case PM_HIBERNATION_PREPARE:
case PM_SUSPEND_PREPARE:
mutex_lock(&cpufreq_lock);
frequency_locked = true;
@@ -198,6 +199,8 @@ static int exynos_cpufreq_pm_notifier(struct notifier_block *notifier,
break;
+ case PM_POST_HIBERNATION:
+ case PM_POST_RESTORE:
case PM_POST_SUSPEND:
mutex_lock(&cpufreq_lock);
frequency_locked = false;
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/4] cpufreq: exynos: Consider hibernation in pm notifier
2013-11-19 13:29 [PATCH 2/4] cpufreq: exynos: Consider hibernation in pm notifier Jonghwan Choi
@ 2013-11-19 14:32 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2013-11-19 14:32 UTC (permalink / raw)
To: Jonghwan Choi
Cc: Rafael J. Wysocki, Kukjin Kim, Linux Kernel Mailing List,
linux-samsung-soc, Jonghwan Choi
On 19 November 2013 18:59, Jonghwan Choi <jhbird.choi@gmail.com> wrote:
> Frequency lock should be considered in suspend/hibernation.
These could turn out to be important logs for future. Please write
with more effort..
> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
> ---
> drivers/cpufreq/exynos-cpufreq.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
> index f3c2287..cd05b0a 100644
> --- a/drivers/cpufreq/exynos-cpufreq.c
> +++ b/drivers/cpufreq/exynos-cpufreq.c
> @@ -187,6 +187,7 @@ static int exynos_cpufreq_pm_notifier(struct notifier_block *notifier,
> int ret;
>
> switch (pm_event) {
> + case PM_HIBERNATION_PREPARE:
> case PM_SUSPEND_PREPARE:
> mutex_lock(&cpufreq_lock);
> frequency_locked = true;
> @@ -198,6 +199,8 @@ static int exynos_cpufreq_pm_notifier(struct notifier_block *notifier,
>
> break;
>
> + case PM_POST_HIBERNATION:
> + case PM_POST_RESTORE:
> case PM_POST_SUSPEND:
> mutex_lock(&cpufreq_lock);
> frequency_locked = false;
@Rafael: So we have few more drivers which are already doing such
stuff (even tegra as well)..
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-19 14:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-19 13:29 [PATCH 2/4] cpufreq: exynos: Consider hibernation in pm notifier Jonghwan Choi
2013-11-19 14:32 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).