From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, robin.randhawa@arm.com,
Steve.Bannister@arm.com, Liviu.Dudau@arm.com,
charles.garcia-tobin@arm.com, linaro-dev@lists.linaro.org,
francescolavra.fl@gmail.com, toddpoynor@google.com
Subject: Re: [PATCH V2 1/4] cpufreq: Add per policy governor-init/exit infrastructure
Date: Fri, 22 Feb 2013 07:38:12 +0530 [thread overview]
Message-ID: <CAKohpom8HiBEXE54BL72s-nWaeXzSRTrp7=MQKrJcon17T9tXQ@mail.gmail.com> (raw)
In-Reply-To: <3793606.bilcxohA80@vostro.rjw.lan>
On 22 February 2013 05:05, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Monday, February 11, 2013 01:20:00 PM Viresh Kumar wrote:
>> This patch is inclined towards providing this infrastructure. Because we are
>> required to allocate governor's resources dynamically now, we must do it at
>> policy creation and end. And so got CPUFREQ_GOV_POLICY_INIT/EXIT.
>
> Are those new events NOPs now?
No. These are used atleast for ondemand & conservative.
>> +#define CPUFREQ_GOV_POLICY_INIT 4
>> +#define CPUFREQ_GOV_POLICY_EXIT 4
>
> Why don't you use different values here?
>
> If you need only one value, one #define should be sufficient.
Naah, something happened... I got fixed this locally but couldn't
get that into the commit somehow. EXIT should have 5 here.
next prev parent reply other threads:[~2013-02-22 2:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 7:49 [PATCH V2 0/4] CPUFreq: Implement per policy instances of governors Viresh Kumar
2013-02-11 7:50 ` [PATCH V2 1/4] cpufreq: Add per policy governor-init/exit infrastructure Viresh Kumar
2013-02-21 23:35 ` Rafael J. Wysocki
2013-02-22 2:08 ` Viresh Kumar [this message]
2013-02-22 2:21 ` Rafael J. Wysocki
2013-02-22 2:19 ` Viresh Kumar
2013-02-22 2:31 ` Viresh Kumar
2013-02-11 7:50 ` [PATCH V2 2/4] cpufreq: governor: Implement per policy instances of governors Viresh Kumar
2013-02-22 2:23 ` Viresh Kumar
2013-02-11 7:50 ` [PATCH V2 3/4] cpufreq: Add Kconfig option to enable/disable have_multiple_policies Viresh Kumar
2013-02-21 23:53 ` Rafael J. Wysocki
2013-02-22 2:14 ` Viresh Kumar
2013-02-22 2:29 ` Rafael J. Wysocki
2013-02-22 2:44 ` Viresh Kumar
2013-02-11 7:50 ` [PATCH V2 4/4] cpufreq: Get rid of "struct global_attr" Viresh Kumar
2013-02-21 23:45 ` Rafael J. Wysocki
2013-02-22 2:17 ` Viresh Kumar
2013-02-22 2:33 ` Rafael J. Wysocki
2013-02-22 2:32 ` Viresh Kumar
2013-02-22 2:46 ` [PATCH V2 0/4] CPUFreq: Implement per policy instances of governors Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKohpom8HiBEXE54BL72s-nWaeXzSRTrp7=MQKrJcon17T9tXQ@mail.gmail.com' \
--to=viresh.kumar@linaro.org \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=charles.garcia-tobin@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=francescolavra.fl@gmail.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=robin.randhawa@arm.com \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).